Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: syyang@lontium.com, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, andrzej.hajda@intel.com,
	neil.armstrong@linaro.org, dmitry.baryshkov@oss.qualcomm.com,
	maarten.lankhorst@linux.intel.com, rfoss@kernel.org,
	mripard@kernel.org
Cc: Laurent.pinchart@ideasonboard.com, tzimmermann@suse.de,
	jonas@kwiboo.se, jernej.skrabec@gmail.com,
	devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, yangsunyun1993@gmail.com,
	xmzhu@lontium.corp-partner.google.com, xmzhu@lontium.com,
	rlyu@lontium.com, xbpeng@lontium.com
Subject: Re: [PATCH v6 2/2] drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver
Date: Thu, 25 Jun 2026 15:24:02 +0200	[thread overview]
Message-ID: <7597d9b3-7e55-4b14-a34a-b24b2436e349@kernel.org> (raw)
In-Reply-To: <20260508134009.4582-3-syyang@lontium.com>

On 08/05/2026 15:40, syyang@lontium.com wrote:
> +
> +static int lt9611c_probe(struct i2c_client *client)
> +{
> +	const struct i2c_device_id *id = i2c_client_get_device_id(client);
> +	struct lt9611c *lt9611c;
> +	struct device *dev = &client->dev;
> +	bool fw_updated = false;
> +	int ret;
> +
> +	crc8_populate_msb(lt9611c_crc8_table, LT9611C_CRC_POLYNOMIAL);
> +
> +	if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C))
> +		return dev_err_probe(dev, -ENODEV, "device doesn't support I2C\n");
> +
> +	lt9611c = devm_drm_bridge_alloc(dev, struct lt9611c, bridge, &lt9611c_bridge_funcs);
> +	if (IS_ERR(lt9611c))
> +		return dev_err_probe(dev, PTR_ERR(lt9611c), "drm bridge alloc failed.\n");
> +
> +	lt9611c->dev = dev;
> +	lt9611c->client = client;
> +	lt9611c->chip_type = id->driver_data;

Also, NULL pointer exception here. With simple look I found at least two
easy to reproduce and trigger bugs which makes me questioning how did
you test it.


Best regards,
Krzysztof

      parent reply	other threads:[~2026-06-25 13:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 13:40 [PATCH v6 0/2] Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver syyang
2026-05-08 13:40 ` [PATCH v6 2/2] drm/bridge: " syyang
2026-06-25 12:54   ` Krzysztof Kozlowski
2026-06-25 13:14     ` Sunyun Yang
2026-06-25 13:17       ` Krzysztof Kozlowski
2026-06-25 13:26         ` Sunyun Yang
2026-06-25 13:40           ` Sunyun Yang
2026-06-25 13:51             ` Krzysztof Kozlowski
2026-06-26  2:15               ` Sunyun Yang
2026-06-26  7:38                 ` Krzysztof Kozlowski
2026-06-26  8:04                   ` Sunyun Yang
2026-06-26  7:49                 ` Maxime Ripard
2026-06-26  8:13                   ` Sunyun Yang
2026-06-26  8:26                     ` Maxime Ripard
2026-06-26  8:40                       ` Sunyun Yang
2026-06-26  9:05                         ` Sunyun Yang
2026-06-26  9:31                           ` Maxime Ripard
2026-06-26  9:45                             ` Sunyun Yang
2026-06-26  9:53                               ` Maxime Ripard
2026-06-26 10:08                                 ` Sunyun Yang
2026-06-25 13:50           ` Krzysztof Kozlowski
2026-06-25 14:57           ` Dmitry Baryshkov
2026-06-26  1:55             ` Sunyun Yang
2026-06-26  7:40               ` Krzysztof Kozlowski
2026-06-25 13:24   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7597d9b3-7e55-4b14-a34a-b24b2436e349@kernel.org \
    --to=krzk@kernel.org \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    --cc=rlyu@lontium.com \
    --cc=robh@kernel.org \
    --cc=syyang@lontium.com \
    --cc=tzimmermann@suse.de \
    --cc=xbpeng@lontium.com \
    --cc=xmzhu@lontium.com \
    --cc=xmzhu@lontium.corp-partner.google.com \
    --cc=yangsunyun1993@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox