From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sunyun Yang <syyang@lontium.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
andrzej.hajda@intel.com, neil.armstrong@linaro.org,
dmitry.baryshkov@oss.qualcomm.com,
maarten.lankhorst@linux.intel.com, rfoss@kernel.org,
mripard@kernel.org, Laurent.pinchart@ideasonboard.com,
tzimmermann@suse.de, jonas@kwiboo.se, jernej.skrabec@gmail.com,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
xmzhu@lontium.corp-partner.google.com, xmzhu@lontium.com,
rlyu@lontium.com, xbpeng@lontium.com
Subject: Re: [PATCH v6 2/2] drm/bridge: Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver
Date: Thu, 25 Jun 2026 15:17:13 +0200 [thread overview]
Message-ID: <a0352a42-15db-4c7a-ae73-8a4e1543cd50@kernel.org> (raw)
In-Reply-To: <CAFQXuNbKBfyeQL3N3P5QY=6BWoD3O6DSbXN-WMA1rRG9vCs3Kg@mail.gmail.com>
On 25/06/2026 15:14, Sunyun Yang wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 于2026年6月25日周四 20:54写道:
>>
>> On 08/05/2026 15:40, syyang@lontium.com wrote:
>>> +
>>> +static void lt9611c_reset(struct lt9611c *lt9611c)
>>> +{
>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 1);
>>> + msleep(20);
>>> +
>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 0);
>>> + msleep(20);
>>> +
>>> + gpiod_set_value_cansleep(lt9611c->reset_gpio, 1);
>>
>> This is just plain wrong. Why do you assert, then de-assert and then
>> finally assert AGAIN the reset leaving the device in powerdown stage?
>>
> I am using software to emulate the hardware RESET button on our EVB.
> When the hardware RESET button is pressed while our chip is running,
> the signal level changes from HIGH to LOW and then back to HIGH.
>
> Of course, we can also use the following:
> static void lt9611c_reset(struct lt9611c *lt9611c)
> {
> gpiod_set_value_cansleep(lt9611c->reset_gpio, 0);
> msleep(50);
> gpiod_set_value_cansleep(lt9611c->reset_gpio, 1);
> msleep(20);
> }
Makes no sense either and you just did not get the point and did not
answer my question. I asked WHY you leave asserted. Answer "we emulate"
is just plain wrong.
So again please answer:
Why do you leave device with reset asserted?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-06-25 13:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 13:40 [PATCH v6 0/2] Add Lontium LT9611C(EX/UXD) MIPI DSI to HDMI driver syyang
2026-05-08 13:40 ` [PATCH v6 2/2] drm/bridge: " syyang
2026-06-25 12:54 ` Krzysztof Kozlowski
2026-06-25 13:14 ` Sunyun Yang
2026-06-25 13:17 ` Krzysztof Kozlowski [this message]
2026-06-25 13:26 ` Sunyun Yang
2026-06-25 13:40 ` Sunyun Yang
2026-06-25 13:51 ` Krzysztof Kozlowski
2026-06-25 13:50 ` Krzysztof Kozlowski
2026-06-25 14:57 ` Dmitry Baryshkov
2026-06-25 13:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0352a42-15db-4c7a-ae73-8a4e1543cd50@kernel.org \
--to=krzk@kernel.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=rlyu@lontium.com \
--cc=robh@kernel.org \
--cc=syyang@lontium.com \
--cc=tzimmermann@suse.de \
--cc=xbpeng@lontium.com \
--cc=xmzhu@lontium.com \
--cc=xmzhu@lontium.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox