Re: [PATCH v6 1/1] arm64: dts: add tqma9596la-mba95xxca

[Alexander Stein <alexander.stein@ew.tq-group.com>]

Hi, Frank,

Am Mittwoch, 1. Juli 2026, 17:02:43 CEST schrieb Frank Li:
> On Wed, Jul 01, 2026 at 10:50:11AM +0200, Alexander Stein wrote:
> > Hi,
> >
> > here some comments about the findings.
> >
> > Am Mittwoch, 1. Juli 2026, 10:45:22 CEST schrieb sashiko-bot@kernel.org:
> > > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> > > - [High] Hardware components (PWM fan and 10G SFP) remain permanently unpowered due to disabled regulators
> > > - [Low] Dead code: Unreferenced `pinctrl_ethphy0` node
> > > --
> > >
> > > commit f54617810555494fd6b435aa3ac070a14b264e01
> > > Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > >
> > > arm64: dts: add tqma9596la-mba95xxca
> > >
> > > This adds support for TQMa95xxLA modules, designed to be soldered
> > > on a carrier board. MBa95xxCA is a carrier reference board / starter kit
> > > design. Enable the external accessible PCIe controllers as host, add
> > > clocking and reset GPIO.
> > >
> > > > diff --git a/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> > > > new file mode 100644
> > > > index 0000000000000..e90f37bbdcd80
> > > > --- /dev/null
> > > > +++ b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> > >
> ...
> > >
> > > > +	pinctrl_ethphy0: ethphy0grp {
> > > > +		fsl,pins = <IMX95_PAD_PDM_BIT_STREAM0__AONMIX_TOP_GPIO1_IO_BIT9		0x1100>;
> > > > +	};
> > >
> > > [Severity: Low]
> > > Is this pinctrl group missing a reference?
> > >
> > > It defines pin configuration for the ethphy0 IRQ pin, but doesn't seem to be
> > > referenced by the ethphy0 node (e.g., via pinctrl-0) or any other node.
> >
> > This pad is connected to gpio1 which is under control of the system manager,
> > so Cortex-A55 (Linux) has no access to it.
> 
> If not one refer it, it will never be set to GPIO at all.

At on Linux side. But this pad is owned by System manager (SM) and will be
set and used there exclusively.

Best regards,
Alexander
-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/