From: Frank Li <Frank.li@oss.nxp.com>
To: Alexander Stein <alexander.stein@ew.tq-group.com>
Cc: sashiko-reviews@lists.linux.dev, Frank.Li@kernel.org,
robh@kernel.org, devicetree@vger.kernel.org,
wsa+renesas@sang-engineering.com, imx@lists.linux.dev,
conor+dt@kernel.org
Subject: Re: [PATCH v6 1/1] arm64: dts: add tqma9596la-mba95xxca
Date: Wed, 1 Jul 2026 10:02:43 -0500 [thread overview]
Message-ID: <akUsE6A6lX0mgM5g@SMW015318> (raw)
In-Reply-To: <15795907.O9o76ZdvQC@steina-w>
On Wed, Jul 01, 2026 at 10:50:11AM +0200, Alexander Stein wrote:
> Hi,
>
> here some comments about the findings.
>
> Am Mittwoch, 1. Juli 2026, 10:45:22 CEST schrieb sashiko-bot@kernel.org:
> > Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> > - [High] Hardware components (PWM fan and 10G SFP) remain permanently unpowered due to disabled regulators
> > - [Low] Dead code: Unreferenced `pinctrl_ethphy0` node
> > --
> >
> > commit f54617810555494fd6b435aa3ac070a14b264e01
> > Author: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> >
> > arm64: dts: add tqma9596la-mba95xxca
> >
> > This adds support for TQMa95xxLA modules, designed to be soldered
> > on a carrier board. MBa95xxCA is a carrier reference board / starter kit
> > design. Enable the external accessible PCIe controllers as host, add
> > clocking and reset GPIO.
> >
> > > diff --git a/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> > > new file mode 100644
> > > index 0000000000000..e90f37bbdcd80
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/imx95-tqma9596la-mba95xxca.dts
> >
...
> >
> > > + pinctrl_ethphy0: ethphy0grp {
> > > + fsl,pins = <IMX95_PAD_PDM_BIT_STREAM0__AONMIX_TOP_GPIO1_IO_BIT9 0x1100>;
> > > + };
> >
> > [Severity: Low]
> > Is this pinctrl group missing a reference?
> >
> > It defines pin configuration for the ethphy0 IRQ pin, but doesn't seem to be
> > referenced by the ethphy0 node (e.g., via pinctrl-0) or any other node.
>
> This pad is connected to gpio1 which is under control of the system manager,
> so Cortex-A55 (Linux) has no access to it.
If not one refer it, it will never be set to GPIO at all.
Frank
>
> Best regards
> Alexander
> --
> TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
> Amtsgericht München, HRB 105018
> Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
> http://www.tq-group.com/
next prev parent reply other threads:[~2026-07-01 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-01 8:26 [PATCH v6 1/1] arm64: dts: add tqma9596la-mba95xxca Alexander Stein
2026-07-01 8:45 ` sashiko-bot
2026-07-01 8:50 ` Alexander Stein
2026-07-01 15:02 ` Frank Li [this message]
2026-07-01 15:37 ` Alexander Stein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akUsE6A6lX0mgM5g@SMW015318 \
--to=frank.li@oss.nxp.com \
--cc=Frank.Li@kernel.org \
--cc=alexander.stein@ew.tq-group.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox