Re: [PATCH 7/7] arm64: dts: qcom: Add Xiaomi Redmi 9T

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 8/10/26 6:55 PM, Adam Skladowski wrote:
> Add a devicetree for the Xiaomi Redmi 9T smartphone, which is based
> on the Bengal/SM6115 SoC.

[...]

> +	chosen {
> +		#address-cells = <2>;
> +		#size-cells = <2>;
> +		ranges;
> +		framebuffer0: framebuffer@5c000000 {

Please add a \n above


> +			compatible = "simple-framebuffer";
> +			reg = <0 0x5c000000 0 (2340 * 1080 * 4)>;
> +			width = <1080>;
> +			height = <2340>;
> +			stride = <(1080 * 4)>;
> +			format = "a8r8g8b8";
> +			clocks = <&gcc GCC_DISP_HF_AXI_CLK>;
> +		};
> +	};
> +
> +	backlight_dsi: backlight-dsi {
> +		compatible = "led-backlight";
> +		leds = <&led_backlight>;
> +		brightness-levels = <255>;
> +		default-brightness-level = <190>;
> +		/* Backlight controllers can differ between panel variants */

Should we at least enable it now to make the backlight level controllable?



> +		status = "disabled";
> +	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&vol_up_n>;

property-n
property-names

in this order please

[...]

> +&usb_dwc3 {
> +	maximum-speed = "high-speed";
> +	dr_mode = "peripheral";
> +	/delete-property/ usb-role-switch;
> +	phys = <&usb_hsphy>;
> +	phy-names = "usb2-phy";
> +	ports {
> +		/delete-node/ port@1;
> +	};

I think if you assign the supplies to the qmpphy none of this should be necessary

Konrad