Re: [PATCH 3/7] arm64: dts: qcom: Add Motorola One

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 8/10/26 6:55 PM, Adam Skladowski wrote:
> Add a devicetree for the Motorola One smartphone, which is based
> on the Jacala/MSM8953 SoC.

[...]

> +&i2c_1 {
> +	status = "disabled";
> +
> +	typec-portc@22 {
> +		compatible = "fcs,fusb302";
> +		reg = <0x22>;
> +		interrupts-extended = <&tlmm 9 IRQ_TYPE_EDGE_RISING>;
> +
> +		status = "disabled";

Why are the bus and this chip disabled?

[...]

> +&tlmm {
> +	gpio-reserved-ranges = <96 4>, <111 1>, <126 1>;

Preferably one a line with a best-effort set of comments describing
what these pins correspond to (see glymur-crd.dtsi)


> +
> +	disp_reset_n_active: disp-reset-n-active-state {
> +		pins = "gpio61";
> +		function = "gpio";
> +		drive-strength = <8>;
> +		bias-disable;
> +		output-high;

Drop output-foo from TLMM pins, the consumer driver should set the output
state via the GPIO APIs

Konrad