Re: [PATCH v5 3/7] dt-bindings: sound: qcom,q6dsp-lpass-ports: add Audio IF clocks

[Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>]

On 8/2/2026 7:00 PM, Srinivas Kandagatla wrote:
> On 8/1/26 6:46 AM, Prasad Kumpatla wrote:
>> Add the LPASS Audio IF clock IDs used by newer backend interfaces.
>>
>> Platforms using Audio IF module backends request the interface bit
>> clocks through q6prm. Add the Audio IF IBIT and EBIT IDs to the binding
>> header so these clocks can be referenced from device trees.
>>
>> Signed-off-by: Prasad Kumpatla <prasad.kumpatla@oss.qualcomm.com>
>> ---
>
>>   .../sound/qcom,q6dsp-lpass-ports.h            | 29 +++++++++++++++++++
>>   1 file changed, 29 insertions(+)
>>
>> diff --git a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> index 7b553a73bc92..fbcf1ef9ce22 100644
>> --- a/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> +++ b/include/dt-bindings/sound/qcom,q6dsp-lpass-ports.h
>> @@ -233,6 +233,35 @@
>>   /* Clock ID for RX CORE MCLK2 2X  MCLK */
>>   #define LPASS_CLK_ID_RX_CORE_MCLK2_2X_MCLK	70
>>   
>> +#define LPASS_CLK_ID_INTF0_IBIT		71
> Patch itself looks fine for me,
> But the naming seems to be bit odd and misleading,  what does INTF mean
> is it QAIF or some other Interface.
>
> Please prefix the interface name something like
> LPASS_CLK_ID_QAIF_IF0_EBIT or LPASS_CLK_ID_TDM_IF0_EBIT.. etc.
Hi Srini,

Thanks for the suggestion. This LPASS_CLK_ID_QAIF_IF0_EBIT
looks good and appropriately. I'll use it in the next revision.

Thanks,
Prasad

>
> --srini
>
>> +#define LPASS_CLK_ID_INTF0_EBIT		72
>> +#define LPASS_CLK_ID_INTF1_IBIT		73
>> +#define LPASS_CLK_ID_INTF1_EBIT		74
>> +#define LPASS_CLK_ID_INTF2_IBIT		75
>> +#define LPASS_CLK_ID_INTF2_EBIT		76
>> +#define LPASS_CLK_ID_INTF3_IBIT		77
>> +#define LPASS_CLK_ID_INTF3_EBIT		78
>> +#define LPASS_CLK_ID_INTF4_IBIT		79
>> +#define LPASS_CLK_ID_INTF4_EBIT		80
>> +#define LPASS_CLK_ID_INTF5_IBIT		81
>> +#define LPASS_CLK_ID_INTF5_EBIT		82
>> +#define LPASS_CLK_ID_INTF6_IBIT		83
>> +#define LPASS_CLK_ID_INTF6_EBIT		84
>> +#define LPASS_CLK_ID_INTF7_IBIT		85
>> +#define LPASS_CLK_ID_INTF7_EBIT		86
>> +#define LPASS_CLK_ID_INTF8_IBIT		87
>> +#define LPASS_CLK_ID_INTF8_EBIT		88
>> +#define LPASS_CLK_ID_INTF9_IBIT		89
>> +#define LPASS_CLK_ID_INTF9_EBIT		90
>> +#define LPASS_CLK_ID_INTF10_IBIT	91
>> +#define LPASS_CLK_ID_INTF10_EBIT	92
>> +#define LPASS_CLK_ID_INTF11_IBIT	93
>> +#define LPASS_CLK_ID_INTF11_EBIT	94
>> +#define LPASS_CLK_ID_INTF12_IBIT	95
>> +#define LPASS_CLK_ID_INTF12_EBIT	96
>> +#define LPASS_CLK_ID_VA_INTF0_IBIT	97
>> +#define LPASS_CLK_ID_VA_INTF0_EBIT	98
>> +
>>   #define LPASS_HW_AVTIMER_VOTE		101
>>   #define LPASS_HW_MACRO_VOTE		102
>>   #define LPASS_HW_DCODEC_VOTE		103