* [PATCH] of/irq: Make sure to update out_irq->np to the new parent
@ 2024-07-30 5:02 WHR
0 siblings, 0 replies; only message in thread
From: WHR @ 2024-07-30 5:02 UTC (permalink / raw)
To: Rob Herring, Saravana Kannan; +Cc: devicetree, linux-kernel
Commit 935df1bd40d43c4ee91838c42a20e9af751885cc has removed an
assignment statement for 'out_irq->np' right after label 'skiplevel',
causing the new parent acquired from function of_irq_find_parent didn't
being stored to 'out_irq->np' as it supposed to. Under some conditions
this can resuit in multiple corruptions and leakages to device nodes.
Update 'out_irq->np' before jumping to label 'skiplevel'.
Signed-off-by: WHR <whr@rivoreo.one>
---
drivers/of/irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index c94203ce65bb..580b33ce60d2 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -263,6 +263,7 @@ int of_irq_parse_raw(const __be32 *addr, struct
of_phandle_args *out_irq)
if (imap == NULL) {
pr_debug(" -> no map, getting parent\n");
newpar = of_irq_find_parent(ipar);
+ out_irq->np = newpar;
goto skiplevel;
}
imaplen /= sizeof(u32);
--
2.30.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2024-07-30 5:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-30 5:02 [PATCH] of/irq: Make sure to update out_irq->np to the new parent WHR
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox