Re: [PATCH v2 1/2] ARM: dts: omap4: panda: fix resources needed for Panda

[Roger Quadros <rogerq@kernel.org>]

On 30/03/2025 18:14, Andreas Kemnade wrote:
> The Pandaboard needs a 32k clock in the TWL6030 to be enabled
> to work. With some luck, it is enabled by some U-Boot fork.
> Do not rely on it and properly specify the requirement.

It would be nice to mention who exactly needs the 32K clock.
From your changes it looks like the wl12xx module needs it?

> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> index 97706d6296a6..c860b590142a 100644
> --- a/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> +++ b/arch/arm/boot/dts/ti/omap/omap4-panda-common.dtsi
> @@ -130,6 +130,12 @@ hsusb1_phy: hsusb1_phy {
>  		clock-frequency = <19200000>;
>  	};
>  
> +	wl12xx_pwrseq: wl12xx-pwrseq {
> +		compatible = "mmc-pwrseq-simple";
> +		clocks = <&twl 0>;
> +		clock-names = "ext_clock";
> +	};
> +
>  	/* regulator for wl12xx on sdio5 */
>  	wl12xx_vmmc: wl12xx_vmmc {
>  		pinctrl-names = "default";
> @@ -408,6 +414,7 @@ twl: twl@48 {
>  		reg = <0x48>;
>  		/* IRQ# = 7 */
>  		interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>; /* IRQ_SYS_1N cascaded to gic */
> +		#clock-cells = <1>;
>  		system-power-controller;
>  	};
>  
> @@ -488,6 +495,7 @@ &mmc5 {
>  	non-removable;
>  	bus-width = <4>;
>  	cap-power-off-card;
> +	mmc-pwrseq = <&wl12xx_pwrseq>;
>  
>  	#address-cells = <1>;
>  	#size-cells = <0>;

Reviewed-by: Roger Quadros <rogerq@kernel.org>

-- 
cheers,
-roger