Devicetree
 help / color / mirror / Atom feed
From: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Will Deacon <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Clark <robin.clark@oss.qualcomm.com>,
	linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/6] dt-bindings: iommu: arm,smmu: Document interconnects property
Date: Wed, 19 Aug 2026 18:21:18 +0530	[thread overview]
Message-ID: <7ce6df04-474b-4c68-a878-32f4df89a973@oss.qualcomm.com> (raw)
In-Reply-To: <haajolsmvil7adq4pfanmdrkvgqygwioncpikawhbvvar5kpnp@rese34d5wt5j>



On 8/18/2026 5:53 AM, Dmitry Baryshkov wrote:
> On Tue, Aug 11, 2026 at 08:39:41PM +0530, Bibek Kumar Patro wrote:
>>
>>
>> On 7/20/2026 8:10 PM, Dmitry Baryshkov wrote:
>>> On Mon, Jul 20, 2026 at 07:41:35PM +0530, Bibek Kumar Patro wrote:
>>>>
>>>>
>>>> On 7/8/2026 8:48 PM, Bjorn Andersson wrote:
>>>>> On Wed, Jul 08, 2026 at 08:22:00PM +0530, Bibek Kumar Patro wrote:
>>>>>>
>>>>>>
>>>>>> On 7/7/2026 10:12 PM, Dmitry Baryshkov wrote:
>>>>>>> On Tue, Jul 07, 2026 at 06:06:59PM +0530, Bibek Kumar Patro wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>> On 7/6/2026 11:09 PM, Dmitry Baryshkov wrote:

[...]

>>
>> As per the design it will be applicable to all targets with MMU-500,
>> (Even though issue hasn't been reported for all the targets on MMU-500,
>> e.g sm8650/sm8250 but the nodes will still be needed).
>> It's independent of adreno version i.e A6xx+/A5xx+.
> 
> Ack, this sounds reasonable and allows you to easility select if the fix
> is to be applied or not by using the generic compat strings.
> 

I'll share the updated implementation in next revision.

>>
>>    Adreno SMMU — upstream Qualcomm targets
>>
>>    SMMU-v2 (QSMMU)
>>    Platform   Compatible
>>    ---------  ------------------------------------
>>    MSM8996    qcom,msm8996-smmu-v2, qcom,adreno-smmu
>>    SDM670     qcom,sdm670-smmu-v2, qcom,adreno-smmu
>>    SDM845     qcom,sdm845-smmu-v2, qcom,adreno-smmu
>>    SC7180     qcom,sc7180-smmu-v2, qcom,adreno-smmu
>>    SM6350     qcom,sm6350-smmu-v2, qcom,adreno-smmu
>>    SM7150     qcom,sm7150-smmu-v2, qcom,adreno-smmu
>>    SM6375     qcom,sm6375-smmu-v2  (apps only, no adreno-smmu node)
> 
> 	adreno_smmu: iommu@5940000 {
> 		compatible = "qcom,sm6375-smmu-v2", "qcom,smmu-v2";
> 
> 
>>    MSM8998    qcom,msm8998-smmu-v2 (apps only, no adreno-smmu node)
> 
> 	adreno_smmu: iommu@5040000 {
> 		compatible = "qcom,msm8998-smmu-v2", "qcom,smmu-v2";
> 
> 

I see, these targets are not using the fallback 'qcom,adreno-smmu'
compatible for gfx smmu node.


>>    SDM630     qcom,sdm630-smmu-v2  (adreno binding to be fixed)
> 
> What exactly needs to be fixed?
> 
> 	kgsl_smmu: iommu@5040000 {
> 		compatible = "qcom,sdm630-smmu-v2", "qcom,adreno-smmu",
> 			     "qcom,smmu-v2";
> 

Binding seems to be correct for sdm630 as I rechecked. Missed it the
first time.
This combination is already defined under
'  - description: Qcom Adreno GPUs implementing "arm,smmu-v2" '
So no fix needed here.

> 
>>
>>    SMMU-500 (MMU-500) — with qcom,adreno-smmu
>>    Platform   Compatible
>>    ---------  ------------------------------------
>>    SM6115     qcom,sm6115-smmu-500, qcom,adreno-smmu
>>    QCM2290    qcom,qcm2290-smmu-500, qcom,adreno-smmu
>>    SM8150     qcom,sm8150-smmu-500, qcom,adreno-smmu
>>    SM8250     qcom,sm8250-smmu-500, qcom,adreno-smmu
>>    SC8180x    qcom,sc8180x-smmu-500, qcom,adreno-smmu
>>    SM8350     qcom,sm8350-smmu-500, qcom,adreno-smmu
>>    SC7280     qcom,sc7280-smmu-500, qcom,adreno-smmu  ← our patch series
>>    SM8450     qcom,sm8450-smmu-500, qcom,adreno-smmu
>>    SC8280xp   qcom,sc8280xp-smmu-500, qcom,adreno-smmu
>>    QCS615     qcom,qcs615-smmu-500, qcom,adreno-smmu  ← our patch series
>>    SM8550     qcom,sm8550-smmu-500, qcom,adreno-smmu
>>    SA8775P    qcom,sa8775p-smmu-500, qcom,adreno-smmu  ← our patch series
>>    SM8650     qcom,sm8650-smmu-500, qcom,adreno-smmu
>>    QCS8300    qcom,qcs8300-smmu-500, qcom,adreno-smmu  ← our patch series
>>    SAR2130P   qcom,sar2130p-smmu-500, qcom,adreno-smmu
>>    X1E80100   qcom,x1e80100-smmu-500, qcom,adreno-smmu
>>    Glymur     qcom,glymur-smmu-500, qcom,adreno-smmu
>>    Milos      qcom,milos-smmu-500, qcom,adreno-smmu
>>
>>    SMMU-500 — without qcom,adreno-smmu (apps SMMU only)
>>    SDM670     qcom,sdm670-smmu-500  (apps)
>>    SDM845     qcom,sdm845-smmu-500  (apps)
>>    SC7180     qcom,sc7180-smmu-500  (apps)
>>    SM6350     qcom,sm6350-smmu-500  (apps)
> 
> All these platforms use a separate v2 QSMMU for Adreno
> 

Yes, on these platforms, apps SMMU / system TCU is MMU-500,
while adreno/GFX TCU is smmu-v2 variant.

>>    SM8450     qcom,sm8450-smmu-500  (apps)
> 
> 	adreno_smmu: iommu@3da0000 {
> 		compatible = "qcom,sm8450-smmu-500", "qcom,adreno-smmu",
> 			     "qcom,smmu-500", "arm,mmu-500";
> 
> 
>>    SC8280xp   qcom,sc8280xp-smmu-500 (apps)
> 
> 	gpu_smmu: iommu@3da0000 {
> 		compatible = "qcom,sc8280xp-smmu-500", "qcom,adreno-smmu",
> 			     "qcom,smmu-500", "arm,mmu-500";
> 

Ah, thanks for catching this 2 platforms. It would come in
'SMMU-500 (MMU-500) — with qcom,adreno-smmu' table.

>>    SM8750     qcom,sm8750-smmu-500  (adreno-smmu not available yet)
> 
> Yes, patches pending, I think.

Yes, those would be part of drm/msm support series for sm8750.

Thanks & regards,
Bibek>


  reply	other threads:[~2026-08-19 12:51 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-06 16:56 [PATCH v3 0/6] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 1/6] dt-bindings: iommu: arm,smmu: Document interconnects property Bibek Kumar Patro
2026-07-06 17:39   ` Dmitry Baryshkov
2026-07-07 12:36     ` Bibek Kumar Patro
2026-07-07 16:42       ` Dmitry Baryshkov
2026-07-08 14:52         ` Bibek Kumar Patro
2026-07-08 15:18           ` Bjorn Andersson
2026-07-20 14:11             ` Bibek Kumar Patro
2026-07-20 14:40               ` Dmitry Baryshkov
2026-08-11 15:09                 ` Bibek Kumar Patro
2026-08-18  0:23                   ` Dmitry Baryshkov
2026-08-19 12:51                     ` Bibek Kumar Patro [this message]
2026-07-06 16:56 ` [PATCH v3 2/6] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-07-06 17:09   ` sashiko-bot
2026-07-06 17:40   ` Dmitry Baryshkov
2026-07-07 12:43     ` Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU Bibek Kumar Patro
2026-07-06 17:42   ` Dmitry Baryshkov
2026-07-07 13:07     ` Bibek Kumar Patro
2026-07-07 16:44       ` Dmitry Baryshkov
2026-07-08 10:01         ` Bibek Kumar Patro
2026-07-08 15:26           ` Bjorn Andersson
2026-07-17 11:40             ` Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 4/6] arm64: dts: qcom: lemans: " Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 5/6] arm64: dts: qcom: monaco: " Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 6/6] arm64: dts: qcom: talos: " Bibek Kumar Patro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ce6df04-474b-4c68-a878-32f4df89a973@oss.qualcomm.com \
    --to=bibek.patro@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.clark@oss.qualcomm.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox