From: Bjorn Andersson <andersson@kernel.org>
To: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Joerg Roedel <joro@8bytes.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Subject: Re: [PATCH v3 1/6] dt-bindings: iommu: arm,smmu: Document interconnects property
Date: Wed, 8 Jul 2026 10:18:13 -0500 [thread overview]
Message-ID: <ak5pC_meP8KRc3wJ@baldur> (raw)
In-Reply-To: <4e266d45-ee88-42f8-91da-6253927686ae@oss.qualcomm.com>
On Wed, Jul 08, 2026 at 08:22:00PM +0530, Bibek Kumar Patro wrote:
>
>
> On 7/7/2026 10:12 PM, Dmitry Baryshkov wrote:
> > On Tue, Jul 07, 2026 at 06:06:59PM +0530, Bibek Kumar Patro wrote:
> > >
> > >
> > > On 7/6/2026 11:09 PM, Dmitry Baryshkov wrote:
> > > > On Mon, Jul 06, 2026 at 10:26:34PM +0530, Bibek Kumar Patro wrote:
> > > > > Some SoC implementations require a bandwidth vote on an interconnect
> > > > > path before the SMMU register space is accessible. Add the optional
> > > >
> > > > Why is it limited only to those SoCs? Is it also applicable to other
> > > > Qualcomm SoCs?
> > > >
> > >
> > > I was hoping to keep this series focused on the core infrastructure
> > > changes: the bindings, base ICC bandwidth-voting support, and DT
> > > interconnect properties for the platforms currently supported on
> > > Qualcomm Linux and have been validated so far.
> > >
> > > The additional targets have not been tested yet, so I'd prefer
> > > to add their support in a separate follow-up series once validation
> > > is complete, rather than growing this series further. WDYT?
> >
> > Then it should be a part of the commit message. All SoCs since SDM12345
> > need to vote on the interconnect (and then, in the cover letter mention
> > that you convert only a few of the SoCs). We possibly can help with
> > testing on other platforms.
> >
>
> Ack, sounds reasonable.
> I'll add the first platform onwards which interconnect voting is required in
> commit description.
But to what degree is this related to a specific set of platforms? If we
look ahead, aren't we expecting the list to grow to include all
platforms in the end - resulting in a lot of noise and churn.
Can you give an example of a platform where there is no interconnect
path to vote for here or where it would be harmful to do so?
> And update the cover letter to clarify that this series adds
> support for the Qualcomm Linux-supported targets available today, and
> the list will be expanded in follow-up series as additional platforms
> are enabled.
>
The binding should not reflect what has been implemented and verified in
Linux, it defines the contract between DeviceTree and the OS.
Regards,
Bjorn
> Thanks & regards,
> Bibek
>
> > > > > 'interconnects' property to the binding to allow platform DT nodes
> > > > > to describe this path.
> > > > >
> > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> > > > > Signed-off-by: Bibek Kumar Patro <bibek.patro@oss.qualcomm.com>
> > > > > ---
> > > > > .../devicetree/bindings/iommu/arm,smmu.yaml | 27 ++++++++++++++++++++++
> > > > > 1 file changed, 27 insertions(+)
> > > > >
> >
>
next prev parent reply other threads:[~2026-07-08 15:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-06 16:56 [PATCH v3 0/6] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 1/6] dt-bindings: iommu: arm,smmu: Document interconnects property Bibek Kumar Patro
2026-07-06 17:39 ` Dmitry Baryshkov
2026-07-07 12:36 ` Bibek Kumar Patro
2026-07-07 16:42 ` Dmitry Baryshkov
2026-07-08 14:52 ` Bibek Kumar Patro
2026-07-08 15:18 ` Bjorn Andersson [this message]
2026-07-06 16:56 ` [PATCH v3 2/6] iommu/arm-smmu: Add interconnect bandwidth voting support Bibek Kumar Patro
2026-07-06 17:09 ` sashiko-bot
2026-07-06 17:40 ` Dmitry Baryshkov
2026-07-07 12:43 ` Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 3/6] arm64: dts: qcom: kodiak: Add GEM_NOC interconnect for adreno SMMU Bibek Kumar Patro
2026-07-06 17:42 ` Dmitry Baryshkov
2026-07-07 13:07 ` Bibek Kumar Patro
2026-07-07 16:44 ` Dmitry Baryshkov
2026-07-08 10:01 ` Bibek Kumar Patro
2026-07-08 15:26 ` Bjorn Andersson
2026-07-06 16:56 ` [PATCH v3 4/6] arm64: dts: qcom: lemans: " Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 5/6] arm64: dts: qcom: monaco: " Bibek Kumar Patro
2026-07-06 16:56 ` [PATCH v3 6/6] arm64: dts: qcom: talos: " Bibek Kumar Patro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ak5pC_meP8KRc3wJ@baldur \
--to=andersson@kernel.org \
--cc=bibek.patro@oss.qualcomm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox