Re: [PATCH v1 2/2] arm64: dts: qcom: sa8775p: Add support for camss

[Vikram Sharma <quic_vikramsa@quicinc.com>]

On 4/14/2025 7:18 PM, Konrad Dybcio wrote:
> On 2/10/25 4:56 PM, Vikram Sharma wrote:
>> Add changes to support the camera subsystem on the SA8775P.
>>
>> Co-developed-by: Suresh Vankadara <quic_svankada@quicinc.com>
>> Signed-off-by: Suresh Vankadara <quic_svankada@quicinc.com>
>> Signed-off-by: Vikram Sharma <quic_vikramsa@quicinc.com>
>> ---
> [...]
>
>> +			interrupts = <GIC_SPI 565 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 564 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 468 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 359 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 759 IRQ_TYPE_EDGE_RISING>,
> 760> +				     <GIC_SPI 758 IRQ_TYPE_EDGE_RISING>,

Hi Konrad,

We cross checked internal documents to confirm IRQ number for 
csid_lite2/3 and vfe_lite2/3
Calculation for IRQ number is done with respect to vector number as
irq_num = (vector - 32).
csid_lite2 vector -> 791
csid_lite3 vector -> 790
vfe_lite2  vector -> 793
vfe_lite3  vector -> 792

thus irqs are as
csid_lite2 -> 759
csid_lite3 -> 758
vfe_lite2  -> 761
vfe_lite3  -> 760

Please let me know if this looks fine to you?

>
> 759
>
>> +				     <GIC_SPI 604 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 477 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 478 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 479 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 448 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 545 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 546 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 547 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 465 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 467 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 469 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 360 IRQ_TYPE_EDGE_RISING>,
>> +				     <GIC_SPI 761 IRQ_TYPE_EDGE_RISING>,
> 762
>
>> +				     <GIC_SPI 760 IRQ_TYPE_EDGE_RISING>,
> 761
>
> Konrad

Best Regards,

Vikram