[PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[David Heidelberg via B4 Relay]

From: David Heidelberg <david@ixit.cz>

Add SoC ID for Qualcomm Snapdragon SDA850.

Signed-off-by: David Heidelberg <david@ixit.cz>
---
Will be used by Comma three.
---
 include/dt-bindings/arm/qcom,ids.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 1af73c0ad41cd..4b3062f57eecd 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -179,16 +179,17 @@
 #define QCOM_ID_SDM450			338
 #define QCOM_ID_SM8150			339
 #define QCOM_ID_SDA845			341
 #define QCOM_ID_IPQ8072			342
 #define QCOM_ID_IPQ8076			343
 #define QCOM_ID_IPQ8078			344
 #define QCOM_ID_SDM636			345
 #define QCOM_ID_SDA636			346
+#define QCOM_ID_SDA850			348
 #define QCOM_ID_SDM632			349
 #define QCOM_ID_SDA632			350
 #define QCOM_ID_SDA450			351
 #define QCOM_ID_SDM439			353
 #define QCOM_ID_SDM429			354
 #define QCOM_ID_SM8250			356
 #define QCOM_ID_SA8155			362
 #define QCOM_ID_SDA439			363

---
base-commit: 948efecf22e49aa4bf55bb73ec79a0ddcfd38571
change-id: 20260623-sda850-6b5c1e44662c

Best regards,
-- 
David Heidelberg <david@ixit.cz>

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing SoC ID mapping in the qcom-socinfo driver causes incorrect sysfs machine attribute.
--

commit 40f8c20a8f811ef4d99535abc1be00a3d96ed7b4
Author: David Heidelberg <david@ixit.cz>

dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

This commit adds the numerical SoC ID (348) for the Qualcomm Snapdragon
SDA850 to the device tree bindings header.

> diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
> index 1af73c0ad41cd..4b3062f57eecd 100644
> --- a/include/dt-bindings/arm/qcom,ids.h
> +++ b/include/dt-bindings/arm/qcom,ids.h
> @@ -184,6 +184,7 @@
>  #define QCOM_ID_IPQ8078			344
>  #define QCOM_ID_SDM636			345
>  #define QCOM_ID_SDA636			346
> +#define QCOM_ID_SDA850			348

[Severity: Medium]
Should this ID also be added to the soc_id[] array in
drivers/soc/qcom/socinfo.c?

Without adding qcom_board_id(SDA850) to the array, socinfo_machine()
will return NULL when the qcom-socinfo driver probes a Snapdragon SDA850
device, because it fails to map the SMEM build ID (348) to a string.

As a result, soc_device_register() will fall back to using
of_machine_read_model(), which exposes the device tree's board model
string in the /sys/devices/soc0/machine sysfs attribute rather than
the expected SoC name.

Does this regression break user-space tools that rely on the
Qualcomm-specific ABI expectation for the machine attribute?

>  #define QCOM_ID_SDM632			349
>  #define QCOM_ID_SDA632			350
>  #define QCOM_ID_SDA450			351

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260623-sda850-v1-1-ddd8e62c85d8@ixit.cz?part=1

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Krzysztof Kozlowski]

On 23/06/2026 20:41, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Add SoC ID for Qualcomm Snapdragon SDA850.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> Will be used by Comma three.

Can you provide a link?

In general this must be send with the user.


Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Mukesh Ojha]

On Tue, Jun 23, 2026 at 08:41:34PM +0200, David Heidelberg via B4 Relay wrote:
> From: David Heidelberg <david@ixit.cz>
> 
> Add SoC ID for Qualcomm Snapdragon SDA850.
> 
> Signed-off-by: David Heidelberg <david@ixit.cz>

Reviewed-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>

-- 
-Mukesh Ojha

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Konrad Dybcio]

On 6/24/26 8:26 AM, Krzysztof Kozlowski wrote:
> On 23/06/2026 20:41, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Add SoC ID for Qualcomm Snapdragon SDA850.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> Will be used by Comma three.
> 
> Can you provide a link?

Previous gen of https://comma.ai/shop/comma-four, they don't seem
to have the old one listed on their website anymore

The other computer tells me SDA850 doesn't exist and 348 is SDM850
(for which we have a number of DTs in the kernel today), so let's
rename it and add a second patch to add it to socinfo

Konrad

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Krzysztof Kozlowski]

On 24/06/2026 09:35, Konrad Dybcio wrote:
> On 6/24/26 8:26 AM, Krzysztof Kozlowski wrote:
>> On 23/06/2026 20:41, David Heidelberg via B4 Relay wrote:
>>> From: David Heidelberg <david@ixit.cz>
>>>
>>> Add SoC ID for Qualcomm Snapdragon SDA850.
>>>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>> Will be used by Comma three.
>>
>> Can you provide a link?
> 
> Previous gen of https://comma.ai/shop/comma-four, they don't seem
> to have the old one listed on their website anymore

I meant, link to the upstream user. Something which will convince why do
we want this patch.

> 
> The other computer tells me SDA850 doesn't exist and 348 is SDM850
> (for which we have a number of DTs in the kernel today), so let's
> rename it and add a second patch to add it to socinfo



Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[David Heidelberg]

best I do is close-to-mainline tree,

https://github.com/commaai/vamOS/tree/master/kernel/dts

David

On 24/06/2026 08:26, Krzysztof Kozlowski wrote:
> On 23/06/2026 20:41, David Heidelberg via B4 Relay wrote:
>> From: David Heidelberg <david@ixit.cz>
>>
>> Add SoC ID for Qualcomm Snapdragon SDA850.
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> Will be used by Comma three.
> 
> Can you provide a link?
> 
> In general this must be send with the user.
> 
> 
> Best regards,
> Krzysztof

-- 
David Heidelberg

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Krzysztof Kozlowski]

On 24/06/2026 13:37, David Heidelberg wrote:
> best I do is close-to-mainline tree,
> 
> https://github.com/commaai/vamOS/tree/master/kernel/dts


That's not upstream, so we do not need this patch upstream... Just keep
it out of tree.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Konrad Dybcio]

On 6/24/26 1:50 PM, Krzysztof Kozlowski wrote:
> On 24/06/2026 13:37, David Heidelberg wrote:
>> best I do is close-to-mainline tree,
>>
>> https://github.com/commaai/vamOS/tree/master/kernel/dts
> 
> 
> That's not upstream, so we do not need this patch upstream... Just keep
> it out of tree.

As I mentioned, the proposed ID has upstream users e.g.
sdm850-lenovo-yoga-c630.dts

Konrad

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Krzysztof Kozlowski]

On 24/06/2026 13:53, Konrad Dybcio wrote:
> On 6/24/26 1:50 PM, Krzysztof Kozlowski wrote:
>> On 24/06/2026 13:37, David Heidelberg wrote:
>>> best I do is close-to-mainline tree,
>>>
>>> https://github.com/commaai/vamOS/tree/master/kernel/dts
>>
>>
>> That's not upstream, so we do not need this patch upstream... Just keep
>> it out of tree.
> 
> As I mentioned, the proposed ID has upstream users e.g.
> sdm850-lenovo-yoga-c630.dts

There is no use of this in that DTS, so my comment is valid: please post
it with users.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: arm: qcom,ids: Add SoC ID for Snapdragon SDA 850

[Konrad Dybcio]

On 6/24/26 1:57 PM, Krzysztof Kozlowski wrote:
> On 24/06/2026 13:53, Konrad Dybcio wrote:
>> On 6/24/26 1:50 PM, Krzysztof Kozlowski wrote:
>>> On 24/06/2026 13:37, David Heidelberg wrote:
>>>> best I do is close-to-mainline tree,
>>>>
>>>> https://github.com/commaai/vamOS/tree/master/kernel/dts
>>>
>>>
>>> That's not upstream, so we do not need this patch upstream... Just keep
>>> it out of tree.
>>
>> As I mentioned, the proposed ID has upstream users e.g.
>> sdm850-lenovo-yoga-c630.dts
> 
> There is no use of this in that DTS, so my comment is valid: please post
> it with users.

aaaah, I get it.. David, please add the socinfo entry

Konrad