* [PATCH v2] ASoC: dt-bindings: sound: asahi-kasei,ak4118: Convert DT schema
@ 2026-05-24 15:02 Manish Baing
2026-05-30 9:19 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Manish Baing @ 2026-05-24 15:02 UTC (permalink / raw)
To: lgirdwood, broonie, robh, krzk+dt, conor+dt, peron.clem
Cc: linux-sound, devicetree, linux-kernel, manishbaing2789
Convert the Asahi Kasei AK4118 S/PDIF transceiver bindings from
text format to YAML schema.
Signed-off-by: Manish Baing <manishbaing2789@gmail.com>
---
Changes in v2:
- Restored legacy 'irq-gpios' property to prevent C driver probe failure.
- Added 'reset-gpios' and 'irq-gpios' to the required properties list.
.../devicetree/bindings/sound/ak4118.txt | 22 -------
.../bindings/sound/asahi-kasei,ak4118.yaml | 58 +++++++++++++++++++
2 files changed, 58 insertions(+), 22 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt
create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
diff --git a/Documentation/devicetree/bindings/sound/ak4118.txt b/Documentation/devicetree/bindings/sound/ak4118.txt
deleted file mode 100644
index 6e11a2f7404c..000000000000
--- a/Documentation/devicetree/bindings/sound/ak4118.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-AK4118 S/PDIF transceiver
-
-This device supports I2C mode.
-
-Required properties:
-
-- compatible : "asahi-kasei,ak4118"
-- reg : The I2C address of the device for I2C
-- reset-gpios: A GPIO specifier for the reset pin
-- irq-gpios: A GPIO specifier for the IRQ pin
-
-Example:
-
-&i2c {
- ak4118: ak4118@13 {
- #sound-dai-cells = <0>;
- compatible = "asahi-kasei,ak4118";
- reg = <0x13>;
- reset-gpios = <&gpio 0 GPIO_ACTIVE_LOW>
- irq-gpios = <&gpio 1 GPIO_ACTIVE_HIGH>;
- };
-};
diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
new file mode 100644
index 000000000000..c8aa61643ca0
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
@@ -0,0 +1,58 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4118.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Asahi Kasei AK4118 Digital Audio Transceiver
+
+maintainers:
+ - Clément Péron <peron.clem@gmail.com>
+
+allOf:
+ - $ref: dai-common.yaml#
+
+properties:
+ compatible:
+ const: asahi-kasei,ak4118
+
+ reg:
+ maxItems: 1
+ description: I2C address of the device
+
+ "#sound-dai-cells":
+ const: 0
+
+ irq-gpios:
+ maxItems: 1
+ description: GPIO used for IRQ pin
+
+ reset-gpios:
+ maxItems: 1
+ description: GPIO used for the Reset pin
+
+required:
+ - compatible
+ - reg
+ - "#sound-dai-cells"
+ - irq-gpios
+ - reset-gpios
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ audio-codec@13 {
+ compatible = "asahi-kasei,ak4118";
+ reg = <0x13>;
+ #sound-dai-cells = <0>;
+ reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>;
+ irq-gpios = <&gpio1 1 GPIO_ACTIVE_HIGH>;
+ };
+ };
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH v2] ASoC: dt-bindings: sound: asahi-kasei,ak4118: Convert DT schema
2026-05-24 15:02 [PATCH v2] ASoC: dt-bindings: sound: asahi-kasei,ak4118: Convert DT schema Manish Baing
@ 2026-05-30 9:19 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2026-05-30 9:19 UTC (permalink / raw)
To: Manish Baing, lgirdwood, broonie, robh, krzk+dt, conor+dt,
peron.clem
Cc: linux-sound, devicetree, linux-kernel
On 24/05/2026 17:02, Manish Baing wrote:
> Convert the Asahi Kasei AK4118 S/PDIF transceiver bindings from
> text format to YAML schema.
>
> Signed-off-by: Manish Baing <manishbaing2789@gmail.com>
> ---
> Changes in v2:
> - Restored legacy 'irq-gpios' property to prevent C driver probe failure.
> - Added 'reset-gpios' and 'irq-gpios' to the required properties list.
>
> .../devicetree/bindings/sound/ak4118.txt | 22 -------
> .../bindings/sound/asahi-kasei,ak4118.yaml | 58 +++++++++++++++++++
> 2 files changed, 58 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/sound/ak4118.txt
> create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4118.yaml
Organize your patches targeting one subsystem into one patchset. You
sent a lot and you make EXACTLY the same mistakes everywhere. So now I
need to replay to 10 different emails?
Well, you don't even give time to review, but immediately send v2.
Please slow down and put attention to this work.
I expect answers:
1. Did you analyze existing users of this binding?
2. If so, which users? How did you analyze them?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-05-30 9:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-24 15:02 [PATCH v2] ASoC: dt-bindings: sound: asahi-kasei,ak4118: Convert DT schema Manish Baing
2026-05-30 9:19 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox