Re: [PATCH v2 3/4] iio: light: ltr501: Add ltr329 driver support

[Esben Haabendal <esben@geanix.com>]

"Joshua Crofts" <joshua.crofts1@gmail.com> writes:

> On Wed, 15 Jul 2026 14:27:25 +0200
> Esben Haabendal <esben@geanix.com> wrote:
>
>> This adds support for the LTR-329ALS-01 chip, which is similar to
>> LTR-303ALS-01, except for interrupt, which LTR-329ALS-01 chip does not
>> have.
>>
>> Signed-off-by: Esben Haabendal <esben@geanix.com>
>> ---
>>  drivers/iio/light/ltr501.c | 33 +++++++++++++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>
>> diff --git a/drivers/iio/light/ltr501.c b/drivers/iio/light/ltr501.c
>> index 7d045be78c6d..379e57ac5f5b 100644
>> --- a/drivers/iio/light/ltr501.c
>> +++ b/drivers/iio/light/ltr501.c
>> @@ -15,6 +15,7 @@
>>  #include <linux/delay.h>
>>  #include <linux/regmap.h>
>>  #include <linux/regulator/consumer.h>
>> +#include <linux/array_size.h> // for ARRAY_SIZE
>
> Just a small nit, even though the list isn't exactly ordered, please
> try to add the new include approximately where it would be if ordered,
> i.e. array_size.h goes to the top. Additionally, you don't need to add
> a comment.

So alphabetically sorted? And even before linux/module.h?

Comment is going away...

> Everything else seems fine otherwise.

/Esben