Devicetree
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: helios4: fix vbus-supply for USB2 PHY
@ 2026-08-29  2:11 Rosen Penev
  2026-08-31  9:59 ` Gregory CLEMENT
  0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-08-29  2:11 UTC (permalink / raw)
  To: devicetree
  Cc: Andrew Lunn, Gregory Clement, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Dennis Gilmore,
	moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
	open list

The usb-nop-xceiv binding and driver use "vbus-supply"; the driver
acquires the VBUS regulator via devm_regulator_get_exclusive("vbus")
(phy-generic.c). The stale "vbus-regulator" name is never read by
the driver and dtbs_check rejects it as an unknown property. Rename
the property so reg_5p0v_usb is honored.

Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
Assisted-by: opencode:big-pickle
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
 arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
index b8576ca0de1c..9de9a8a4267c 100644
--- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
+++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
@@ -140,7 +140,7 @@ fan2: j17-pwm {
 
 	usb2_phy: usb2-phy {
 		compatible = "usb-nop-xceiv";
-		vbus-regulator = <&reg_5p0v_usb>;
+		vbus-supply = <&reg_5p0v_usb>;
 	};
 
 	usb3_phy: usb3-phy {
-- 
2.55.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: dts: helios4: fix vbus-supply for USB2 PHY
  2026-08-29  2:11 [PATCH] ARM: dts: helios4: fix vbus-supply for USB2 PHY Rosen Penev
@ 2026-08-31  9:59 ` Gregory CLEMENT
  0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2026-08-31  9:59 UTC (permalink / raw)
  To: Rosen Penev, devicetree
  Cc: Andrew Lunn, Sebastian Hesselbarth, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Dennis Gilmore,
	moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...,
	open list

Rosen Penev <rosenp@gmail.com> writes:

> The usb-nop-xceiv binding and driver use "vbus-supply"; the driver
> acquires the VBUS regulator via devm_regulator_get_exclusive("vbus")
> (phy-generic.c). The stale "vbus-regulator" name is never read by
> the driver and dtbs_check rejects it as an unknown property. Rename
> the property so reg_5p0v_usb is honored.
>
> Fixes: ced8025b569e ("ARM: dts: armada388-helios4")
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>

Applied on mvebu/dt

Thanks,

Gregory
> ---
>  arch/arm/boot/dts/marvell/armada-388-helios4.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/marvell/armada-388-helios4.dts b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> index b8576ca0de1c..9de9a8a4267c 100644
> --- a/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> +++ b/arch/arm/boot/dts/marvell/armada-388-helios4.dts
> @@ -140,7 +140,7 @@ fan2: j17-pwm {
>  
>  	usb2_phy: usb2-phy {
>  		compatible = "usb-nop-xceiv";
> -		vbus-regulator = <&reg_5p0v_usb>;
> +		vbus-supply = <&reg_5p0v_usb>;
>  	};
>  
>  	usb3_phy: usb3-phy {
> -- 
> 2.55.0
>

-- 
Grégory CLEMENT, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-31  9:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-29  2:11 [PATCH] ARM: dts: helios4: fix vbus-supply for USB2 PHY Rosen Penev
2026-08-31  9:59 ` Gregory CLEMENT

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox