Re: [PATCH v6 2/3] drm/st7571-i2c: add support for Sitronix ST7571 LCD controller

[Javier Martinez Canillas <javierm@redhat.com>]

Marcus Folkesson <marcus.folkesson@gmail.com> writes:

Hello Marcus,

> Sitronix ST7571 is a 4bit gray scale dot matrix LCD controller.
> The controller has a SPI, I2C and 8bit parallel interface, this
> driver is for the I2C interface only.
>
> Reviewed-by: Thomas Zimmermann <tzimmrmann@suse.de>
> Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com>
> ---

[...]

> +
> +static void st7571_reset(struct st7571_device *st7571)
> +{
> +	gpiod_set_value_cansleep(st7571->reset, 1);
> +	fdelay(20);

There's no fdelay() and this leads to a build failure now:

make -j16 M=drivers/gpu/drm/tiny/
...
  CC [M]  st7571-i2c.o
st7571-i2c.c: In function ‘st7571_reset’:
st7571-i2c.c:815:9: error: implicit declaration of function ‘fdelay’; did you mean ‘ndelay’? [-Wimplicit-function-declaration]
  815 |         fdelay(20);
      |         ^~~~~~
      |         ndelay


but I think you meant fsleep() here (which makes sense to me), so I will apply
the following fixup to this patch before pushing it:

diff --git a/drivers/gpu/drm/tiny/st7571-i2c.c b/drivers/gpu/drm/tiny/st7571-i2c.c
index ba089a7e2b61..dc410ec41baf 100644
--- a/drivers/gpu/drm/tiny/st7571-i2c.c
+++ b/drivers/gpu/drm/tiny/st7571-i2c.c
@@ -812,7 +812,7 @@ static int st7571_parse_dt(struct st7571_device *st7571)
 static void st7571_reset(struct st7571_device *st7571)
 {
        gpiod_set_value_cansleep(st7571->reset, 1);
-       fdelay(20);
+       fsleep(20);
        gpiod_set_value_cansleep(st7571->reset, 0);
 }

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat