Devicetree
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: vkoul@kernel.org, Dan Williams <dan.j.williams@intel.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Kieran Bingham <kieran@ksquared.org.uk>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dmaengine@vger.kernel.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt
Date: Fri, 15 Jun 2018 07:15:35 +0000	[thread overview]
Message-ID: <87y3fgbk34.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <CAMuHMdU_csJSYQ==Z+MOMGMi1LJ07_ZOojYADyUwaDcFLTT9dA@mail.gmail.com>


Hi Geert

> > rcar-dmac has 2 types of interrupt, 1) error IRQ (for all),
> > 2) IRQ for each channels.
> > If error happens on some channels, the error IRQ will be handled
> > by 1), and "all" channels will be restarted.
> > But in this design, error handling itself will be problem for
> > non error channel users.
> > This patch removes 1) handler, and handles error IRQ on 2)
> 
> Thank you, that explains the rationale!

Thanks

> BTW, how can you trigger an error, for testing?

We created local patch to break address alignment.

Best regards
---
Kuninori Morimoto

  reply	other threads:[~2018-06-15  7:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-15  0:53 [PATCH v3] dmaengine: rcar-dmac: don't use DMAC error interrupt Kuninori Morimoto
2018-06-15  6:20 ` Geert Uytterhoeven
2018-06-15  7:15   ` Kuninori Morimoto [this message]
2018-06-28  4:21 ` Vinod

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y3fgbk34.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=dan.j.williams@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=kieran@ksquared.org.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox