* [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains
@ 2022-11-16 15:49 Krzysztof Kozlowski
2022-11-16 15:58 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-16 15:49 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Use defines for RPMh power domains instead of hard-coding numbers.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8150.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index d1b64280ab0b..136fa5360e8e 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -2074,8 +2074,8 @@ remoteproc_slpi: remoteproc@2400000 {
clocks = <&rpmhcc RPMH_CXO_CLK>;
clock-names = "xo";
- power-domains = <&rpmhpd 3>,
- <&rpmhpd 2>;
+ power-domains = <&rpmhpd SM8150_LCX>,
+ <&rpmhpd SM8150_LMX>;
power-domain-names = "lcx", "lmx";
memory-region = <&slpi_mem>;
@@ -2619,8 +2619,8 @@ remoteproc_mpss: remoteproc@4080000 {
clocks = <&rpmhcc RPMH_CXO_CLK>;
clock-names = "xo";
- power-domains = <&rpmhpd 7>,
- <&rpmhpd 0>;
+ power-domains = <&rpmhpd SM8150_CX>,
+ <&rpmhpd SM8150_MSS>;
power-domain-names = "cx", "mss";
memory-region = <&mpss_mem>;
@@ -3246,7 +3246,7 @@ remoteproc_cdsp: remoteproc@8300000 {
clocks = <&rpmhcc RPMH_CXO_CLK>;
clock-names = "xo";
- power-domains = <&rpmhpd 7>;
+ power-domains = <&rpmhpd SM8150_CX>;
memory-region = <&cdsp_mem>;
@@ -3747,7 +3747,7 @@ remoteproc_adsp: remoteproc@17300000 {
clocks = <&rpmhcc RPMH_CXO_CLK>;
clock-names = "xo";
- power-domains = <&rpmhpd 7>;
+ power-domains = <&rpmhpd SM8150_CX>;
memory-region = <&adsp_mem>;
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains
2022-11-16 15:49 [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains Krzysztof Kozlowski
@ 2022-11-16 15:58 ` Konrad Dybcio
2022-11-16 16:30 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2022-11-16 15:58 UTC (permalink / raw)
To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
On 16/11/2022 16:49, Krzysztof Kozlowski wrote:
> Use defines for RPMh power domains instead of hard-coding numbers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
I sent exactly the same patch yesterday.
https://lore.kernel.org/linux-arm-msm/ef2057cb-8de8-4d65-2749-cfc205833eb4@linaro.org/T/#m4196988be896c461131ee11df51dcdd5b9cdcdc2
Konrad
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> index d1b64280ab0b..136fa5360e8e 100644
> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
> @@ -2074,8 +2074,8 @@ remoteproc_slpi: remoteproc@2400000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> clock-names = "xo";
>
> - power-domains = <&rpmhpd 3>,
> - <&rpmhpd 2>;
> + power-domains = <&rpmhpd SM8150_LCX>,
> + <&rpmhpd SM8150_LMX>;
> power-domain-names = "lcx", "lmx";
>
> memory-region = <&slpi_mem>;
> @@ -2619,8 +2619,8 @@ remoteproc_mpss: remoteproc@4080000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> clock-names = "xo";
>
> - power-domains = <&rpmhpd 7>,
> - <&rpmhpd 0>;
> + power-domains = <&rpmhpd SM8150_CX>,
> + <&rpmhpd SM8150_MSS>;
> power-domain-names = "cx", "mss";
>
> memory-region = <&mpss_mem>;
> @@ -3246,7 +3246,7 @@ remoteproc_cdsp: remoteproc@8300000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> clock-names = "xo";
>
> - power-domains = <&rpmhpd 7>;
> + power-domains = <&rpmhpd SM8150_CX>;
>
> memory-region = <&cdsp_mem>;
>
> @@ -3747,7 +3747,7 @@ remoteproc_adsp: remoteproc@17300000 {
> clocks = <&rpmhcc RPMH_CXO_CLK>;
> clock-names = "xo";
>
> - power-domains = <&rpmhpd 7>;
> + power-domains = <&rpmhpd SM8150_CX>;
>
> memory-region = <&adsp_mem>;
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains
2022-11-16 15:58 ` Konrad Dybcio
@ 2022-11-16 16:30 ` Krzysztof Kozlowski
2022-11-16 16:34 ` Konrad Dybcio
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-16 16:30 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel
On Wed, 16 Nov 2022 at 16:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> On 16/11/2022 16:49, Krzysztof Kozlowski wrote:
> > Use defines for RPMh power domains instead of hard-coding numbers.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> I sent exactly the same patch yesterday.
Then the same as me I think you miss remoteproc@4080000. :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains
2022-11-16 16:30 ` Krzysztof Kozlowski
@ 2022-11-16 16:34 ` Konrad Dybcio
2022-11-16 16:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Dybcio @ 2022-11-16 16:34 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel
On 16/11/2022 17:30, Krzysztof Kozlowski wrote:
> On Wed, 16 Nov 2022 at 16:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>> On 16/11/2022 16:49, Krzysztof Kozlowski wrote:
>>> Use defines for RPMh power domains instead of hard-coding numbers.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>> I sent exactly the same patch yesterday.
>
> Then the same as me I think you miss remoteproc@4080000. :)
Uh.. unless I don't get what you mean, I think we both covered it.
Konrad
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains
2022-11-16 16:34 ` Konrad Dybcio
@ 2022-11-16 16:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-16 16:36 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel
On Wed, 16 Nov 2022 at 17:34, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
>
>
> On 16/11/2022 17:30, Krzysztof Kozlowski wrote:
> > On Wed, 16 Nov 2022 at 16:58, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
> >> On 16/11/2022 16:49, Krzysztof Kozlowski wrote:
> >>> Use defines for RPMh power domains instead of hard-coding numbers.
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> ---
> >> I sent exactly the same patch yesterday.
> >
> > Then the same as me I think you miss remoteproc@4080000. :)
> Uh.. unless I don't get what you mean, I think we both covered it.
Right, different one: mmc@8804000
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-16 16:41 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-16 15:49 [PATCH] arm64: dts: qcom: sm8150: use defines for RPMh power domains Krzysztof Kozlowski
2022-11-16 15:58 ` Konrad Dybcio
2022-11-16 16:30 ` Krzysztof Kozlowski
2022-11-16 16:34 ` Konrad Dybcio
2022-11-16 16:36 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox