* [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties [not found] <20260615132834.2985346-1-can.guo@oss.qualcomm.com> @ 2026-06-15 13:28 ` Can Guo 2026-06-16 3:54 ` Krzysztof Kozlowski 2026-06-16 10:36 ` Peter Wang (王信友) 0 siblings, 2 replies; 3+ messages in thread From: Can Guo @ 2026-06-15 13:28 UTC (permalink / raw) To: krzk, bvanassche, beanhuo, peter.wang, martin.petersen, mani Cc: linux-scsi, Can Guo, Alim Akhtar, Avri Altman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ram Kumar Dwivedi, Zhaoming Luo, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list UFS v5.0/UFSHCI v5.0 adds HS-G6 support (46.6 Gbps/lane) via UniPro v3.0 and M-PHY v6.0. These specs define TX Equalization for all High-Speed Gears (not only HS-G6) to compensate channel loss and improve signal integrity at high speed. For HS-G6, M-PHY uses PAM4 1b1b line coding. Pre-Coding may also be required depending on channel characteristics. Document vendor-neutral properties in ufs-common.yaml: - txeq-preshoot-g[1-6] - txeq-deemphasis-g[1-6] - tx-precode-enable-g6 Values are per-lane Host/Device tuples (2 values for x1, 4 values for x2). PreShoot/DeEmphasis range from 0..7, and Precode is 0/1. These are board-specific signal-integrity tuning values. They depend on channel SI/PHY characterization and validation (host PHY, device PHY, package, and board routing), and are determined by HW/PHY designers. Although UFSHCI v5.0 supports TX Equalization Training via UniPro v3.0, which allows host software to determine optimal TX Equalization at runtime, static board-specific TX Equalization settings in the Device Tree are still necessary because: - TX Equalization Training is not supported for HS-G3 and below - TX Equalization Training is disabled on some platforms Signed-off-by: Can Guo <can.guo@oss.qualcomm.com> --- .../devicetree/bindings/ufs/ufs-common.yaml | 58 +++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml index ed97f5682509..cc32e1189d50 100644 --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml @@ -105,6 +105,64 @@ properties: Restricts the UFS controller to rate-a or rate-b for both TX and RX directions. + tx-precode-enable-g6: + $ref: /schemas/types.yaml#/definitions/uint32-matrix + minItems: 1 + items: + - items: + - description: Host_Lane0 precode + enum: [0, 1] + - description: Device_Lane0 precode + enum: [0, 1] + - items: + - description: Host_Lane1 precode + enum: [0, 1] + - description: Device_Lane1 precode + enum: [0, 1] + description: + Static TX Precode enable values for HS-G6 only. + +patternProperties: + "^txeq-preshoot-g[1-6]$": + $ref: /schemas/types.yaml#/definitions/uint32-matrix + minItems: 1 + items: + - items: + - description: Host_Lane0 Preshoot value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - description: Device_Lane0 Preshoot value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - items: + - description: Host_Lane1 Preshoot value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - description: Device_Lane1 Preshoot value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + description: | + Static TX Equalization PreShoot settings for High Speed Gears. These + values are programmed to the corresponding UniPro PA layer attribute + PA_TxEQG[1-6]Setting. Each value selects a Pre-Shoot level as defined + by the MIPI M-PHY specification (TX_HS_PreShoot_Setting). + + "^txeq-deemphasis-g[1-6]$": + $ref: /schemas/types.yaml#/definitions/uint32-matrix + minItems: 1 + items: + - items: + - description: Host_Lane0 DeEmphasis value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - description: Device_Lane0 DeEmphasis value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - items: + - description: Host_Lane1 DeEmphasis value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + - description: Device_Lane1 DeEmphasis value + enum: [0, 1, 2, 3, 4, 5, 6, 7] + description: | + Static TX Equalization DeEmphasis settings for High Speed Gears. These + values are programmed to the corresponding UniPro PA layer attribute + PA_TxEQG[1-6]Setting. Each value selects a De-Emphasis level as defined + by the MIPI M-PHY specification (TX_HS_DeEmphasis_Setting). + dependencies: freq-table-hz: [ clocks ] operating-points-v2: [ clocks, clock-names ] -- 2.34.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties 2026-06-15 13:28 ` [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties Can Guo @ 2026-06-16 3:54 ` Krzysztof Kozlowski 2026-06-16 10:36 ` Peter Wang (王信友) 1 sibling, 0 replies; 3+ messages in thread From: Krzysztof Kozlowski @ 2026-06-16 3:54 UTC (permalink / raw) To: Can Guo, bvanassche, beanhuo, peter.wang, martin.petersen, mani Cc: linux-scsi, Alim Akhtar, Avri Altman, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ram Kumar Dwivedi, Zhaoming Luo, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, open list On 15/06/2026 15:28, Can Guo wrote: > UFS v5.0/UFSHCI v5.0 adds HS-G6 support (46.6 Gbps/lane) via UniPro > v3.0 and M-PHY v6.0. These specs define TX Equalization for all > High-Speed Gears (not only HS-G6) to compensate channel loss and > improve signal integrity at high speed. > > For HS-G6, M-PHY uses PAM4 1b1b line coding. Pre-Coding may also be > required depending on channel characteristics. > > Document vendor-neutral properties in ufs-common.yaml: > - txeq-preshoot-g[1-6] > - txeq-deemphasis-g[1-6] > - tx-precode-enable-g6 > > Values are per-lane Host/Device tuples (2 values for x1, 4 values for > x2). PreShoot/DeEmphasis range from 0..7, and Precode is 0/1. > > These are board-specific signal-integrity tuning values. They depend on > channel SI/PHY characterization and validation (host PHY, device PHY, > package, and board routing), and are determined by HW/PHY designers. > > Although UFSHCI v5.0 supports TX Equalization Training via UniPro v3.0, > which allows host software to determine optimal TX Equalization at > runtime, static board-specific TX Equalization settings in the Device > Tree are still necessary because: > - TX Equalization Training is not supported for HS-G3 and below > - TX Equalization Training is disabled on some platforms > > Signed-off-by: Can Guo <can.guo@oss.qualcomm.com> > --- > .../devicetree/bindings/ufs/ufs-common.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties 2026-06-15 13:28 ` [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties Can Guo 2026-06-16 3:54 ` Krzysztof Kozlowski @ 2026-06-16 10:36 ` Peter Wang (王信友) 1 sibling, 0 replies; 3+ messages in thread From: Peter Wang (王信友) @ 2026-06-16 10:36 UTC (permalink / raw) To: beanhuo@micron.com, mani@kernel.org, can.guo@oss.qualcomm.com, bvanassche@acm.org, krzk@kernel.org, martin.petersen@oracle.com Cc: avri.altman@wdc.com, zhml@posteo.com, linux-scsi@vger.kernel.org, robh@kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, alim.akhtar@samsung.com, quic_rdwivedi@quicinc.com, conor+dt@kernel.org, devicetree@vger.kernel.org On Mon, 2026-06-15 at 06:28 -0700, Can Guo wrote: > UFS v5.0/UFSHCI v5.0 adds HS-G6 support (46.6 Gbps/lane) via UniPro > v3.0 and M-PHY v6.0. These specs define TX Equalization for all > High-Speed Gears (not only HS-G6) to compensate channel loss and > improve signal integrity at high speed. > > For HS-G6, M-PHY uses PAM4 1b1b line coding. Pre-Coding may also be > required depending on channel characteristics. > > Document vendor-neutral properties in ufs-common.yaml: > - txeq-preshoot-g[1-6] > - txeq-deemphasis-g[1-6] > - tx-precode-enable-g6 > > Values are per-lane Host/Device tuples (2 values for x1, 4 values for > x2). PreShoot/DeEmphasis range from 0..7, and Precode is 0/1. > > These are board-specific signal-integrity tuning values. They depend > on > channel SI/PHY characterization and validation (host PHY, device PHY, > package, and board routing), and are determined by HW/PHY designers. > > Although UFSHCI v5.0 supports TX Equalization Training via UniPro > v3.0, > which allows host software to determine optimal TX Equalization at > runtime, static board-specific TX Equalization settings in the Device > Tree are still necessary because: > - TX Equalization Training is not supported for HS-G3 and below > - TX Equalization Training is disabled on some platforms > > Signed-off-by: Can Guo <can.guo@oss.qualcomm.com> > --- Reviewed-by: Peter Wang <peter.wang@mediatek.com> ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-06-16 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260615132834.2985346-1-can.guo@oss.qualcomm.com>
2026-06-15 13:28 ` [PATCH v9 1/2] dt-bindings: ufs: Document static TX Equalization settings properties Can Guo
2026-06-16 3:54 ` Krzysztof Kozlowski
2026-06-16 10:36 ` Peter Wang (王信友)
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox