Devicetree
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: sashiko-reviews@lists.linux.dev,
	Oleksij Rempel <o.rempel@pengutronix.de>
Cc: krzk+dt@kernel.org, robh@kernel.org, linux-hwmon@vger.kernel.org,
	conor+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v12 3/6] pinctrl: core: Make pin group callbacks optional for pin-only drivers
Date: Sat, 16 May 2026 10:06:40 +0200	[thread overview]
Message-ID: <9671efcb-8347-4b56-8b2d-2f7edd04f424@kernel.org> (raw)
In-Reply-To: <20260515174309.B55B4C2BCB0@smtp.kernel.org>

On 15/05/2026 19:43, sashiko-bot@kernel.org wrote:
>> Currently, the pinctrl core strictly requires all drivers to implement
>> .get_groups_count and .get_group_name callbacks in their pinctrl_ops.
>>
>> However, for simple pinctrl drivers that act purely as GPIO controllers
>> and pin-specific configuration proxies, without any concept of muxing or
>> pin groups, this strict requirement forces the implementation of dummy
>> callbacks just to satisfy pinctrl_check_ops().
>>
>> Relax this requirement for pin-only drivers by making the group callbacks
>> optional when no muxing or group pin configuration support is provided.
>> Update the core and debugfs helpers to check for the existence of these
>> callbacks before invoking them.
>>
>> Drivers that provide muxing or group pin configuration operations still
>> must implement group enumeration and naming callbacks, and are rejected
>> at registration time if they do not.
>>
>> Suggested-by: Linus Walleij <linusw@kernel.org>
>> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> 
> Reviewed-by: Sashiko <sashiko-bot@kernel.org>
> 

NAK, fake tag.

https://lore.kernel.org/linux-devicetree/ad139e54-a7f0-4d09-832c-6b2bf2e93e03@kernel.org/T/#u

Best regards,
Krzysztof

  reply	other threads:[~2026-05-16  8:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 16:05 [PATCH v12 0/6] mfd: Add support for NXP MC33978/MC34978 MSDI Oleksij Rempel
2026-05-15 16:05 ` [PATCH v12 1/6] dt-bindings: pinctrl: add " Oleksij Rempel
2026-05-15 16:05 ` [PATCH v12 2/6] mfd: add NXP MC33978/MC34978 core driver Oleksij Rempel
2026-05-15 16:48   ` sashiko-bot
2026-05-15 16:05 ` [PATCH v12 3/6] pinctrl: core: Make pin group callbacks optional for pin-only drivers Oleksij Rempel
2026-05-15 17:43   ` sashiko-bot
2026-05-16  8:06     ` Krzysztof Kozlowski [this message]
2026-05-15 16:05 ` [PATCH v12 4/6] pinctrl: add NXP MC33978/MC34978 pinctrl driver Oleksij Rempel
2026-05-15 18:07   ` sashiko-bot
2026-05-15 16:05 ` [PATCH v12 5/6] hwmon: add NXP MC33978/MC34978 driver Oleksij Rempel
2026-05-15 18:38   ` sashiko-bot
2026-05-16  8:06     ` Krzysztof Kozlowski
2026-05-15 16:05 ` [PATCH v12 6/6] mux: add NXP MC33978/MC34978 AMUX driver Oleksij Rempel
2026-05-15 19:07   ` sashiko-bot
2026-05-16  7:56     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9671efcb-8347-4b56-8b2d-2f7edd04f424@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox