From: Krzysztof Kozlowski <krzk@kernel.org>
To: Abel Vesa <abel.vesa@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Luca Weiss <luca.weiss@fairphone.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible
Date: Tue, 21 Jul 2026 11:45:57 +0200 [thread overview]
Message-ID: <985af176-362e-4408-987c-dcc8d49d04ff@kernel.org> (raw)
In-Reply-To: <6tmbpelyk2ngvrfmcpb5owli7oo54u63i4w46jxbbj5g3fppv4@4amnegv2u3bs>
On 21/07/2026 11:42, Abel Vesa wrote:
> On 26-07-21 11:22:52, Krzysztof Kozlowski wrote:
>> On Tue, Jul 14, 2026 at 03:24:01PM +0300, Abel Vesa wrote:
>>> + - if:
>>> + properties:
>>> + compatible:
>>> + enum:
>>> + - qcom,eliza-cdsp-pas
>>> + then:
>>> + properties:
>>> + power-domains:
>>> + items:
>>> + - description: CX power domain
>>> + - description: MX power domain
>>> + - description: NSP power domain
>>> + power-domain-names:
>>> + items:
>>> + - const: cx
>>> + - const: mx
>>> + - const: nsp
>>
>> No, do not grow the ifs. Eliza belongs to class of SM8750, so I don't
>> get why it was and it is being added here.
>
> I'm assuming you meant SM8550 here, right?
The SM8550 binding file, but Eliza is SM8750-based in general thus I
would expect it will be documented along SM8750.
>
> Why does Eliza belong to SM8750 but Milos doesn't?
I don't know about Milos, but Eliza is variant of SM8750, right?
>
> Was Milos also a mistake?
This I did not verify.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-21 9:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 12:24 [PATCH 0/2] remoteproc: qcom: pas: Add support for CDSP on Eliza SoC Abel Vesa
2026-07-14 12:24 ` [PATCH 1/2] dt-bindings: remoteproc: qcom,milos-pas: Add Eliza CDSP compatible Abel Vesa
2026-07-14 12:29 ` sashiko-bot
2026-07-21 9:22 ` Krzysztof Kozlowski
2026-07-21 9:42 ` Abel Vesa
2026-07-21 9:45 ` Krzysztof Kozlowski [this message]
2026-07-21 10:00 ` Abel Vesa
2026-07-14 12:24 ` [PATCH 2/2] remoteproc: qcom: pas: Add Eliza CDSP support Abel Vesa
2026-07-15 10:23 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=985af176-362e-4408-987c-dcc8d49d04ff@kernel.org \
--to=krzk@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox