Devicetree
 help / color / mirror / Atom feed
From: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	george.moussalem@outlook.com,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Luo Jie <jie.luo@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate
Date: Tue, 9 Jun 2026 22:29:44 +0530	[thread overview]
Message-ID: <9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com> (raw)
In-Reply-To: <cca7e305-bdf0-4ddb-b299-aa25a183e229@oss.qualcomm.com>


On 6/9/2026 8:42 PM, Konrad Dybcio wrote:
> On 5/21/26 9:55 AM, George Moussalem via B4 Relay wrote:
>> From: George Moussalem <george.moussalem@outlook.com>
>>
>> The correct CMN PLL reference clock rate for IPQ5018 is 4.8 GHz.
>>
>> The CMN PLL driver did not account for the ref clock divider which is 2
>> for IPQ5018. Therefore, the computed rate was twice the actual output.
>>
>> With the driver now accounting for the CMN PLL reference clock
>> divider (commit: 88c543fff756), set the correct reference clock rate.
>>
>> Fixes: c006b249c544 ("arm64: dts: ipq5018: Add CMN PLL node")
>> Signed-off-by: George Moussalem <george.moussalem@outlook.com>
>> ---
>> Changes in v2:
>> - Removed line break in commit message between Fixes and SOB tags
>> - Link to v1: https://patch.msgid.link/20260519-ipq5018-cmn-pll-rate-fix-v1-1-3c83a173c27f@outlook.com
>> ---
> I have no reference for this, but I trust you.. maybe +Kathiravan
> could double-check

Thanks Konrad. As per the HW doc and the commit 88c543fff756 ("clk: 
qcom: cmnpll: Account for reference clock divider"), default ref clock 
divider is 1 in IPQ5018.

@Jie, Can you help here?

>
> Acked-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
>
> Konrad

  reply	other threads:[~2026-06-09 16:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21  7:55 [PATCH v2] arm64: dts: qcom: ipq5018: Correct CMN PLL reference clock rate George Moussalem via B4 Relay
2026-06-09 15:12 ` Konrad Dybcio
2026-06-09 16:59   ` Kathiravan Thirumoorthy [this message]
2026-06-10  3:10     ` Jie Luo
2026-06-10  8:55       ` Konrad Dybcio
2026-07-11 19:49 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9ab1340d-72bb-48df-8784-a584a37b5c76@oss.qualcomm.com \
    --to=kathiravan.thirumoorthy@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=george.moussalem@outlook.com \
    --cc=jie.luo@oss.qualcomm.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox