Devicetree
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Ritesh Kumar <quic_riteshk@quicinc.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	dri-devel@lists.freedesktop.org,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org, Abel Vesa <abelvesa@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/8] dt-bindings: display: panel: novatek,nt36672e: Document the reset GPIO polarity
Date: Thu, 29 Oct 2026 12:30:33 +0200	[thread overview]
Message-ID: <9e64390b-1c67-4a0d-b9f0-22c8de86bb6d@kernel.org> (raw)
In-Reply-To: <20261029-calculating-imaginary-wolf-ccb2a2@quoll>

On 10/29/26 11:49, Krzysztof Kozlowski wrote:
> On Wed, Oct 28, 2026 at 10:27:35PM +0200, Vladimir Zapolskiy wrote:
>> On 10/28/26 16:59, Krzysztof Kozlowski wrote:
>>> On 28/10/2026 15:56, Vladimir Zapolskiy wrote:
>>>>> We might fix it at some point, so not sure if it is worth documenting in
>>>>> the binding. And what about usage of this binding in other projects
>>>>> which implement it correctly?
>>>>>
>>>>
>>>> In the upstream there is only one user qcm6490-idp.dts, and changing
>>>> the polarity will be an ABI breaking change, unfortunately.
>>>
>>> And all other projects?
>>>
>>
>> It might be a challenging task to check usage of "novatek,nt36672e"
>> compatible display panels in all other projects. I've asked about it:
>>
>> * https://chatgpt.com/uc/6ae25571-2ef0-83ea-81e5-2522e70c4a93
>>
>> The check gives this info:
>>
>> 1. Linux kernel - invalid GPIO polarity in the driver and qcm6490-idp.dts,
>> 2. Android - invalid GPIO polarity in the copied driver and qcm6490-idp.dts,
>> 3. FreeBSD - invalid GPIO polarity in the copied qcm6490-idp.dts, no driver.
>>
>> Please let me know, if there are other projects to check. To my
>> understanding the RESET_N polarity cannot be corrected anymore,
>> and the best option is to clearly document a difference between
>> the device and its dt-binding documentation.
> 
> It can be correct, just with impact so we choose not to, but
> nevertheless hardware wants different polarity, so you should not state
> in the binding the incorrect one.
> 
> This property corresponds to the hardware, not chosen SW implementation.
> 

Here by the hardware do you mean a "novatek,nt36672e" compatible panel
hardware, or a board hardware like sm8450-hdk?

Its the panel hardware property to get a reset signal with the proper
polarity (in the ideal world it's taken from the panel datasheet), then
1) this description is missing in the panel dt bindings documentation,
2) if added, this description would contradict to the panel datasheet.

It would make sense to document it, and that's the intention of this
particular proposed change.

-- 
Best wishes,
Vladimir

  reply	other threads:[~2026-10-29 10:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-28  9:51 [PATCH 0/8] drm/panel: novatek-nt36672e: Add SM8450 HDK display card Vladimir Zapolskiy
2026-10-28  9:51 ` [PATCH 1/8] dt-bindings: display: panel: novatek,nt36672e: Document the reset GPIO polarity Vladimir Zapolskiy
2026-10-28 13:56   ` Krzysztof Kozlowski
2026-10-28 14:56     ` Vladimir Zapolskiy
2026-10-28 14:59       ` Krzysztof Kozlowski
2026-10-28 20:27         ` Vladimir Zapolskiy
2026-10-29  9:49           ` Krzysztof Kozlowski
2026-10-29 10:30             ` Vladimir Zapolskiy [this message]
2026-10-28  9:51 ` [PATCH 2/8] dt-bindings: display: panel: novatek,nt36672e: Add bias enable GPIO Vladimir Zapolskiy
2026-10-28 13:57   ` Krzysztof Kozlowski
2026-10-28  9:51 ` [PATCH 3/8] drm/panel: novatek-nt36672e: Make the AVDD and AVEE supplies optional Vladimir Zapolskiy
2026-10-28  9:51 ` [PATCH 4/8] drm/panel: novatek-nt36672e: Support the bias enable GPIO Vladimir Zapolskiy
2026-10-28  9:51 ` [PATCH 5/8] drm/panel: novatek-nt36672e: Verify the number of D-PHY data lanes Vladimir Zapolskiy
2026-10-28  9:51 ` [PATCH 6/8] drm/panel: novatek-nt36672e: Add support of the C-PHY panel module Vladimir Zapolskiy
2026-10-28  9:51 ` [PATCH 7/8] arm64: dts: qcom: sm8450-hdk: Add display card overlay Vladimir Zapolskiy
2026-10-28 12:53   ` Konrad Dybcio
2026-10-28  9:51 ` [PATCH 8/8] arm64: dts: qcom: qcm6490-idp: Describe the panel bias enable GPIO Vladimir Zapolskiy
2026-10-28 12:54   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9e64390b-1c67-4a0d-b9f0-22c8de86bb6d@kernel.org \
    --to=vz@kernel.org \
    --cc=abelvesa@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=quic_riteshk@quicinc.com \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox