From: Kendall Willis <k-willis@ti.com>
To: Nishanth Menon <nm@ti.com>
Cc: Bryan Brattlof <bb@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
"Tero Kristo" <kristo@kernel.org>, Rob Herring <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, "Dhruva Gole" <d-gole@ti.com>,
<vishalm@ti.com>, <sebin.francis@ti.com>, <msp@baylibre.com>,
<khilman@baylibre.com>, <a-kaur@ti.com>, <s-kochidanadu@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/3] arm64: boot: dts: ti: k3-am62l: allow WKUP UART wakeup from LPM
Date: Thu, 15 Jan 2026 11:09:36 -0600 [thread overview]
Message-ID: <9ea936b0-4426-46b1-9935-2a849e7621c1@ti.com> (raw)
In-Reply-To: <20260108180341.t2q6msdh5plbrjf4@parabola>
On 1/8/26 12:03, Nishanth Menon wrote:
> On 11:52-20260108, Kendall Willis wrote:
>> On 1/8/26 11:05, Bryan Brattlof wrote:
>>> On January 7, 2026 thus sayeth Kendall Willis:
>>>> On 1/7/26 10:45, Bryan Brattlof wrote:
>>>>> On January 6, 2026 thus sayeth Kendall Willis:
>>>>>> K3 TI AM62L SoC supports wakeup from WKUP UART when the SoC is in the
>>>>>> DeepSleep low power mode. To allow wakeup from WKUP UART the target-module
>>>>>> device tree node is enabled. The ti-sysc interconnect target module driver
>>>>>> is used to configure the the SYSCONFIG related registers. In this case,
>>>>>> the interconnect target module node configures the WKUP UART to be able to
>>>>>> wakeup from system suspend. The SYSC register is used to enable wakeup
>>>>>> from system suspend for the WKUP UART. Refer to 14.7.2.5 UART in the
>>>>>> AM62L Techincal Reference Manual for registers referenced [1].
>>>>>>
>>>>>> Previous TI SoCs configure the WKUP UART to wakeup from system suspend
>>>>>> using the ti-sysc interconnect target module driver. Refer to commit
>>>>>> ce27f7f9e328 ("arm64: dts: ti: k3-am62-wakeup: Configure ti-sysc for
>>>>>> wkup_uart0") for an example of this.
>>>>>
>>>>> I think I may be confused. What is setting the pinmux for the wkup_uart
>>>>> to allow us to trigger the wake event? It looks like they reset to GPIO
>>>>> pins if not set. Is firmware doing this?
>>>>
>>>> On AM62L, the WKUP UART pinmux is initially set by TFA so that it is set to
>>>> the UART pins, not GPIO. The target-module node sets the WKUP UART SYSC
>>>> register so that wakeup is enabled.
>>>>
>>>
>>> Nice however should we mark the UART in the board file as reserved for
>>> TFA or is it free to be used by Linux and only during the low power
>>> modes after Linux is asleep will it be used by TFA?
>>>
>>> ~Bryan
>>
>> Sorry for the confusion, I said earlier that the WKUP UART could be used by
>> firmware, but that is not to say it is specifically reserved by the firmware
>> in general. TFA sets the WKUP UART pins, but it does not use the WKUP UART
>> for anything else. The only exception for TFA using the WKUP UART is if the
>> user chooses to use the WKUP UART for TFA debugging [1].
>>
>> All of this to say that the WKUP UART *can* be used by Linux, it does not
>> need to be reserved for firmware.
>>
>
> If you are going to use it for linux wakeup, then why dont we enable it for
> linux? what TFA does or not should not dictate device tree unless it is
> a hardware description - provide the full description in dt.
>
When adding a full description of WKUP UART and setting the WKUP UART to
be enabled in Linux, the wakeup functionality stopped working. I am
currently debugging this since I don't think that it should matter if
the WKUP UART is enabled or disabled for the wakeup functionality to
work with this implementation. I will post another version of this
series once I am able to fix the problem.
Best,
Kendall Willis <k-willis@ti.com>
prev parent reply other threads:[~2026-01-15 17:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-06 22:39 [PATCH v2 0/3] arm64: boot: dts: ti: k3-am62l: allow WKUP UART wakeup from LPM Kendall Willis
2026-01-06 22:39 ` [PATCH v2 1/3] arm64: dts: ti: k3-am62l: include WKUP_UART0 in wakeup peripheral window Kendall Willis
2026-01-06 22:39 ` [PATCH v2 2/3] arm64: boot: dts: ti: k3-am62l-wakeup: create label for target-module Kendall Willis
2026-01-06 22:39 ` [PATCH v2 3/3] arm64: boot: dts: ti: k3-am62l3-evm: enable target-module node Kendall Willis
2026-01-07 16:45 ` [PATCH v2 0/3] arm64: boot: dts: ti: k3-am62l: allow WKUP UART wakeup from LPM Bryan Brattlof
2026-01-07 21:44 ` Kendall Willis
2026-01-08 17:05 ` Bryan Brattlof
2026-01-08 17:52 ` Kendall Willis
2026-01-08 18:03 ` Nishanth Menon
2026-01-15 17:09 ` Kendall Willis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ea936b0-4426-46b1-9935-2a849e7621c1@ti.com \
--to=k-willis@ti.com \
--cc=a-kaur@ti.com \
--cc=bb@ti.com \
--cc=conor+dt@kernel.org \
--cc=d-gole@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=kristo@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=s-kochidanadu@ti.com \
--cc=sebin.francis@ti.com \
--cc=vigneshr@ti.com \
--cc=vishalm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox