Devicetree
 help / color / mirror / Atom feed
From: Kumar Gala <galak-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
To: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
Cc: Yoder Stuart-B08248
	<B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
	devicetree-discuss
	<devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org>
Subject: Re: dec behavior question
Date: Tue, 25 Oct 2011 22:10:03 -0500	[thread overview]
Message-ID: <DC6E364B-6427-4D7D-9605-BB5BCF890053@kernel.crashing.org> (raw)
In-Reply-To: <20111025233643.GA5760-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>


On Oct 25, 2011, at 6:36 PM, David Gibson wrote:

> On Tue, Oct 25, 2011 at 08:41:55AM -0500, Kumar Gala wrote:
>> 
>> On Oct 25, 2011, at 7:18 AM, Yoder Stuart-B08248 wrote:
>> 
>>> 
>>> 
>>>> -----Original Message-----
>>>> From: devicetree-discuss-bounces+stuart.yoder=freescale.com-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org
>>>> [mailto:devicetree-discuss-bounces+stuart.yoder=freescale.com-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org] On Behalf Of
>>>> David Gibson
>>>> Sent: Monday, October 24, 2011 6:15 PM
>>>> To: Kumar Gala
>>>> Cc: devicetree-discuss
>>>> Subject: Re: dec behavior question
>>>> 
>>>> On Mon, Oct 24, 2011 at 09:01:49AM -0500, Kumar Gala wrote:
>>>>> If I have something like:
>>>>> 
>>>>> ---------------------------------------
>>>>> spi.dtsi:
>>>>> 
>>>>> &spi0 {
>>>>>       #address-cells = <1>;
>>>>>       #size-cells = <0>;
>>>>>       compatible = "fsl,mpc8536-espi";
>>>>>       reg = <0x7000 0x1000>;
>>>>>       interrupts = <59 0x2 0 0>;
>>>>> };
>>>>> ---------------------------------------
>>>>> 
>>>>> foo.dts:
>>>>> 
>>>>> spi0: spi@f00bar {
>>>>> 	compatible = "FOOBAR";
>>>>> };
>>>>> 
>>>>> /include/ "spi.dtsi"
>>>>> 
>>>>> ---------------------------------------
>>>>> 
>>>>> What do you expect the resulting dtb to look like w/regards to the
>>>>> compatible node?
>>>> 
>>>> It's always last tree wins.  So it will end up with compatible = "FOOBAR".
>>> 
>>> If last wins, then it would be the included file
>>> (compatible = "fsl,mpc8536-espi"), no?
> 
> Uh, yes, sorry.  I misread and assumed the /include/ came first.
> 
>> I don't believe so because the include of spi.dtsi doesn't actually
>> instantiate a node.  This is a little different than use of
>> 'include' for merging of nodes.
> 
> No, it really isn't.  /include/ is just a textual include.  If a node
> is defined multiple times, properties in the last definition always
> win.

So than is there a way to do this?

It seems that node references have to come after their use.  Not exactly sure why that would be the case.

---- the following is invalid ----

/dts-v1/;

&spi0 {
       compatible = "fsl,mpc8536-espi";
};

/{
        spi0: spi@0 {
              compatible = "kumar";
        };
};

  parent reply	other threads:[~2011-10-26  3:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 14:01 dec behavior question Kumar Gala
     [not found] ` <9942C069-D8EC-4133-B436-1DC5F62C502E-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-10-24 23:15   ` David Gibson
     [not found]     ` <20111024231529.GE4191-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-10-25 12:18       ` Yoder Stuart-B08248
     [not found]         ` <9F6FE96B71CF29479FF1CDC8046E1503253081-TcFNo7jSaXM0vywKSws3iq4g8xLGJsHaLnY5E4hWTkheoWH0uzbU5w@public.gmane.org>
2011-10-25 13:41           ` Kumar Gala
     [not found]             ` <0F565319-C054-4B46-8548-7BF4227BD237-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-10-25 23:36               ` David Gibson
     [not found]                 ` <20111025233643.GA5760-MK4v0fQdeXQXU02nzanrWNbf9cGiqdzd@public.gmane.org>
2011-10-26  3:10                   ` Kumar Gala [this message]
     [not found]                     ` <DC6E364B-6427-4D7D-9605-BB5BCF890053-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r@public.gmane.org>
2011-10-26  4:00                       ` David Gibson
2011-10-25 13:23       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC6E364B-6427-4D7D-9605-BB5BCF890053@kernel.crashing.org \
    --to=galak-xvmvhmargas8u2djnn8i7kb+6bgklq7r@public.gmane.org \
    --cc=B08248-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
    --cc=david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org \
    --cc=devicetree-discuss-mnsaURCQ41sdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox