From: "Kaustabh Chakraborty" <kauschluss@disroot.org>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Kaustabh Chakraborty" <kauschluss@disroot.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Lee Jones" <lee@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Pavel Machek" <pavel@kernel.org>
Cc: <linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: mfd: s2mu005-pmic: reorder reg and interrupts properties
Date: Tue, 16 Jun 2026 11:43:24 +0530 [thread overview]
Message-ID: <DJA938R30SZG.7WGSHHZHP07X@disroot.org> (raw)
In-Reply-To: <7dd8dcf3-5aec-442a-941e-7564936befa9@kernel.org>
On 2026-06-16 06:14 +02:00, Krzysztof Kozlowski wrote:
> On 15/06/2026 22:26, Kaustabh Chakraborty wrote:
>> As per convention, and as also reiterated by maintainers [1], the
>> properties in schema is to be ordered similar to how its done in
>> devicetree sources; starting from compatible and reg. Re-order the
>> properties in this schema accordingly.
>>
>> Link: https://lore.kernel.org/all/0240eb13-6c56-4879-8db7-b990a220a78f@kernel.org [1]
>> Suggested-by: Krzysztof Kozlowski <krzk@kernel.org>
>> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org>
>
> Honestly, nah... I commented on v6 so you change the patch. But you were
> posting this huge patchset faster than we can review (v6 and v7 posted
> on the same day!), so v7 got applied where you did not implement the
> comments. One small posting per 24h. One big posting per 2-3 days, not
> more often.
Fair, there were a lot of sashiko reviews, so I quickly addressed most
of them and send a v7. It is indeed a failure on my part. :(
> There is little benefit in fixing this single file.
Fine, I drop the series. I'd assumed it'd be at least fine to have it
before a stable release.
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2026-06-16 6:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-15 20:26 [PATCH 0/3] Additional fixes for "Support for Samsung S2MU005 PMIC and its sub-devices" Kaustabh Chakraborty
2026-06-15 20:26 ` [PATCH 1/3] dt-bindings: mfd: s2mu005-pmic: reorder reg and interrupts properties Kaustabh Chakraborty
2026-06-16 4:14 ` Krzysztof Kozlowski
2026-06-16 6:13 ` Kaustabh Chakraborty [this message]
2026-06-16 8:05 ` Krzysztof Kozlowski
2026-06-15 20:26 ` [PATCH 2/3] dt-bindings: mfd: s2mu005-pmic: drop compatible property for multi-led node Kaustabh Chakraborty
2026-06-15 20:40 ` sashiko-bot
2026-06-16 4:15 ` Krzysztof Kozlowski
2026-06-15 20:26 ` [PATCH 3/3] leds: rgb: s2m: use multi-led node of mfd as source node Kaustabh Chakraborty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJA938R30SZG.7WGSHHZHP07X@disroot.org \
--to=kauschluss@disroot.org \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox