From: "Troy Mitchell" <troy.mitchell@linux.spacemit.com>
To: <sashiko-reviews@lists.linux.dev>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Brian Masney" <bmasney@redhat.com>,
"Yixun Lan" <dlan@kernel.org>, "Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: <linux-clk@vger.kernel.org>, <linux-riscv@lists.infradead.org>,
<spacemit@lists.linux.dev>, <linux-kernel@vger.kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
<devicetree@vger.kernel.org>,
"Troy Mitchell" <troy.mitchell@linux.spacemit.com>
Subject: Re: [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs
Date: Tue, 21 Jul 2026 05:36:54 -0700 [thread overview]
Message-ID: <DK495Y6IBTSP.B55YW3KSSPL2@linux.spacemit.com> (raw)
In-Reply-To: <20260717073330.3CC8B1F000E9@smtp.kernel.org>
> CLK_MPMU_I2S1_SYSCLK keeps its existing ID (47) but will be repointed to
> the real per-instance i2s1 clock in a subsequent patch. No in-tree user
> references this ID so the semantic change is contained.
>
> [Severity: Medium]
> Does the commit message reference the correct clock ID here?
>
> Looking at include/dt-bindings/clock/spacemit,k3-clocks.h, 47 is actually
> assigned to a different clock:
>
> #define CLK_MPMU_I2S1_SYSCLK 34
> ...
> #define CLK_MPMU_I2S2_SYSCLK 47
>
> Could the commit message be updated to reflect the accurate existing ID for
> CLK_MPMU_I2S1_SYSCLK?
Good catch. CLK_MPMU_I2S1_SYSCLK has ID 34, while ID 47 belongs to
CLK_MPMU_I2S2_SYSCLK. I will correct the commit message in the next
version.
- Troy
next prev parent reply other threads:[~2026-07-21 12:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 7:26 [PATCH 0/3] clk: spacemit: k3: fix i2s clock topology and divider rates Troy Mitchell
2026-07-17 7:26 ` [PATCH 1/3] dt-bindings: soc: spacemit: k3: add i2s_sysclk, i2s_bclk_factor and i2s1_sysclk_src IDs Troy Mitchell
2026-07-17 7:33 ` sashiko-bot
2026-07-21 12:36 ` Troy Mitchell [this message]
2026-07-17 7:26 ` [PATCH 2/3] clk: spacemit: k3: fix i2s clock topology Troy Mitchell
2026-07-17 7:26 ` [PATCH 3/3] clk: spacemit: k3: fix missing /2 factor in i2s sysclk dividers Troy Mitchell
2026-07-17 7:37 ` sashiko-bot
2026-07-21 12:37 ` Troy Mitchell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DK495Y6IBTSP.B55YW3KSSPL2@linux.spacemit.com \
--to=troy.mitchell@linux.spacemit.com \
--cc=bmasney@redhat.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sboyd@kernel.org \
--cc=spacemit@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox