* [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes
@ 2026-10-30 9:40 Chunyan Zhang
2026-10-31 18:19 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Chunyan Zhang @ 2026-10-30 9:40 UTC (permalink / raw)
To: Yixun Lan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti
Cc: spacemit, devicetree, linux-riscv, Chunyan Zhang, Troy Mitchell,
linux-kernel
Describe the DWC3 controller and its USB 2.0 PHY for USB3 port A
of the K3 SoC.
Only the U2 lane is described: Port A's SuperSpeed PHY has no driver
yet, so the port runs at high-speed (maximum-speed = "high-speed").
Enable USB3 port A with dr_mode = "peripheral", so it can be used as
a USB device.
Signed-off-by: Chunyan Zhang <chunyan.zhang@linux.spacemit.com>
---
arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 9 ++++++
arch/riscv/boot/dts/spacemit/k3.dtsi | 30 ++++++++++++++++++++
2 files changed, 39 insertions(+)
diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
index b084a35aa00e..74d4fdf9e405 100644
--- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
+++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
@@ -323,6 +323,15 @@ &usb2_phy {
status = "okay";
};
+&usb3a_u2phy {
+ status = "okay";
+};
+
+&usb3a {
+ dr_mode = "peripheral";
+ status = "okay";
+};
+
&usb3d_u2phy {
status = "okay";
};
diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
index c3f2dce0969c..220dfe29bb78 100644
--- a/arch/riscv/boot/dts/spacemit/k3.dtsi
+++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
@@ -630,6 +630,36 @@ gmac2_axi_setup: stmmac-axi-config {
};
};
+ usb3a: usb@cad00000 {
+ compatible = "spacemit,k3-dwc3";
+ reg = <0x0 0xcad00000 0x0 0x10000>;
+ interrupts = <118 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-parent = <&saplic>;
+ clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
+ clock-names = "usbdrd30";
+ resets = <&syscon_apmu RESET_APMU_USB3_A_AHB>,
+ <&syscon_apmu RESET_APMU_USB3_A_VCC>,
+ <&syscon_apmu RESET_APMU_USB3_A_PHY>;
+ reset-names = "ahb", "vcc", "phy";
+ phys = <&usb3a_u2phy>;
+ phy-names = "usb2-phy";
+ phy_type = "utmi";
+ snps,dis_enblslpm_quirk;
+ snps,dis_u2_susphy_quirk;
+ snps,dis-del-phy-power-chg-quirk;
+ snps,dis-tx-ipgap-linecheck-quirk;
+ maximum-speed = "high-speed";
+ status = "disabled";
+ };
+
+ usb3a_u2phy: phy@cad20000 {
+ compatible = "spacemit,k3-usb2-phy";
+ reg = <0x0 0xcad20000 0x0 0x200>;
+ clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
+ #phy-cells = <0>;
+ status = "disabled";
+ };
+
pdma: dma-controller@d4000000 {
compatible = "spacemit,k3-pdma";
reg = <0x0 0xd4000000 0x0 0x4000>;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes
2026-10-30 9:40 [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes Chunyan Zhang
@ 2026-10-31 18:19 ` Aurelien Jarno
2026-11-02 3:22 ` Chunyan Zhang
0 siblings, 1 reply; 4+ messages in thread
From: Aurelien Jarno @ 2026-10-31 18:19 UTC (permalink / raw)
To: Chunyan Zhang
Cc: Yixun Lan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
spacemit, devicetree, linux-riscv, Chunyan Zhang, Troy Mitchell,
linux-kernel
Hi,
On 2026-10-30 17:40, Chunyan Zhang wrote:
> Describe the DWC3 controller and its USB 2.0 PHY for USB3 port A
> of the K3 SoC.
>
> Only the U2 lane is described: Port A's SuperSpeed PHY has no driver
> yet, so the port runs at high-speed (maximum-speed = "high-speed").
>
> Enable USB3 port A with dr_mode = "peripheral", so it can be used as
> a USB device.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@linux.spacemit.com>
> ---
> arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 9 ++++++
> arch/riscv/boot/dts/spacemit/k3.dtsi | 30 ++++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b084a35aa00e..74d4fdf9e405 100644
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -323,6 +323,15 @@ &usb2_phy {
> status = "okay";
> };
>
> +&usb3a_u2phy {
> + status = "okay";
> +};
> +
> +&usb3a {
> + dr_mode = "peripheral";
> + status = "okay";
> +};
> +
> &usb3d_u2phy {
> status = "okay";
> };
> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index c3f2dce0969c..220dfe29bb78 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -630,6 +630,36 @@ gmac2_axi_setup: stmmac-axi-config {
> };
> };
>
> + usb3a: usb@cad00000 {
Please move this after the eth2 node, so that the node addresses are
kept sorted.
> + compatible = "spacemit,k3-dwc3";
> + reg = <0x0 0xcad00000 0x0 0x10000>;
> + interrupts = <118 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-parent = <&saplic>;
> + clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
> + clock-names = "usbdrd30";
> + resets = <&syscon_apmu RESET_APMU_USB3_A_AHB>,
> + <&syscon_apmu RESET_APMU_USB3_A_VCC>,
> + <&syscon_apmu RESET_APMU_USB3_A_PHY>;
> + reset-names = "ahb", "vcc", "phy";
> + phys = <&usb3a_u2phy>;
> + phy-names = "usb2-phy";
Please move the PHYs definition to the board level, matching was it is
done for the other USB3 ports, as other boards might have different PHY
configuration.
> + phy_type = "utmi";
> + snps,dis_enblslpm_quirk;
> + snps,dis_u2_susphy_quirk;
> + snps,dis-del-phy-power-chg-quirk;
> + snps,dis-tx-ipgap-linecheck-quirk;
> + maximum-speed = "high-speed";
I think the maximum-speed property should also be moved to the board
level, as its value depends on the PHYs configuration.
> + status = "disabled";
> + };
Any reason not to define the snps,parkmode-disable-ss-quirk property? It
is defined for the other USB3 ports, as well as for the USB3 A port in
the vendor kernel
> +
> + usb3a_u2phy: phy@cad20000 {
> + compatible = "spacemit,k3-usb2-phy";
> + reg = <0x0 0xcad20000 0x0 0x200>;
> + clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
> + #phy-cells = <0>;
> + status = "disabled";
> + };
> +
> pdma: dma-controller@d4000000 {
> compatible = "spacemit,k3-pdma";
> reg = <0x0 0xd4000000 0x0 0x4000>;
Otherwise looks good.
Regards
Aurelien
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes
2026-10-31 18:19 ` Aurelien Jarno
@ 2026-11-02 3:22 ` Chunyan Zhang
2026-11-02 6:27 ` Troy Mitchell
0 siblings, 1 reply; 4+ messages in thread
From: Chunyan Zhang @ 2026-11-02 3:22 UTC (permalink / raw)
To: Yixun Lan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Paul Walmsley, Palmer Dabbelt, Albert Ou, Alexandre Ghiti,
Aurelien Jarno
Cc: linux-kernel, spacemit, linux-riscv, Chunyan Zhang, Troy Mitchell,
devicetree
Hi Aurelien,
On Sun, 1 Nov 2026 at 02:19, Aurelien Jarno <aurelien@aurel32.net> wrote:
>
> Hi,
>
> On 2026-10-30 17:40, Chunyan Zhang wrote:
> > Describe the DWC3 controller and its USB 2.0 PHY for USB3 port A
> > of the K3 SoC.
> >
> > Only the U2 lane is described: Port A's SuperSpeed PHY has no driver
> > yet, so the port runs at high-speed (maximum-speed = "high-speed").
> >
> > Enable USB3 port A with dr_mode = "peripheral", so it can be used as
> > a USB device.
> >
> > Signed-off-by: Chunyan Zhang <chunyan.zhang@linux.spacemit.com>
> > ---
> > arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 9 ++++++
> > arch/riscv/boot/dts/spacemit/k3.dtsi | 30 ++++++++++++++++++++
> > 2 files changed, 39 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > index b084a35aa00e..74d4fdf9e405 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> > @@ -323,6 +323,15 @@ &usb2_phy {
> > status = "okay";
> > };
> >
> > +&usb3a_u2phy {
> > + status = "okay";
> > +};
> > +
> > +&usb3a {
> > + dr_mode = "peripheral";
> > + status = "okay";
> > +};
> > +
> > &usb3d_u2phy {
> > status = "okay";
> > };
> > diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> > index c3f2dce0969c..220dfe29bb78 100644
> > --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> > +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> > @@ -630,6 +630,36 @@ gmac2_axi_setup: stmmac-axi-config {
> > };
> > };
> >
> > + usb3a: usb@cad00000 {
>
> Please move this after the eth2 node, so that the node addresses are
> kept sorted.
>
> > + compatible = "spacemit,k3-dwc3";
> > + reg = <0x0 0xcad00000 0x0 0x10000>;
> > + interrupts = <118 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupt-parent = <&saplic>;
> > + clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
> > + clock-names = "usbdrd30";
> > + resets = <&syscon_apmu RESET_APMU_USB3_A_AHB>,
> > + <&syscon_apmu RESET_APMU_USB3_A_VCC>,
> > + <&syscon_apmu RESET_APMU_USB3_A_PHY>;
> > + reset-names = "ahb", "vcc", "phy";
> > + phys = <&usb3a_u2phy>;
> > + phy-names = "usb2-phy";
>
> Please move the PHYs definition to the board level, matching was it is
> done for the other USB3 ports, as other boards might have different PHY
> configuration.
>
> > + phy_type = "utmi";
> > + snps,dis_enblslpm_quirk;
> > + snps,dis_u2_susphy_quirk;
> > + snps,dis-del-phy-power-chg-quirk;
> > + snps,dis-tx-ipgap-linecheck-quirk;
> > + maximum-speed = "high-speed";
>
> I think the maximum-speed property should also be moved to the board
> level, as its value depends on the PHYs configuration.
Sure. I will address all the above comments.
>
> > + status = "disabled";
> > + };
>
> Any reason not to define the snps,parkmode-disable-ss-quirk property? It
> is defined for the other USB3 ports, as well as for the USB3 A port in
> the vendor kernel
The original thought was that this property is SS-specific and thus unnecessary
without usb3-phy support. However, since it reflects a hardware characteristic
that applies regardless of the current PHY configuration, adding it makes sense
for consistency and forward compatibility.
>
> > +
> > + usb3a_u2phy: phy@cad20000 {
> > + compatible = "spacemit,k3-usb2-phy";
> > + reg = <0x0 0xcad20000 0x0 0x200>;
> > + clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
> > + #phy-cells = <0>;
> > + status = "disabled";
> > + };
> > +
> > pdma: dma-controller@d4000000 {
> > compatible = "spacemit,k3-pdma";
> > reg = <0x0 0xd4000000 0x0 0x4000>;
>
> Otherwise looks good.
Thanks for the review,
Chunyan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes
2026-11-02 3:22 ` Chunyan Zhang
@ 2026-11-02 6:27 ` Troy Mitchell
0 siblings, 0 replies; 4+ messages in thread
From: Troy Mitchell @ 2026-11-02 6:27 UTC (permalink / raw)
To: Chunyan Zhang, Yixun Lan, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Alexandre Ghiti, Aurelien Jarno
Cc: linux-kernel, spacemit, linux-riscv, Chunyan Zhang, Troy Mitchell,
devicetree, linux-riscv, Troy Mitchell
[-- Attachment #1: Type: text/plain, Size: 2589 bytes --]
Hi Chunyan,
On Fri Oct 30, 2026 at 5:40 PM +0800, Chunyan Zhang wrote:
> Describe the DWC3 controller and its USB 2.0 PHY for USB3 port A
> of the K3 SoC.
>
> Only the U2 lane is described: Port A's SuperSpeed PHY has no driver
> yet, so the port runs at high-speed (maximum-speed = "high-speed").
>
> Enable USB3 port A with dr_mode = "peripheral", so it can be used as
> a USB device.
Port A is a Type-C port behind a FUSB301, so please note in the commit
message that it's device-only until the CC controller is described.
Was this tested with a C-to-C cable? That depends on the FUSB301's
power-on CC mode, since nothing configures it yet.
>
> Signed-off-by: Chunyan Zhang <chunyan.zhang@linux.spacemit.com>
> ---
> arch/riscv/boot/dts/spacemit/k3-pico-itx.dts | 9 ++++++
> arch/riscv/boot/dts/spacemit/k3.dtsi | 30 ++++++++++++++++++++
> 2 files changed, 39 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> index b084a35aa00e..74d4fdf9e405 100644
Please rebase onto spacemit for-next, which already has Aurelien's
USB3 phy rework.
> --- a/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> +++ b/arch/riscv/boot/dts/spacemit/k3-pico-itx.dts
> @@ -323,6 +323,15 @@ &usb2_phy {
> status = "okay";
> };
>
> +&usb3a_u2phy {
> + status = "okay";
> +};
> +
> +&usb3a {
> + dr_mode = "peripheral";
> + status = "okay";
> +};
After the rebase these should go before &usb3b.
> +
> &usb3d_u2phy {
> status = "okay";
> };
> diff --git a/arch/riscv/boot/dts/spacemit/k3.dtsi b/arch/riscv/boot/dts/spacemit/k3.dtsi
> index c3f2dce0969c..220dfe29bb78 100644
> --- a/arch/riscv/boot/dts/spacemit/k3.dtsi
> +++ b/arch/riscv/boot/dts/spacemit/k3.dtsi
> @@ -630,6 +630,36 @@ gmac2_axi_setup: stmmac-axi-config {
> };
> };
>
> + usb3a: usb@cad00000 {
> + compatible = "spacemit,k3-dwc3";
> + reg = <0x0 0xcad00000 0x0 0x10000>;
> + interrupts = <118 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-parent = <&saplic>;
> + clocks = <&syscon_apmu CLK_APMU_USB3_PORTA_BUS>;
> + clock-names = "usbdrd30";
> + resets = <&syscon_apmu RESET_APMU_USB3_A_AHB>,
> + <&syscon_apmu RESET_APMU_USB3_A_VCC>,
> + <&syscon_apmu RESET_APMU_USB3_A_PHY>;
> + reset-names = "ahb", "vcc", "phy";
> + phys = <&usb3a_u2phy>;
> + phy-names = "usb2-phy";
> + phy_type = "utmi";
> + snps,dis_enblslpm_quirk;
> + snps,dis_u2_susphy_quirk;
snps,dis_u3_susphy_quirk is missing too, like usb3b/c/d.
--
Troy Mitchell
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-02 6:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 9:40 [PATCH] riscv: dts: spacemit: k3: add USB3 port A (DRD) nodes Chunyan Zhang
2026-10-31 18:19 ` Aurelien Jarno
2026-11-02 3:22 ` Chunyan Zhang
2026-11-02 6:27 ` Troy Mitchell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox