* Re: Fix a filehandle leak [not found] <20100714061056.GE23242@yookeroo> @ 2010-07-14 22:31 ` Jon Loeliger [not found] ` <E1OZAUM-0007wJ-A8-CYoMK+44s/E@public.gmane.org> 0 siblings, 1 reply; 3+ messages in thread From: Jon Loeliger @ 2010-07-14 22:31 UTC (permalink / raw) To: David Gibson; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ > From: Martin Ettl <ettl.martin-Mmb7MZpHnFY@public.gmane.org> > > During a check of the current git head of the linux kernel with the > static code analysis tool cppcheck > (http://sourceforge.net/apps/mediawiki/cppcheck/index.php?title=Main_Page) > the tool discovered a resource leak in linux-2.6/scripts/dtc/fstree.c. > > Please refer the attached patch, that fixes the issue. > > Fixes https://bugzilla.kernel.org/show_bug.cgi?id=15363 > > Signed-off-by: Martin Ettl <ettl.martin-Mmb7MZpHnFY@public.gmane.org> > Signed-off-by: Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org> > Signed-off-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org> > > --- > > Jon, please apply. > > scripts/dtc/fstree.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/scripts/dtc/fstree.c b/scripts/dtc/fstree.c > index 766b269..8fe1bdf 100644 > --- a/scripts/dtc/fstree.c > +++ b/scripts/dtc/fstree.c > @@ -77,6 +77,7 @@ static struct node *read_fstree(const char *dirname) > free(tmpnam); > } > > + closedir(d); > return tree; > } > > -- > 1.7.1 > > -- > David Gibson | I'll have my music baroque, and my code > david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _ot > her_ > | _way_ _around_! > http://www.ozlabs.org/~dgibson Applied -p 3. jdl ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <E1OZAUM-0007wJ-A8-CYoMK+44s/E@public.gmane.org>]
* Re: Fix a filehandle leak [not found] ` <E1OZAUM-0007wJ-A8-CYoMK+44s/E@public.gmane.org> @ 2010-07-15 4:01 ` David Gibson 2010-07-15 12:09 ` Jon Loeliger 0 siblings, 1 reply; 3+ messages in thread From: David Gibson @ 2010-07-15 4:01 UTC (permalink / raw) To: Jon Loeliger; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ On Wed, Jul 14, 2010 at 05:31:38PM -0500, Jon Loeliger wrote: > > From: Martin Ettl <ettl.martin-Mmb7MZpHnFY@public.gmane.org> [snip] > > Applied -p 3. Ugh, sorry. Meant to mangle the patch to apply directly to the dtc tree, but I forgot. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Fix a filehandle leak 2010-07-15 4:01 ` David Gibson @ 2010-07-15 12:09 ` Jon Loeliger 0 siblings, 0 replies; 3+ messages in thread From: Jon Loeliger @ 2010-07-15 12:09 UTC (permalink / raw) To: David Gibson; +Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ > On Wed, Jul 14, 2010 at 05:31:38PM -0500, Jon Loeliger wrote: > > > From: Martin Ettl <ettl.martin-Mmb7MZpHnFY@public.gmane.org> > [snip] > > > > Applied -p 3. > > Ugh, sorry. Meant to mangle the patch to apply directly to the dtc > tree, but I forgot. No worries. jdl ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-15 12:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100714061056.GE23242@yookeroo>
2010-07-14 22:31 ` Fix a filehandle leak Jon Loeliger
[not found] ` <E1OZAUM-0007wJ-A8-CYoMK+44s/E@public.gmane.org>
2010-07-15 4:01 ` David Gibson
2010-07-15 12:09 ` Jon Loeliger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox