* [PATCH] ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode
@ 2019-06-19 22:35 Russell King
2019-06-19 22:37 ` Russell King - ARM Linux admin
0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2019-06-19 22:35 UTC (permalink / raw)
To: Fabio Estevam, Sascha Hauer, Shawn Guo
Cc: Mark Rutland, devicetree, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
A change to the AT803x driver fixed the handling of the phy interface
mode, but this breaks all platforms that use "rgmii" as the mode in
their DT. Fix the Solidrun platforms.
Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
index 4ccb7afc4b35..6d7f6b9035bc 100644
--- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
@@ -53,7 +53,7 @@
&fec {
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-reset-duration = <2>;
phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
status = "okay";
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode
2019-06-19 22:35 [PATCH] ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode Russell King
@ 2019-06-19 22:37 ` Russell King - ARM Linux admin
2019-06-19 23:06 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Russell King - ARM Linux admin @ 2019-06-19 22:37 UTC (permalink / raw)
To: Fabio Estevam, Sascha Hauer, Shawn Guo
Cc: Mark Rutland, devicetree, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, linux-arm-kernel
On Wed, Jun 19, 2019 at 11:35:58PM +0100, Russell King wrote:
> A change to the AT803x driver fixed the handling of the phy interface
> mode, but this breaks all platforms that use "rgmii" as the mode in
> their DT. Fix the Solidrun platforms.
>
> Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Note that without this, SolidRun Hummingboard and Cubox-i platforms
have no working ethernet with at least 5.1 kernels, which is a
regression.
> ---
> arch/arm/boot/dts/imx6qdl-sr-som.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
> index 4ccb7afc4b35..6d7f6b9035bc 100644
> --- a/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sr-som.dtsi
> @@ -53,7 +53,7 @@
> &fec {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_microsom_enet_ar8035>;
> - phy-mode = "rgmii";
> + phy-mode = "rgmii-id";
> phy-reset-duration = <2>;
> phy-reset-gpios = <&gpio4 15 GPIO_ACTIVE_LOW>;
> status = "okay";
> --
> 2.7.4
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode
2019-06-19 22:37 ` Russell King - ARM Linux admin
@ 2019-06-19 23:06 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2019-06-19 23:06 UTC (permalink / raw)
To: Russell King - ARM Linux admin
Cc: Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Sascha Hauer, Rob Herring, NXP Linux Team,
Pengutronix Kernel Team, Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Hi Russell,
On Wed, Jun 19, 2019 at 7:37 PM Russell King - ARM Linux admin
<linux@armlinux.org.uk> wrote:
>
> On Wed, Jun 19, 2019 at 11:35:58PM +0100, Russell King wrote:
> > A change to the AT803x driver fixed the handling of the phy interface
> > mode, but this breaks all platforms that use "rgmii" as the mode in
> > their DT. Fix the Solidrun platforms.
> >
> > Fixes: 6d4cd041f0af ("net: phy: at803x: disable delay only for RGMII mode")
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
>
> Note that without this, SolidRun Hummingboard and Cubox-i platforms
> have no working ethernet with at least 5.1 kernels, which is a
> regression.
Commit 0672d22a1924 ("ARM: dts: imx: Fix the AR803X phy-mode") fixes
this issue in mainline and it has already been applied to the 5.1
stable tree as well.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-19 23:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-19 22:35 [PATCH] ARM: dts: imx6qdl-sr-som: fix AR8035 phy interface mode Russell King
2019-06-19 22:37 ` Russell King - ARM Linux admin
2019-06-19 23:06 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox