Re: [PATCH] DT: export of_get_next_parent() for use by modules: fix modular V4L2

[Guennadi Liakhovetski <g.liakhovetski@gmx.de>]

Hi all

On Tue, 2 Apr 2013, Guennadi Liakhovetski wrote:

> On Tue, 2 Apr 2013, Arnd Bergmann wrote:
> 
> > On Tuesday 02 April 2013, Guennadi Liakhovetski wrote:
> > > Currently modular V4L2 build with enabled OF is broken dur to the
> > > of_get_next_parent() function being unavailable to modules. Export it to
> > > fix the build.
> > > 
> > > Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > 
> > Looks good to me, but shouldn't this be EXPORT_SYMBOL_GPL?
> 
> "grep EXPORT_SYMBOL drivers/of/base.c" doesn't give a certain answer, but 
> it seems to fit other of_get_* functions pretty well:

Ping, could this patch be pushed to -next asap, please? Without it the 
current V4L2 -next doesn't compile. Also, I think, ro avoid breaking the 
mainline, we should try to have this patch pulled in before the media 
tree, could that be done?

Thanks
Guennadi

>  EXPORT_SYMBOL(of_get_parent);
> +EXPORT_SYMBOL(of_get_next_parent);
>  EXPORT_SYMBOL(of_get_next_child);
>  EXPORT_SYMBOL(of_get_next_available_child);
>  EXPORT_SYMBOL(of_get_child_by_name);

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/