From: Thierry Reding <thierry.reding@gmail.com>
To: Prathamesh Shete <pshete@nvidia.com>
Cc: Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, smangipudi@nvidia.com,
linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-tegra@vger.kernel.org, jonathanh@nvidia.com
Subject: Re: [PATCH 1/3] dt-bindings: pinctrl: tegra234: Add DT binding doc
Date: Wed, 8 Feb 2023 12:29:54 +0100 [thread overview]
Message-ID: <Y+OHss1GJysBxYZl@orome> (raw)
In-Reply-To: <167577954273.3457850.16805281654046177833.robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1163 bytes --]
On Tue, Feb 07, 2023 at 08:37:51AM -0600, Rob Herring wrote:
>
> On Tue, 07 Feb 2023 17:26:15 +0530, Prathamesh Shete wrote:
> > Add DT binding doc for Tegra234 pinmux driver.
> >
> > Signed-off-by: Prathamesh Shete <pshete@nvidia.com>
> > ---
> > .../pinctrl/nvidia,tegra234-pinmux.yaml | 232 ++++++++++++++++++
> > 1 file changed, 232 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pinctrl/nvidia,tegra234-pinmux.example.dtb: pinmux@2430000: pinmux-pex-rst-c5-out:pex_rst:nvidia,pins:0: 'pex_l5_rst_n_pgg1' is not one of
[...]
Prathamesh,
Looks like maybe you copied the example from Tegra194. On Tegra234 I
think the corresponding GPIO is AF1, so the full pin name for this is
pex_l5_rst_n_paf1.
Please fix and make sure to run the DT binding check before sending out
v2.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-02-08 11:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 11:56 [PATCH 1/3] dt-bindings: pinctrl: tegra234: Add DT binding doc Prathamesh Shete
2023-02-07 11:56 ` [PATCH 2/3] pinctrl: tegra: Add Tegra234 pinmux driver Prathamesh Shete
2023-02-07 11:56 ` [PATCH 3/3] arm64: tegra: Add Tegra234 pinmux device Prathamesh Shete
2023-02-07 15:33 ` Krzysztof Kozlowski
2023-02-08 11:00 ` Thierry Reding
2023-02-08 12:01 ` Krzysztof Kozlowski
2023-02-08 12:06 ` Krzysztof Kozlowski
2023-02-08 15:46 ` Thierry Reding
2023-02-07 14:37 ` [PATCH 1/3] dt-bindings: pinctrl: tegra234: Add DT binding doc Rob Herring
2023-02-08 11:29 ` Thierry Reding [this message]
2023-02-07 15:33 ` Krzysztof Kozlowski
2023-02-08 11:24 ` Thierry Reding
2023-02-08 11:57 ` Krzysztof Kozlowski
2023-03-08 11:45 ` Prathamesh Shete
2023-03-08 12:24 ` Krzysztof Kozlowski
2023-03-23 14:11 ` Thierry Reding
2023-03-26 12:19 ` Krzysztof Kozlowski
2023-03-28 12:39 ` Thierry Reding
2023-03-30 13:58 ` Krzysztof Kozlowski
2023-03-30 16:32 ` Thierry Reding
2023-04-20 17:06 ` Thierry Reding
2023-04-20 17:16 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+OHss1GJysBxYZl@orome \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=pshete@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=smangipudi@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox