* [PATCH] dt-bindings: timer: add #size-cells 2 for ARM
@ 2021-12-15 14:45 David Heidelberg
2021-12-15 16:41 ` Mark Rutland
2021-12-16 1:10 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: David Heidelberg @ 2021-12-15 14:45 UTC (permalink / raw)
To: Daniel Lezcano, Thomas Gleixner, Rob Herring, Marc Zyngier,
Mark Rutland
Cc: Caleb Connolly, David Heidelberg, linux-kernel, devicetree
It's already widely used by dt-schemas, so I blindly assume it's correct.
Fixes warnings as:
arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: timer@17c90000: #size-cells:0:0: 1 was expected
From schema: Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
Signed-off-by: David Heidelberg <david@ixit.cz>
---
.../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
index cd2176cad53a..c061bb90b8e7 100644
--- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
+++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
@@ -30,7 +30,7 @@ properties:
enum: [1, 2]
'#size-cells':
- const: 1
+ enum: [1, 2]
ranges: true
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: timer: add #size-cells 2 for ARM
2021-12-15 14:45 [PATCH] dt-bindings: timer: add #size-cells 2 for ARM David Heidelberg
@ 2021-12-15 16:41 ` Mark Rutland
2021-12-16 1:10 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Mark Rutland @ 2021-12-15 16:41 UTC (permalink / raw)
To: David Heidelberg
Cc: Daniel Lezcano, Thomas Gleixner, Rob Herring, Marc Zyngier,
Caleb Connolly, linux-kernel, devicetree
On Wed, Dec 15, 2021 at 03:45:00PM +0100, David Heidelberg wrote:
> It's already widely used by dt-schemas, so I blindly assume it's correct.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: timer@17c90000: #size-cells:0:0: 1 was expected
> From schema: Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
FWIW, that makes sense to me, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
I assume Rob will pick this (or otherwise correct me).
Thanks,
Mark.
> ---
> .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> index cd2176cad53a..c061bb90b8e7 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> @@ -30,7 +30,7 @@ properties:
> enum: [1, 2]
>
> '#size-cells':
> - const: 1
> + enum: [1, 2]
>
> ranges: true
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: timer: add #size-cells 2 for ARM
2021-12-15 14:45 [PATCH] dt-bindings: timer: add #size-cells 2 for ARM David Heidelberg
2021-12-15 16:41 ` Mark Rutland
@ 2021-12-16 1:10 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-12-16 1:10 UTC (permalink / raw)
To: David Heidelberg
Cc: Daniel Lezcano, Thomas Gleixner, Marc Zyngier, Mark Rutland,
Caleb Connolly, linux-kernel@vger.kernel.org, devicetree
On Wed, Dec 15, 2021 at 8:45 AM David Heidelberg <david@ixit.cz> wrote:
>
> It's already widely used by dt-schemas, so I blindly assume it's correct.
>
> Fixes warnings as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dt.yaml: timer@17c90000: #size-cells:0:0: 1 was expected
> From schema: Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
That's somewhat on purpose. There's no reason the timer needs >32-bits
of address or size. Sadly, QCom has ignored the warnings and just
copy-n-pasted the same thing over and over.
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> .../devicetree/bindings/timer/arm,arch_timer_mmio.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> index cd2176cad53a..c061bb90b8e7 100644
> --- a/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> +++ b/Documentation/devicetree/bindings/timer/arm,arch_timer_mmio.yaml
> @@ -30,7 +30,7 @@ properties:
> enum: [1, 2]
>
> '#size-cells':
> - const: 1
> + enum: [1, 2]
>
> ranges: true
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-16 1:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-15 14:45 [PATCH] dt-bindings: timer: add #size-cells 2 for ARM David Heidelberg
2021-12-15 16:41 ` Mark Rutland
2021-12-16 1:10 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox