* [PATCH] arm64: dts: qcom: add ITS device tree node
@ 2022-05-01 19:50 Dmitry Baryshkov
2022-05-02 5:00 ` Vinod Koul
2022-05-02 17:55 ` Konrad Dybcio
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-05-01 19:50 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, Vinod Koul
Add device tree node corresponding to the ITS part of GICv3.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 3e4c710d3275..4fcb6e2b096b 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2865,6 +2865,9 @@ apps_smmu: iommu@15000000 {
intc: interrupt-controller@17100000 {
compatible = "arm,gic-v3";
+ #address-cells = <2>;
+ #size-cells = <2>;
+ ranges;
#interrupt-cells = <3>;
interrupt-controller;
#redistributor-regions = <1>;
@@ -2872,6 +2875,13 @@ intc: interrupt-controller@17100000 {
reg = <0x0 0x17100000 0x0 0x10000>, /* GICD */
<0x0 0x17180000 0x0 0x200000>; /* GICR * 8 */
interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
+
+ gic_its: msi-controller@17140000 {
+ compatible = "arm,gic-v3-its";
+ msi-controller;
+ #msi-cells = <1>;
+ reg = <0x0 0x17140000 0x0 0x20000>;
+ };
};
timer@17420000 {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: add ITS device tree node
2022-05-01 19:50 [PATCH] arm64: dts: qcom: add ITS device tree node Dmitry Baryshkov
@ 2022-05-02 5:00 ` Vinod Koul
2022-05-02 17:55 ` Konrad Dybcio
1 sibling, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-05-02 5:00 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree
On 01-05-22, 22:50, Dmitry Baryshkov wrote:
> Add device tree node corresponding to the ITS part of GICv3.
Reviewed-by: Vinod Koul <vkoul@kernel.org>
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: qcom: add ITS device tree node
2022-05-01 19:50 [PATCH] arm64: dts: qcom: add ITS device tree node Dmitry Baryshkov
2022-05-02 5:00 ` Vinod Koul
@ 2022-05-02 17:55 ` Konrad Dybcio
2022-05-02 18:52 ` Dmitry Baryshkov
1 sibling, 1 reply; 4+ messages in thread
From: Konrad Dybcio @ 2022-05-02 17:55 UTC (permalink / raw)
To: Dmitry Baryshkov, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski
Cc: linux-arm-msm, devicetree, Vinod Koul
On 1.05.2022 21:50, Dmitry Baryshkov wrote:
> Add device tree node corresponding to the ITS part of GICv3.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Vinod Koul <vkoul@kernel.org>
> ---
Hi,
please keep the properties order coherent with other nodes, so:
[compatible]
[reg]
[various props]
[#-cells]
[ranges]
[status]
Konrad
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 3e4c710d3275..4fcb6e2b096b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2865,6 +2865,9 @@ apps_smmu: iommu@15000000 {
>
> intc: interrupt-controller@17100000 {
> compatible = "arm,gic-v3";
> + #address-cells = <2>;
> + #size-cells = <2>;
> + ranges;
> #interrupt-cells = <3>;
> interrupt-controller;
> #redistributor-regions = <1>;
> @@ -2872,6 +2875,13 @@ intc: interrupt-controller@17100000 {
> reg = <0x0 0x17100000 0x0 0x10000>, /* GICD */
> <0x0 0x17180000 0x0 0x200000>; /* GICR * 8 */
> interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> +
> + gic_its: msi-controller@17140000 {
> + compatible = "arm,gic-v3-its";
> + msi-controller;
> + #msi-cells = <1>;
> + reg = <0x0 0x17140000 0x0 0x20000>;
> + };
> };
>
> timer@17420000 {
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm64: dts: qcom: add ITS device tree node
2022-05-02 17:55 ` Konrad Dybcio
@ 2022-05-02 18:52 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-05-02 18:52 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
linux-arm-msm, devicetree, Vinod Koul
On Mon, 2 May 2022 at 20:55, Konrad Dybcio <konrad.dybcio@somainline.org> wrote:
>
>
>
> On 1.05.2022 21:50, Dmitry Baryshkov wrote:
> > Add device tree node corresponding to the ITS part of GICv3.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> > Reviewed-by: Vinod Koul <vkoul@kernel.org>
> > ---
> Hi,
>
> please keep the properties order coherent with other nodes, so:
>
> [compatible]
> [reg]
> [various props]
> [#-cells]
> [ranges]
> [status]
>
Never memorized the order. Thanks for the pointer!
>
> Konrad
>
> > arch/arm64/boot/dts/qcom/sm8450.dtsi | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > index 3e4c710d3275..4fcb6e2b096b 100644
> > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> > @@ -2865,6 +2865,9 @@ apps_smmu: iommu@15000000 {
> >
> > intc: interrupt-controller@17100000 {
> > compatible = "arm,gic-v3";
> > + #address-cells = <2>;
> > + #size-cells = <2>;
> > + ranges;
> > #interrupt-cells = <3>;
> > interrupt-controller;
> > #redistributor-regions = <1>;
> > @@ -2872,6 +2875,13 @@ intc: interrupt-controller@17100000 {
> > reg = <0x0 0x17100000 0x0 0x10000>, /* GICD */
> > <0x0 0x17180000 0x0 0x200000>; /* GICR * 8 */
> > interrupts = <GIC_PPI 9 IRQ_TYPE_LEVEL_HIGH>;
> > +
> > + gic_its: msi-controller@17140000 {
> > + compatible = "arm,gic-v3-its";
> > + msi-controller;
> > + #msi-cells = <1>;
> > + reg = <0x0 0x17140000 0x0 0x20000>;
> > + };
> > };
> >
> > timer@17420000 {
> >
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-02 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-01 19:50 [PATCH] arm64: dts: qcom: add ITS device tree node Dmitry Baryshkov
2022-05-02 5:00 ` Vinod Koul
2022-05-02 17:55 ` Konrad Dybcio
2022-05-02 18:52 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox