From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: jic23@kernel.org, lars@metafoo.de, robh@kernel.org,
krzk+dt@kernel.org, conor+dt@kernel.org,
andriy.shevchenko@linux.intel.com, ajarizzo@gmail.com,
ak@it-klinger.de, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface
Date: Sat, 30 Nov 2024 00:51:46 +0100 [thread overview]
Message-ID: <Z0pTkhFJKPf2rBk0@vamoirid-laptop> (raw)
In-Reply-To: <tqemkmoa5cewpfxkaltkxj4upgsonjm2br5pwmv7rdmz4gq4vc@2r522tx33gzh>
On Fri, Nov 29, 2024 at 08:22:00AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 29, 2024 at 12:24:48AM +0100, Vasileios Amoiridis wrote:
> > @@ -73,6 +77,19 @@ allOf:
> > then:
> > properties:
> > interrupts: false
> > + - if:
> > + properties:
> > + compatible:
> > + not:
> > + contains:
> > + enum:
>
> You have just two variants in this "not-containts", so invert your
> clause. Easier code.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
>
Hi Krzysztof,
Thank you very much for the review! I will fix it in the next version.
Cheers,
Vasilis
next prev parent reply other threads:[~2024-11-29 23:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-28 23:24 [PATCH v1 0/3] iio: pressure: bmp280: Minor cleanup Vasileios Amoiridis
2024-11-28 23:24 ` [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface Vasileios Amoiridis
2024-11-29 7:22 ` Krzysztof Kozlowski
2024-11-29 23:51 ` Vasileios Amoiridis [this message]
2024-11-28 23:24 ` [PATCH v1 2/3] iio: pressure: bmp280: Use sizeof() for denominator Vasileios Amoiridis
2024-11-29 15:20 ` Andy Shevchenko
2024-11-28 23:24 ` [PATCH v1 3/3] iio: pressure: bmp280: Make time vars intuitive and move to fsleep Vasileios Amoiridis
2024-11-29 15:01 ` Andy Shevchenko
2024-11-29 23:54 ` Vasileios Amoiridis
2024-11-30 14:30 ` [PATCH v1 0/3] iio: pressure: bmp280: Minor cleanup Jonathan Cameron
2024-12-02 18:10 ` Vasileios Amoiridis
-- strict thread matches above, loose matches on Subject: below --
2024-12-02 18:19 [PATCH v2 " Vasileios Amoiridis
2024-12-02 18:19 ` [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface Vasileios Amoiridis
2024-12-02 20:46 ` Rob Herring (Arm)
2024-12-02 22:04 ` Vasileios Amoiridis
2024-12-03 7:23 ` Krzysztof Kozlowski
2024-12-03 20:00 ` Vasileios Amoiridis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z0pTkhFJKPf2rBk0@vamoirid-laptop \
--to=vassilisamir@gmail.com \
--cc=ajarizzo@gmail.com \
--cc=ak@it-klinger.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox