public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Vasileios Amoiridis <vassilisamir@gmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Rob Herring (Arm)" <robh@kernel.org>,
	ak@it-klinger.de, jic23@kernel.org, conor+dt@kernel.org,
	linux-iio@vger.kernel.org, lars@metafoo.de,
	linux-kernel@vger.kernel.org, krzk+dt@kernel.org,
	andriy.shevchenko@linux.intel.com, devicetree@vger.kernel.org,
	ajarizzo@gmail.com
Subject: Re: [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface
Date: Tue, 3 Dec 2024 21:00:24 +0100	[thread overview]
Message-ID: <Z09jWONoaH3R3XSX@vamoirid-laptop> (raw)
In-Reply-To: <e5960ea6-c3f3-4cb4-a93d-adff20a665e2@linaro.org>

On Tue, Dec 03, 2024 at 08:23:35AM +0100, Krzysztof Kozlowski wrote:
> On 02/12/2024 23:04, Vasileios Amoiridis wrote:
> > On Mon, Dec 02, 2024 at 02:46:13PM -0600, Rob Herring (Arm) wrote:
> >>
> >> On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote:
> >>> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it
> >>> in the device-tree.
> >>>
> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >>> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
> >>> ---
> >>>  .../bindings/iio/pressure/bmp085.yaml         | 32 +++++++++++++++++++
> >>>  1 file changed, 32 insertions(+)
> >>>
> >>
> >> My bot found errors running 'make dt_binding_check' on your patch:
> >>
> >> yamllint warnings/errors:
> >>
> >> dtschema/dtc warnings/errors:
> >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]]
> > 
> > Hi Rob, Krzysztof,
> > 
> > The error is in the example, I put the tree from the I2C example to SPI
> > but I used bmp280 which is not supporting interrupts. Will be fixed.
> 
> 
> So you sent a patch with a known bug or just did not test?
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Nothing of the two. I didn't test properly. I am trying to automate my
testing+sending patches process (Andy mentioned something similar in
another e-mail in this series). Do you have any advice/tool to propose
on how to automate this? It would be very welcome!

Sorry for the inconvenience in any case.

Cheers,
Vasilis

  reply	other threads:[~2024-12-03 20:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-02 18:19 [PATCH v2 0/3] iio: pressure: bmp280: Minor cleanup Vasileios Amoiridis
2024-12-02 18:19 ` [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface Vasileios Amoiridis
2024-12-02 20:46   ` Rob Herring (Arm)
2024-12-02 22:04     ` Vasileios Amoiridis
2024-12-03  7:23       ` Krzysztof Kozlowski
2024-12-03 20:00         ` Vasileios Amoiridis [this message]
2024-12-02 18:19 ` [PATCH v1 2/3] iio: pressure: bmp280: Use sizeof() for denominator Vasileios Amoiridis
2024-12-08 18:06   ` Jonathan Cameron
2024-12-02 18:19 ` [PATCH v1 3/3] iio: pressure: bmp280: Make time vars intuitive and move to fsleep Vasileios Amoiridis
2024-12-08 18:08   ` Jonathan Cameron
2024-12-02 18:42 ` [PATCH v2 0/3] iio: pressure: bmp280: Minor cleanup Andy Shevchenko
2024-12-02 19:24   ` Vasileios Amoiridis
2024-12-02 19:39     ` Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2024-11-28 23:24 [PATCH v1 " Vasileios Amoiridis
2024-11-28 23:24 ` [PATCH v1 1/3] dt-bindings: iio: pressure: bmp085: Add SPI interface Vasileios Amoiridis
2024-11-29  7:22   ` Krzysztof Kozlowski
2024-11-29 23:51     ` Vasileios Amoiridis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z09jWONoaH3R3XSX@vamoirid-laptop \
    --to=vassilisamir@gmail.com \
    --cc=ajarizzo@gmail.com \
    --cc=ak@it-klinger.de \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox