public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Varadarajan Narayanan <quic_varada@quicinc.com>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: <bhelgaas@google.com>, <lpieralisi@kernel.org>, <kw@linux.com>,
	<robh@kernel.org>, <krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<vkoul@kernel.org>, <kishon@kernel.org>, <andersson@kernel.org>,
	<konradybcio@kernel.org>, <p.zabel@pengutronix.de>,
	<quic_nsekar@quicinc.com>, <dmitry.baryshkov@linaro.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-pci@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-phy@lists.infradead.org>,
	Praveenkumar I <quic_ipkumar@quicinc.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 4/5] arm64: dts: qcom: ipq5332: Add PCIe related nodes
Date: Wed, 22 Jan 2025 10:35:40 +0530	[thread overview]
Message-ID: <Z5B8pGD/h0h79ykb@hu-varada-blr.qualcomm.com> (raw)
In-Reply-To: <Z4Cjzc5nyOv0R9tS@hu-varada-blr.qualcomm.com>

Manivannan,

	[ . . . ]
> > > +			phys = <&pcie1_phy>;
> > > +			phy-names = "pciephy";
> > > +
> > > +			interconnects = <&gcc MASTER_SNOC_PCIE3_2_M &gcc SLAVE_SNOC_PCIE3_2_M>,
> > > +					<&gcc MASTER_ANOC_PCIE3_2_S &gcc SLAVE_ANOC_PCIE3_2_S>;
> > > +			interconnect-names = "pcie-mem", "cpu-pcie";
> >
> > Can you check if the controller supports cache coherency? If so, you need to add
> > 'dma-coherent'.
>
> Ok.

Confirmed with h/w person. The controller doesn't support cache coherance.

Thanks
Varada

  reply	other threads:[~2025-01-22  5:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-02 11:30 [PATCH v5 0/5] Add PCIe support for Qualcomm IPQ5332 Varadarajan Narayanan
2025-01-02 11:30 ` [PATCH v5 1/5] dt-bindings: phy: qcom,uniphy-pcie: Document PCIe uniphy Varadarajan Narayanan
2025-01-03  7:42   ` Krzysztof Kozlowski
2025-01-02 11:30 ` [PATCH v5 2/5] phy: qcom: Introduce PCIe UNIPHY 28LP driver Varadarajan Narayanan
2025-01-03  5:48   ` Dmitry Baryshkov
2025-01-03  7:43     ` Krzysztof Kozlowski
2025-01-02 11:30 ` [PATCH v5 3/5] dt-bindings: PCI: qcom: Document the IPQ5332 PCIe controller Varadarajan Narayanan
2025-01-03  7:45   ` Krzysztof Kozlowski
2025-01-07 11:05     ` Varadarajan Narayanan
2025-01-08  7:19       ` Krzysztof Kozlowski
2025-01-08  7:40         ` Varadarajan Narayanan
2025-01-08 10:10           ` Krzysztof Kozlowski
2025-01-02 11:30 ` [PATCH v5 4/5] arm64: dts: qcom: ipq5332: Add PCIe related nodes Varadarajan Narayanan
2025-01-08 13:22   ` Manivannan Sadhasivam
2025-01-10  4:36     ` Varadarajan Narayanan
2025-01-22  5:05       ` Varadarajan Narayanan [this message]
2025-01-08 18:32   ` Bjorn Helgaas
2025-01-15  7:58     ` Varadarajan Narayanan
2025-01-17 20:27       ` Bjorn Helgaas
2025-01-02 11:30 ` [PATCH v5 5/5] arm64: dts: qcom: ipq5332-rdp441: Enable PCIe phys and controllers Varadarajan Narayanan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z5B8pGD/h0h79ykb@hu-varada-blr.qualcomm.com \
    --to=quic_varada@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=kishon@kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kw@linux.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=lpieralisi@kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=quic_ipkumar@quicinc.com \
    --cc=quic_nsekar@quicinc.com \
    --cc=robh@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox