* [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo [not found] <20230330095941.428122-1-francesco@dolcini.it> @ 2023-03-30 9:59 ` Francesco Dolcini 2023-03-31 8:41 ` Krzysztof Kozlowski 2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Francesco Dolcini 2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode Francesco Dolcini 2 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2023-03-30 9:59 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel From: Francesco Dolcini <francesco.dolcini@toradex.com> Correct Toshiba spelling. Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index 0b6f5bef120f..d6dac186ac59 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge +title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge maintainers: - Peter Ujfalusi <peter.ujfalusi@ti.com> -- 2.25.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo 2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo Francesco Dolcini @ 2023-03-31 8:41 ` Krzysztof Kozlowski 0 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2023-03-31 8:41 UTC (permalink / raw) To: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On 30/03/2023 11:59, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Correct Toshiba spelling. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 [not found] <20230330095941.428122-1-francesco@dolcini.it> 2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo Francesco Dolcini @ 2023-03-30 9:59 ` Francesco Dolcini 2023-03-31 8:42 ` Krzysztof Kozlowski 2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode Francesco Dolcini 2 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2023-03-30 9:59 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel From: Francesco Dolcini <francesco.dolcini@toradex.com> Add TC9594, from the software point of view this is identical to TC358768 with the main difference being automotive qualified. Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index d6dac186ac59..8f22093b61ae 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -4,19 +4,20 @@ $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge maintainers: - Peter Ujfalusi <peter.ujfalusi@ti.com> description: | - The TC358768/TC358778 is bridge device which converts RGB to DSI. + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. properties: compatible: enum: - toshiba,tc358768 - toshiba,tc358778 + - toshiba,tc9594 reg: maxItems: 1 -- 2.25.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Francesco Dolcini @ 2023-03-31 8:42 ` Krzysztof Kozlowski 2023-03-31 9:30 ` Francesco Dolcini 0 siblings, 1 reply; 13+ messages in thread From: Krzysztof Kozlowski @ 2023-03-31 8:42 UTC (permalink / raw) To: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On 30/03/2023 11:59, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add TC9594, from the software point of view this is identical to > TC358768 with the main difference being automotive qualified. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > index d6dac186ac59..8f22093b61ae 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > @@ -4,19 +4,20 @@ > $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge > +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge > > maintainers: > - Peter Ujfalusi <peter.ujfalusi@ti.com> > > description: | > - The TC358768/TC358778 is bridge device which converts RGB to DSI. > + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. > > properties: > compatible: > enum: > - toshiba,tc358768 > - toshiba,tc358778 > + - toshiba,tc9594 If it is the same, why they are not compatible? I got only three patches out of six, thus I cannot check by myself. Please explain. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 2023-03-31 8:42 ` Krzysztof Kozlowski @ 2023-03-31 9:30 ` Francesco Dolcini 2023-03-31 9:33 ` Krzysztof Kozlowski 0 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2023-03-31 9:30 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: > On 30/03/2023 11:59, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Add TC9594, from the software point of view this is identical to > > TC358768 with the main difference being automotive qualified. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index d6dac186ac59..8f22093b61ae 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -4,19 +4,20 @@ > > $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# > > $schema: http://devicetree.org/meta-schemas/core.yaml# > > > > -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge > > +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge > > > > maintainers: > > - Peter Ujfalusi <peter.ujfalusi@ti.com> > > > > description: | > > - The TC358768/TC358778 is bridge device which converts RGB to DSI. > > + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. > > > > properties: > > compatible: > > enum: > > - toshiba,tc358768 > > - toshiba,tc358778 > > + - toshiba,tc9594 > > If it is the same, why they are not compatible? I assume I am not understanding something very basic ... The register description and SW functionality of all these 3 parts is identical. How should be the compatible described in the DT schema in this case? > I got only three patches out of six, thus I cannot check by myself. Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ Do you want to me to send the whole series and not just the DT binding next time? Happy to do it, if you prefer. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 2023-03-31 9:30 ` Francesco Dolcini @ 2023-03-31 9:33 ` Krzysztof Kozlowski 0 siblings, 0 replies; 13+ messages in thread From: Krzysztof Kozlowski @ 2023-03-31 9:33 UTC (permalink / raw) To: Francesco Dolcini Cc: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On 31/03/2023 11:30, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:42:40AM +0200, Krzysztof Kozlowski wrote: >> On 30/03/2023 11:59, Francesco Dolcini wrote: >>> From: Francesco Dolcini <francesco.dolcini@toradex.com> >>> >>> Add TC9594, from the software point of view this is identical to >>> TC358768 with the main difference being automotive qualified. >>> >>> Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> >>> --- >>> .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- >>> 1 file changed, 3 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> index d6dac186ac59..8f22093b61ae 100644 >>> --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml >>> @@ -4,19 +4,20 @@ >>> $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# >>> $schema: http://devicetree.org/meta-schemas/core.yaml# >>> >>> -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge >>> +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge >>> >>> maintainers: >>> - Peter Ujfalusi <peter.ujfalusi@ti.com> >>> >>> description: | >>> - The TC358768/TC358778 is bridge device which converts RGB to DSI. >>> + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. >>> >>> properties: >>> compatible: >>> enum: >>> - toshiba,tc358768 >>> - toshiba,tc358778 >>> + - toshiba,tc9594 >> >> If it is the same, why they are not compatible? > > I assume I am not understanding something very basic ... > > The register description and SW functionality of all these 3 parts is > identical. > > How should be the compatible described in the DT schema in this case? Look at any board compatibles for example. > > >> I got only three patches out of six, thus I cannot check by myself. > > Here the whole series: https://lore.kernel.org/all/20230330095941.428122-1-francesco@dolcini.it/ > > Do you want to me to send the whole series and not just the DT binding > next time? Happy to do it, if you prefer. So NAK on 4th patch. Don't grow device ID tables needlessly. Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode [not found] <20230330095941.428122-1-francesco@dolcini.it> 2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo Francesco Dolcini 2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Francesco Dolcini @ 2023-03-30 9:59 ` Francesco Dolcini 2023-03-31 8:48 ` Krzysztof Kozlowski 2 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2023-03-30 9:59 UTC (permalink / raw) To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel From: Francesco Dolcini <francesco.dolcini@toradex.com> Add new toshiba,input-rgb-mode property to describe the actual signal connection on the parallel RGB input interface. Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> --- .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index 8f22093b61ae..2638121a2223 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -42,6 +42,21 @@ properties: clock-names: const: refclk + toshiba,input-rgb-mode: + description: | + Parallel Input (RGB) Mode. + + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet + and in the table below. + + 0 = R[7:0], G[7:0], B[7:0] + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] + 2 = 8’b0, R[4:0], G[5:0], B[4:0] + + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [ 0, 1, 2 ] + default: 0 + ports: $ref: /schemas/graph.yaml#/properties/ports -- 2.25.1 ^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode Francesco Dolcini @ 2023-03-31 8:48 ` Krzysztof Kozlowski 2023-03-31 9:40 ` Francesco Dolcini 0 siblings, 1 reply; 13+ messages in thread From: Krzysztof Kozlowski @ 2023-03-31 8:48 UTC (permalink / raw) To: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree Cc: Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On 30/03/2023 11:59, Francesco Dolcini wrote: > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > Add new toshiba,input-rgb-mode property to describe the actual signal > connection on the parallel RGB input interface. > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > --- > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > index 8f22093b61ae..2638121a2223 100644 > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > @@ -42,6 +42,21 @@ properties: > clock-names: > const: refclk > > + toshiba,input-rgb-mode: > + description: | > + Parallel Input (RGB) Mode. > + > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > + and in the table below. > + > + 0 = R[7:0], G[7:0], B[7:0] RGB888? > + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] > + 2 = 8’b0, R[4:0], G[5:0], B[4:0] Isn't this RGB565? Don't we have already properties like this? e.g. colorspace? Best regards, Krzysztof ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-03-31 8:48 ` Krzysztof Kozlowski @ 2023-03-31 9:40 ` Francesco Dolcini 2023-04-03 21:01 ` Rob Herring 0 siblings, 1 reply; 13+ messages in thread From: Francesco Dolcini @ 2023-03-31 9:40 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Rob Herring, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On Fri, Mar 31, 2023 at 10:48:15AM +0200, Krzysztof Kozlowski wrote: > On 30/03/2023 11:59, Francesco Dolcini wrote: > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > Add new toshiba,input-rgb-mode property to describe the actual signal > > connection on the parallel RGB input interface. > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > --- > > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > index 8f22093b61ae..2638121a2223 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > @@ -42,6 +42,21 @@ properties: > > clock-names: > > const: refclk > > > > + toshiba,input-rgb-mode: > > + description: | > > + Parallel Input (RGB) Mode. > > + > > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > > + and in the table below. > > + > > + 0 = R[7:0], G[7:0], B[7:0] > > RGB888? Or anything else - like a RGB666 - just connecting to GND the unused pins. > > + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] > > + 2 = 8’b0, R[4:0], G[5:0], B[4:0] > > Isn't this RGB565? > > Don't we have already properties like this? e.g. colorspace? It's not really the colorspace this property. tc358768 is a parallel RGB to DSI bridge, it has 24 bit parallel input line. The way this lines are connected is configurable with this parameter, if you look at mode 0 and 1 they all allow to have a RGB888 or a RGB666 or a RGB565 mapping. This just configure some internal mux, it's not strictly about the RGB mode. The description for mode 2 was copied from the datasheet, and I agree this is really about having a RGB565 on the first 16 parallel input pins. Honestly I do not know what is going to happen with PD[23-16] if they are not connected to GND, given that the component does not know the parallel input bus width it might as well sample those pins in some un-documented way. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-03-31 9:40 ` Francesco Dolcini @ 2023-04-03 21:01 ` Rob Herring 2023-04-03 21:10 ` Francesco Dolcini ` (2 more replies) 0 siblings, 3 replies; 13+ messages in thread From: Rob Herring @ 2023-04-03 21:01 UTC (permalink / raw) To: Francesco Dolcini Cc: Krzysztof Kozlowski, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On Fri, Mar 31, 2023 at 11:40:01AM +0200, Francesco Dolcini wrote: > On Fri, Mar 31, 2023 at 10:48:15AM +0200, Krzysztof Kozlowski wrote: > > On 30/03/2023 11:59, Francesco Dolcini wrote: > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > Add new toshiba,input-rgb-mode property to describe the actual signal > > > connection on the parallel RGB input interface. > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > --- > > > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > > > 1 file changed, 15 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > index 8f22093b61ae..2638121a2223 100644 > > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > @@ -42,6 +42,21 @@ properties: > > > clock-names: > > > const: refclk > > > > > > + toshiba,input-rgb-mode: > > > + description: | > > > + Parallel Input (RGB) Mode. > > > + > > > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > > > + and in the table below. > > > + > > > + 0 = R[7:0], G[7:0], B[7:0] > > > > RGB888? > > Or anything else - like a RGB666 - just connecting to GND the unused > pins. If the bridge is configured for RGB666, then that's fine. If not, the unused pins should be driven with either the MSB of each component. Otherwise, you'd can't fully saturate the colors. > > > + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] > > > + 2 = 8’b0, R[4:0], G[5:0], B[4:0] > > > > Isn't this RGB565? > > > > Don't we have already properties like this? e.g. colorspace? > > It's not really the colorspace this property. > > tc358768 is a parallel RGB to DSI bridge, it has 24 bit parallel input > line. > > The way this lines are connected is configurable with this parameter, if you > look at mode 0 and 1 they all allow to have a RGB888 or a RGB666 or a > RGB565 mapping. This just configure some internal mux, it's not strictly > about the RGB mode. This is the same as other cases. There's a need for describing the interface. It keeps coming up and I keep saying to go create something common. Rob ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-04-03 21:01 ` Rob Herring @ 2023-04-03 21:10 ` Francesco Dolcini 2023-04-03 21:20 ` Francesco Dolcini 2023-04-14 8:42 ` Francesco Dolcini 2 siblings, 0 replies; 13+ messages in thread From: Francesco Dolcini @ 2023-04-03 21:10 UTC (permalink / raw) To: Rob Herring Cc: Francesco Dolcini, Krzysztof Kozlowski, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On Mon, Apr 03, 2023 at 04:01:17PM -0500, Rob Herring wrote: > On Fri, Mar 31, 2023 at 11:40:01AM +0200, Francesco Dolcini wrote: > > On Fri, Mar 31, 2023 at 10:48:15AM +0200, Krzysztof Kozlowski wrote: > > > On 30/03/2023 11:59, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Add new toshiba,input-rgb-mode property to describe the actual signal > > > > connection on the parallel RGB input interface. > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > --- > > > > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > index 8f22093b61ae..2638121a2223 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > @@ -42,6 +42,21 @@ properties: > > > > clock-names: > > > > const: refclk > > > > > > > > + toshiba,input-rgb-mode: > > > > + description: | > > > > + Parallel Input (RGB) Mode. > > > > + > > > > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > > > > + and in the table below. > > > > + > > > > + 0 = R[7:0], G[7:0], B[7:0] > > > > > > RGB888? > > > > Or anything else - like a RGB666 - just connecting to GND the unused > > pins. > > If the bridge is configured for RGB666, then that's fine. If not, the > unused pins should be driven with either the MSB of each component. > Otherwise, you'd can't fully saturate the colors. > > > > + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] > > > > + 2 = 8’b0, R[4:0], G[5:0], B[4:0] > > > > > > Isn't this RGB565? > > > > > > Don't we have already properties like this? e.g. colorspace? > > > > It's not really the colorspace this property. > > > > tc358768 is a parallel RGB to DSI bridge, it has 24 bit parallel input > > line. > > > > The way this lines are connected is configurable with this parameter, if you > > look at mode 0 and 1 they all allow to have a RGB888 or a RGB666 or a > > RGB565 mapping. This just configure some internal mux, it's not strictly > > about the RGB mode. > > This is the same as other cases. There's a need for describing the > interface. It keeps coming up and I keep saying to go create something > common. I am not aware of other discussion on the topic, do you have any pointer I can look at? What I'd like to re-iterate here once more is that this configuration is about how the external 24-bit parallel RGB lines are mapped withing this bridge. It's not mapping the linux media bus format (e.g. not MEDIA_BUS_FMT_RBG888_1X24 or alike). This bridge allow for a limited set of combination (3) as described in this binding. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-04-03 21:01 ` Rob Herring 2023-04-03 21:10 ` Francesco Dolcini @ 2023-04-03 21:20 ` Francesco Dolcini 2023-04-14 8:42 ` Francesco Dolcini 2 siblings, 0 replies; 13+ messages in thread From: Francesco Dolcini @ 2023-04-03 21:20 UTC (permalink / raw) To: Rob Herring Cc: Francesco Dolcini, Krzysztof Kozlowski, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Krzysztof Kozlowski, Peter Ujfalusi, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel On Mon, Apr 03, 2023 at 04:01:17PM -0500, Rob Herring wrote: > On Fri, Mar 31, 2023 at 11:40:01AM +0200, Francesco Dolcini wrote: > > On Fri, Mar 31, 2023 at 10:48:15AM +0200, Krzysztof Kozlowski wrote: > > > On 30/03/2023 11:59, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Add new toshiba,input-rgb-mode property to describe the actual signal > > > > connection on the parallel RGB input interface. > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > --- > > > > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > index 8f22093b61ae..2638121a2223 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > @@ -42,6 +42,21 @@ properties: > > > > clock-names: > > > > const: refclk > > > > > > > > + toshiba,input-rgb-mode: > > > > + description: | > > > > + Parallel Input (RGB) Mode. > > > > + > > > > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > > > > + and in the table below. > > > > + > > > > + 0 = R[7:0], G[7:0], B[7:0] > > > > > > RGB888? > > > > Or anything else - like a RGB666 - just connecting to GND the unused > > pins. > > If the bridge is configured for RGB666, then that's fine. If not, the > unused pins should be driven with either the MSB of each component. > Otherwise, you'd can't fully saturate the colors. maybe a detail and maybe not really relevant, but this specific bridge has no know-how on the actual RGB inputs width. While I understand what you are saying here, in the end this is about the actual hardware design that can be in any way, including having pins to gnd and have the issue you just described. Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode 2023-04-03 21:01 ` Rob Herring 2023-04-03 21:10 ` Francesco Dolcini 2023-04-03 21:20 ` Francesco Dolcini @ 2023-04-14 8:42 ` Francesco Dolcini 2 siblings, 0 replies; 13+ messages in thread From: Francesco Dolcini @ 2023-04-14 8:42 UTC (permalink / raw) To: Rob Herring, Krzysztof Kozlowski Cc: Francesco Dolcini, Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart, Jonas Karlman, Jernej Skrabec, dri-devel, Krzysztof Kozlowski, devicetree, Francesco Dolcini, David Airlie, Daniel Vetter, linux-kernel Hello Rob and Krzysztof On Mon, Apr 03, 2023 at 04:01:17PM -0500, Rob Herring wrote: > On Fri, Mar 31, 2023 at 11:40:01AM +0200, Francesco Dolcini wrote: > > On Fri, Mar 31, 2023 at 10:48:15AM +0200, Krzysztof Kozlowski wrote: > > > On 30/03/2023 11:59, Francesco Dolcini wrote: > > > > From: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > > > > > Add new toshiba,input-rgb-mode property to describe the actual signal > > > > connection on the parallel RGB input interface. > > > > > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com> > > > > --- > > > > .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ > > > > 1 file changed, 15 insertions(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > index 8f22093b61ae..2638121a2223 100644 > > > > --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml > > > > @@ -42,6 +42,21 @@ properties: > > > > clock-names: > > > > const: refclk > > > > > > > > + toshiba,input-rgb-mode: > > > > + description: | > > > > + Parallel Input (RGB) Mode. > > > > + > > > > + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet > > > > + and in the table below. > > > > + > > > > + 0 = R[7:0], G[7:0], B[7:0] > > tc358768 is a parallel RGB to DSI bridge, it has 24 bit parallel input > > line. > > > > The way this lines are connected is configurable with this parameter, if you > > look at mode 0 and 1 they all allow to have a RGB888 or a RGB666 or a > > RGB565 mapping. This just configure some internal mux, it's not strictly > > about the RGB mode. > > This is the same as other cases. There's a need for describing the > interface. It keeps coming up and I keep saying to go create something > common. Rob, Krzysztof: you both had concerns on this change and I am not sure how to progress. Let me summarize my current understanding. 1. I do not think that this change is related to the media bus format topic, this is more like the internal bridge RGB pins mux configuration. This `input-rgb-mode` field I am proposing here is orthogonal to the bus format (e.g. linux media-bus-format.h). I can change the name, if we think this is the reason of the confusion, I just used something similar to the words used in the datasheet. Do we have agreement on that or not? 2. Rob asked for a generic solution, since according to him this is a recurring need. I would appreciate some pointer where to look at so I can propose something more generic. Thanks, Francesco ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2023-04-14 8:43 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230330095941.428122-1-francesco@dolcini.it>
2023-03-30 9:59 ` [PATCH v1 1/6] dt-bindings: display: bridge: toshiba,tc358768: Fix typo Francesco Dolcini
2023-03-31 8:41 ` Krzysztof Kozlowski
2023-03-30 9:59 ` [PATCH v1 2/6] dt-bindings: display: bridge: toshiba,tc358768: Add TC9594 Francesco Dolcini
2023-03-31 8:42 ` Krzysztof Kozlowski
2023-03-31 9:30 ` Francesco Dolcini
2023-03-31 9:33 ` Krzysztof Kozlowski
2023-03-30 9:59 ` [PATCH v1 3/6] dt-bindings: display: bridge: toshiba,tc358768: add parallel input mode Francesco Dolcini
2023-03-31 8:48 ` Krzysztof Kozlowski
2023-03-31 9:40 ` Francesco Dolcini
2023-04-03 21:01 ` Rob Herring
2023-04-03 21:10 ` Francesco Dolcini
2023-04-03 21:20 ` Francesco Dolcini
2023-04-14 8:42 ` Francesco Dolcini
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox