* [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example
@ 2023-12-05 8:48 Krzysztof Kozlowski
2023-12-05 11:01 ` Sakari Ailus
0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-05 8:48 UTC (permalink / raw)
To: Sakari Ailus, Mauro Carvalho Chehab, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Maxime Ripard,
Laurent Pinchart, linux-media, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
Bindings and Linux driver require two link frequencies, so correct the
example:
ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
index 57f5e48fd8e0..bd1a55d767e7 100644
--- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
@@ -126,7 +126,7 @@ examples:
wcam_out: endpoint {
remote-endpoint = <&mipi_in_wcam>;
data-lanes = <1 2 3 4>;
- link-frequencies = /bits/ 64 <360000000>;
+ link-frequencies = /bits/ 64 <360000000 180000000>;
};
};
};
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example
2023-12-05 8:48 [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example Krzysztof Kozlowski
@ 2023-12-05 11:01 ` Sakari Ailus
2023-12-05 11:43 ` Sakari Ailus
2023-12-07 13:59 ` Krzysztof Kozlowski
0 siblings, 2 replies; 5+ messages in thread
From: Sakari Ailus @ 2023-12-05 11:01 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Ripard, Laurent Pinchart, linux-media,
devicetree, linux-kernel
Hi Krzysztof,
Thanks for the patch.
On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
> Bindings and Linux driver require two link frequencies, so correct the
> example:
>
> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
>
> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> index 57f5e48fd8e0..bd1a55d767e7 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> @@ -126,7 +126,7 @@ examples:
> wcam_out: endpoint {
> remote-endpoint = <&mipi_in_wcam>;
> data-lanes = <1 2 3 4>;
> - link-frequencies = /bits/ 64 <360000000>;
> + link-frequencies = /bits/ 64 <360000000 180000000>;
There indeed seems to be a problem with the example as far as the bindings
are concerned but the primary issue seems to be in the bindings. Both of
these frequencies have significance from driver point of view only while
the device itself supports a (wider) range.
How about removing maxItems and items from the bindings instead?
> };
> };
> };
--
Kind regards,
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example
2023-12-05 11:01 ` Sakari Ailus
@ 2023-12-05 11:43 ` Sakari Ailus
2023-12-07 13:59 ` Krzysztof Kozlowski
2023-12-07 13:59 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: Sakari Ailus @ 2023-12-05 11:43 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Ripard, Laurent Pinchart, linux-media,
devicetree, linux-kernel
On Tue, Dec 05, 2023 at 11:01:41AM +0000, Sakari Ailus wrote:
> Hi Krzysztof,
>
> Thanks for the patch.
>
> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
> > Bindings and Linux driver require two link frequencies, so correct the
> > example:
> >
> > ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
> >
> > Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> > ---
> > Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > index 57f5e48fd8e0..bd1a55d767e7 100644
> > --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
> > @@ -126,7 +126,7 @@ examples:
> > wcam_out: endpoint {
> > remote-endpoint = <&mipi_in_wcam>;
> > data-lanes = <1 2 3 4>;
> > - link-frequencies = /bits/ 64 <360000000>;
> > + link-frequencies = /bits/ 64 <360000000 180000000>;
>
> There indeed seems to be a problem with the example as far as the bindings
> are concerned but the primary issue seems to be in the bindings. Both of
> these frequencies have significance from driver point of view only while
> the device itself supports a (wider) range.
>
> How about removing maxItems and items from the bindings instead?
There's also a similar issue with lanes: 1, 2 and 4 are supported.
--
Sakari Ailus
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example
2023-12-05 11:43 ` Sakari Ailus
@ 2023-12-07 13:59 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-07 13:59 UTC (permalink / raw)
To: Sakari Ailus
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Ripard, Laurent Pinchart, linux-media,
devicetree, linux-kernel
On 05/12/2023 12:43, Sakari Ailus wrote:
> On Tue, Dec 05, 2023 at 11:01:41AM +0000, Sakari Ailus wrote:
>> Hi Krzysztof,
>>
>> Thanks for the patch.
>>
>> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
>>> Bindings and Linux driver require two link frequencies, so correct the
>>> example:
>>>
>>> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
>>>
>>> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> index 57f5e48fd8e0..bd1a55d767e7 100644
>>> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>>> @@ -126,7 +126,7 @@ examples:
>>> wcam_out: endpoint {
>>> remote-endpoint = <&mipi_in_wcam>;
>>> data-lanes = <1 2 3 4>;
>>> - link-frequencies = /bits/ 64 <360000000>;
>>> + link-frequencies = /bits/ 64 <360000000 180000000>;
>>
>> There indeed seems to be a problem with the example as far as the bindings
>> are concerned but the primary issue seems to be in the bindings. Both of
>> these frequencies have significance from driver point of view only while
>> the device itself supports a (wider) range.
>>
>> How about removing maxItems and items from the bindings instead?
>
> There's also a similar issue with lanes: 1, 2 and 4 are supported.
ack
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example
2023-12-05 11:01 ` Sakari Ailus
2023-12-05 11:43 ` Sakari Ailus
@ 2023-12-07 13:59 ` Krzysztof Kozlowski
1 sibling, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-07 13:59 UTC (permalink / raw)
To: Sakari Ailus
Cc: Mauro Carvalho Chehab, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Maxime Ripard, Laurent Pinchart, linux-media,
devicetree, linux-kernel
On 05/12/2023 12:01, Sakari Ailus wrote:
> Hi Krzysztof,
>
> Thanks for the patch.
>
> On Tue, Dec 05, 2023 at 09:48:35AM +0100, Krzysztof Kozlowski wrote:
>> Bindings and Linux driver require two link frequencies, so correct the
>> example:
>>
>> ov8856.example.dtb: camera@10: port:endpoint:link-frequencies:0: [360000000] is too short
>>
>> Fixes: 066a94e28a23 ("media: dt-bindings: media: Use graph and video-interfaces schemas")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>> Documentation/devicetree/bindings/media/i2c/ov8856.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> index 57f5e48fd8e0..bd1a55d767e7 100644
>> --- a/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> +++ b/Documentation/devicetree/bindings/media/i2c/ov8856.yaml
>> @@ -126,7 +126,7 @@ examples:
>> wcam_out: endpoint {
>> remote-endpoint = <&mipi_in_wcam>;
>> data-lanes = <1 2 3 4>;
>> - link-frequencies = /bits/ 64 <360000000>;
>> + link-frequencies = /bits/ 64 <360000000 180000000>;
>
> There indeed seems to be a problem with the example as far as the bindings
> are concerned but the primary issue seems to be in the bindings. Both of
> these frequencies have significance from driver point of view only while
> the device itself supports a (wider) range.
>
> How about removing maxItems and items from the bindings instead?
Yeah, it makes sense.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-12-07 13:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-05 8:48 [PATCH] media: dt-bindings: ov8856: add missing second link frequency in example Krzysztof Kozlowski
2023-12-05 11:01 ` Sakari Ailus
2023-12-05 11:43 ` Sakari Ailus
2023-12-07 13:59 ` Krzysztof Kozlowski
2023-12-07 13:59 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox