public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 4/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe LEDs
Date: Fri, 11 Apr 2025 13:40:39 +0200	[thread overview]
Message-ID: <Z_j_t92QksnSjg-c@shikoro> (raw)
In-Reply-To: <CAMuHMdWO0662Qk7BxgMW8nr9OpP-mjPSxYKT6Z-pp+syacrtOg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]


> These are called LED1-LED8 in the Board Setup Notes.

Oh, where? I have a version from "Dec 14, 2020" which only calls them
Software-LEDs or "Port0 BitX". Schematics call them DBG_LEDx. I don't
care much. The "db" board has a "USER LED2", as long as we don't
conflict with that name, I am fine.

>     color = <LED_COLOR_ID_ORANGE>;

Hmmm, they are definitely GREEN here.

>     function = LED_FUNCTION_INDICATOR;

LED_FUNCTION_PROGRAMMING?

> Perhaps you want the first one to be a heartbeat?
> 
>     linux,default-trigger = "heartbeat";

I recently removed a default-trigger on another board because it was in
the way. So, I'd rather not.

Phew, starting with the PHY LEDs on this board, didn't know LED were so
troublesome...

Shall I resend only this patch and rebased on the keyboard patch? Or
resend the both?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2025-04-11 11:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-28 15:31 [PATCH 0/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: enable I2C infrastructure Wolfram Sang
2025-03-28 15:31 ` [PATCH 1/5] ARM: dts: renesas: r9a06g032: Describe I2C controllers Wolfram Sang
2025-04-11  7:18   ` Geert Uytterhoeven
2025-03-28 15:31 ` [PATCH 2/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe I2C bus Wolfram Sang
2025-03-29  9:13   ` Sergey Shtylyov
2025-03-29  9:37     ` Wolfram Sang
2025-04-11  7:35   ` Geert Uytterhoeven
2025-03-28 15:31 ` [PATCH 3/5] ARM: dts: renesas: r9a06g032-rzn1d400-eb: " Wolfram Sang
2025-04-11  9:22   ` Geert Uytterhoeven
2025-03-28 15:31 ` [PATCH 4/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe LEDs Wolfram Sang
2025-04-11  8:59   ` Geert Uytterhoeven
2025-04-11 11:40     ` Wolfram Sang [this message]
2025-04-14 13:41       ` Geert Uytterhoeven
2025-03-28 15:31 ` [PATCH 5/5] ARM: dts: renesas: r9a06g032-rzn1d400-db: describe keys Wolfram Sang
2025-04-11  9:02   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z_j_t92QksnSjg-c@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox