[PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: correct LAN LED nodes

[PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: correct LAN LED nodes

[Wolfram Sang]

This board only connects two LEDs instead of three. Also, give them
descriptions to avoid namespace collusions.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 .../dts/renesas/r9a06g032-rzn1d400-eb.dts     | 23 ++++++++++++-------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
index ee875902a75c..068563d6047b 100644
--- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
+++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
@@ -6,6 +6,7 @@
  *
  */
 
+#include <dt-bindings/leds/common.h>
 #include "r9a06g032-rzn1d400-db.dts"
 
 / {
@@ -102,15 +103,18 @@ switch0phy1: ethernet-phy@1 {
 			leds {
 				#address-cells = <1>;
 				#size-cells = <0>;
-
 				led@0 {
 					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_LAN;
+					default-state = "keep";
 				};
+
 				led@1 {
 					reg = <1>;
-				};
-				led@2 {
-					reg = <2>;
+					color = <LED_COLOR_ID_RED>;
+					function = LED_FUNCTION_ACTIVITY;
+					default-state = "keep";
 				};
 			};
 		};
@@ -120,15 +124,18 @@ switch0phy10: ethernet-phy@10 {
 			leds {
 				#address-cells = <1>;
 				#size-cells = <0>;
-
 				led@0 {
 					reg = <0>;
+					color = <LED_COLOR_ID_GREEN>;
+					function = LED_FUNCTION_LAN;
+					default-state = "keep";
 				};
+
 				led@1 {
 					reg = <1>;
-				};
-				led@2 {
-					reg = <2>;
+					color = <LED_COLOR_ID_RED>;
+					function = LED_FUNCTION_ACTIVITY;
+					default-state = "keep";
 				};
 			};
 		};
-- 
2.47.2

Re: [PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: correct LAN LED nodes

[Geert Uytterhoeven]

Hi Wolfram,

On Fri, 11 Apr 2025 at 11:54, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> This board only connects two LEDs instead of three. Also, give them
> descriptions to avoid namespace collusions.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Thanks for your patch!

> --- a/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> +++ b/arch/arm/boot/dts/renesas/r9a06g032-rzn1d400-eb.dts
> @@ -6,6 +6,7 @@
>   *
>   */
>
> +#include <dt-bindings/leds/common.h>
>  #include "r9a06g032-rzn1d400-db.dts"
>
>  / {
> @@ -102,15 +103,18 @@ switch0phy1: ethernet-phy@1 {
>                         leds {
>                                 #address-cells = <1>;
>                                 #size-cells = <0>;
> -
>                                 led@0 {
>                                         reg = <0>;
> +                                       color = <LED_COLOR_ID_GREEN>;
> +                                       function = LED_FUNCTION_LAN;
> +                                       default-state = "keep";
>                                 };
> +
>                                 led@1 {
>                                         reg = <1>;
> -                               };
> -                               led@2 {
> -                                       reg = <2>;
> +                                       color = <LED_COLOR_ID_RED>;

Can you please confirm they are RED and not ORANGE, as documented in
the schematics?

> +                                       function = LED_FUNCTION_ACTIVITY;
> +                                       default-state = "keep";
>                                 };
>                         };
>                 };

LGTM, will squash into "[PATCH v4] ARM: dts: r9a06g032: add
r9a06g032-rzn1d400-eb board device-tree" when the above is confirmed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] ARM: dts: renesas: r9a06g032-rzn1d400-eb: correct LAN LED nodes

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 367 bytes --]


> > +                                       color = <LED_COLOR_ID_RED>;
> 
> Can you please confirm they are RED and not ORANGE, as documented in
> the schematics?

ORANGE is also fine. For me, it looked like 'light' RED + GREEN = orange
when both are active. But you could also say: 'red-ish' ORANGE + GREEN =
light orange. Let's go with the schematics.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]