public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephan Gerhold <stephan@gerhold.net>
To: Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8155p-adp: lower min volt for L13C regulator
Date: Fri, 12 Apr 2024 21:53:16 +0200	[thread overview]
Message-ID: <ZhmRJPAZUSlc1CSH@gerhold.net> (raw)
In-Reply-To: <20240412190310.1647893-2-volodymyr_babchuk@epam.com>

On Fri, Apr 12, 2024 at 07:03:26PM +0000, Volodymyr Babchuk wrote:
> Voltage regulator L13C is used by SD card IO interface. In order to
> support UHS modes, IO interface voltage needs to be set to 1.8V. This
> patch extends minimum voltage range of L13C regulator to allow this.
> 

I think this one also deserves a Fixes and stable tag. One could argue
that enabling UHS modes is a new "feature" but I would say the original
commit just missed setting the correct voltages with the intended use
case. I doubt limiting to high speed was intended.

Maybe also add a Suggested-by tag from myself:

Fixes: 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD card")
Cc: stable@vger.kernel.org
Suggested-by: Stephan Gerhold <stephan@gerhold.net>

I believe you do not need to resend just to add these tags, the b4 tool
should pick them up while applying. It looks like this might not work
for the Cc: stable tag though...

Thanks,
Stephan

> Signed-off-by: Volodymyr Babchuk <volodymyr_babchuk@epam.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> index b2cf2c988336c..9e9c7f81096bb 100644
> --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts
> @@ -283,7 +283,7 @@ vreg_l12c_1p808: ldo12 {
>  
>  		vreg_l13c_2p96: ldo13 {
>  			regulator-name = "vreg_l13c_2p96";
> -			regulator-min-microvolt = <2504000>;
> +			regulator-min-microvolt = <1800000>;
>  			regulator-max-microvolt = <2960000>;
>  			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>  		};
> -- 
> 2.44.0

  reply	other threads:[~2024-04-12 19:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 19:03 [PATCH v3 1/2] arm64: dts: qcom: sa8155p-adp: fix SDHC2 CD pin configuration Volodymyr Babchuk
2024-04-12 19:03 ` [PATCH v3 2/2] arm64: dts: qcom: sa8155p-adp: lower min volt for L13C regulator Volodymyr Babchuk
2024-04-12 19:53   ` Stephan Gerhold [this message]
2024-04-12 20:09     ` Volodymyr Babchuk
2024-04-12 19:57 ` [PATCH v3 1/2] arm64: dts: qcom: sa8155p-adp: fix SDHC2 CD pin configuration Stephan Gerhold
2024-04-21 16:07 ` (subset) " Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZhmRJPAZUSlc1CSH@gerhold.net \
    --to=stephan@gerhold.net \
    --cc=Volodymyr_Babchuk@epam.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox