public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@iki.fi>
To: Julien Massot <julien.massot@collabora.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	kernel@collabora.com, linux-kernel@vger.kernel.org,
	mchehab@kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 1/4] dt-bindings: media: add Maxim MAX96717 GMSL2 Serializer
Date: Tue, 23 Apr 2024 21:43:22 +0000	[thread overview]
Message-ID: <Zigrei9JB9L2XUEO@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <f5a178b9-2eeb-4737-a051-b43cde9fae20@collabora.com>

Hi Julien,

On Tue, Apr 23, 2024 at 03:36:39PM +0200, Julien Massot wrote:
> > > +            properties:
> > > +              data-lanes:
> > > +                minItems: 1
> > > +                maxItems: 4
> > > +
> > > +              lane-polarities:
> > > +                minItems: 1
> > > +                maxItems: 5
> > > +
> > > +              bus-type:
> > > +                enum:
> > > +                  - 1 # MEDIA_BUS_TYPE_CSI2_CPHY
> > > +                  - 4 # MEDIA_BUS_TYPE_CSI2_DPHY
> > 
> > Now that you have C-PHY here, does the hardware support data line order
> > mapping? Just wondering. The bindings can be added without that and support
> > added later on---that's what the video-interfaces.yaml is currently
> > missing.
> > 
> > lane-polarities is only valid for D-PHY. What about the data-lanes, the
> > maximum is probably different for C-PHY?
> My mistake here; MAX96717 doesn't support C-PHY; I think I was confused by
> some of the schemas implying a deserializer with C-PHY support.
> I will drop the bus-type property in v7.

Ack, thanks!

-- 
Sakari Ailus

  reply	other threads:[~2024-04-23 21:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 13:16 [PATCH v6 0/4] Add support for MAX96714/F and MAX96717/F GMSL2 ser/des Julien Massot
2024-03-25 13:16 ` [PATCH v6 1/4] dt-bindings: media: add Maxim MAX96717 GMSL2 Serializer Julien Massot
2024-03-25 18:17   ` Conor Dooley
2024-04-12 11:10   ` Sakari Ailus
2024-04-23 13:36     ` Julien Massot
2024-04-23 21:43       ` Sakari Ailus [this message]
2024-03-25 13:16 ` [PATCH v6 2/4] dt-bindings: media: add Maxim MAX96714 GMSL2 Deserializer Julien Massot
2024-03-25 18:41   ` Conor Dooley
2024-03-25 13:16 ` [PATCH v6 3/4] media: i2c: add MAX96717 driver Julien Massot
2024-04-12 11:23   ` Sakari Ailus
2024-04-23 13:38     ` Julien Massot
2024-03-25 13:16 ` [PATCH v6 4/4] media: i2c: add MAX96714 driver Julien Massot
2024-04-12 11:25   ` Sakari Ailus
2024-04-23 14:01     ` Julien Massot
2024-04-24  8:30       ` Sakari Ailus
2024-04-24  8:42         ` Julien Massot
2024-04-24  8:45           ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zigrei9JB9L2XUEO@valkosipuli.retiisi.eu \
    --to=sakari.ailus@iki.fi \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=julien.massot@collabora.com \
    --cc=kernel@collabora.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox