From: Sakari Ailus <sakari.ailus@iki.fi>
To: Julien Massot <julien.massot@collabora.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
kernel@collabora.com, linux-kernel@vger.kernel.org,
mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Subject: Re: [PATCH v6 4/4] media: i2c: add MAX96714 driver
Date: Wed, 24 Apr 2024 08:45:21 +0000 [thread overview]
Message-ID: <ZijGoWvyDhgpxl6X@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <9075808c-783b-4af6-a92f-2a6d3f25d225@collabora.com>
On Wed, Apr 24, 2024 at 10:42:11AM +0200, Julien Massot wrote:
> > > > > + if (!priv->pattern) {
> > > > > + if (!priv->rxport.source.sd) {
> > > > > + ret = -ENODEV;
> > > > > + goto err;
> > > > > + }
> On enable streams the check is here :)
> Streaming is not possible without a remote serializer when pattern generator
> is disabled.
Ack, it was too early in the function. Thanks.
Looking forward for v7!
--
Sakari Ailus
prev parent reply other threads:[~2024-04-24 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 13:16 [PATCH v6 0/4] Add support for MAX96714/F and MAX96717/F GMSL2 ser/des Julien Massot
2024-03-25 13:16 ` [PATCH v6 1/4] dt-bindings: media: add Maxim MAX96717 GMSL2 Serializer Julien Massot
2024-03-25 18:17 ` Conor Dooley
2024-04-12 11:10 ` Sakari Ailus
2024-04-23 13:36 ` Julien Massot
2024-04-23 21:43 ` Sakari Ailus
2024-03-25 13:16 ` [PATCH v6 2/4] dt-bindings: media: add Maxim MAX96714 GMSL2 Deserializer Julien Massot
2024-03-25 18:41 ` Conor Dooley
2024-03-25 13:16 ` [PATCH v6 3/4] media: i2c: add MAX96717 driver Julien Massot
2024-04-12 11:23 ` Sakari Ailus
2024-04-23 13:38 ` Julien Massot
2024-03-25 13:16 ` [PATCH v6 4/4] media: i2c: add MAX96714 driver Julien Massot
2024-04-12 11:25 ` Sakari Ailus
2024-04-23 14:01 ` Julien Massot
2024-04-24 8:30 ` Sakari Ailus
2024-04-24 8:42 ` Julien Massot
2024-04-24 8:45 ` Sakari Ailus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZijGoWvyDhgpxl6X@valkosipuli.retiisi.eu \
--to=sakari.ailus@iki.fi \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=julien.massot@collabora.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox