Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

[Stefan Wahren]

Hi Kryštof,

 > From: Kryštof Černý <cleverline1mc@gmail.com>
 >
 > ds2482 has a VCC pin, accepting 2.9-5.5 V.
 >
 > Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Sorry, I'm not able to reply from my chargebyte address.

I'm fine with the content of this patch, but in case you need to send a
v4 please make this the first patch of the series.

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

[PATCH v3 0/3] Add support for attaching a regulator to w1: ds2482

[Kryštof Černý via B4 Relay]

Implemented changes requested in review and retested them.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
Changes in v3:
- Switched from regulator_enable() to devm_regulator_get_enable()
- Removed obvious comments.
- Link to v2: https://lore.kernel.org/r/20241122-ds2482-add-reg-v2-0-a5a03ee74da7@gmail.com

Changes in v2:
- Removed property description
- Changed commit message of binding commit
- Link to v1: https://lore.kernel.org/r/20241115-ds2482-add-reg-v1-0-cc84b9aba126@gmail.com

---
Kryštof Černý (3):
      w1: ds2482: Add regulator support
      w1: ds2482: Fix datasheet URL
      dt-bindings: w1: ds2482: Add vcc-supply property

 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml |  2 ++
 drivers/w1/masters/ds2482.c                            | 10 +++++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
---
base-commit: 6d59cab07b8d74d0f0422b750038123334f6ecc2
change-id: 20241111-ds2482-add-reg-fe13200ad7d6

Best regards,
-- 
Kryštof Černý <cleverline1mc@gmail.com>

[PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

[Kryštof Černý via B4 Relay]

From: Kryštof Černý <cleverline1mc@gmail.com>

ds2482 has a VCC pin, accepting 2.9-5.5 V.

Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
---
 Documentation/devicetree/bindings/w1/maxim,ds2482.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
index 422becc6e1fa8d58665c5586ebdc611cd0b2c760..fe6b3f9a3f8bbd00366c3e36aad3ffa72ec1a31f 100644
--- a/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
+++ b/Documentation/devicetree/bindings/w1/maxim,ds2482.yaml
@@ -25,6 +25,8 @@ properties:
   reg:
     maxItems: 1
 
+  vcc-supply: true
+
 required:
   - compatible
   - reg

-- 
2.39.5

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

[Stefan Wahren]

Hi Kryštof,

[fix messageid]

> From: Kryštof Černý <cleverline1mc@gmail.com>
>
> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>
> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>

Sorry, I'm not able to reply from my chargebyte address.

I'm fine with the content of this patch, but in case you need to send a
v4 please make this the first patch of the series.

Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

[Kryštof Černý]

Hello Stefan,

> Hi Kryštof,
> 
> [fix messageid]
> 
>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>
>> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>>
>> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
> 
> Sorry, I'm not able to reply from my chargebyte address.
> 
> I'm fine with the content of this patch, but in case you need to send a
> v4 please make this the first patch of the series.

I will do it, could you point me to the documentation, where this is 
specified, so I can avoid similar mistakes in the future?

> Reviewed-by: Stefan Wahren <wahrenst@gmx.net>

Thank you for your reviews,
Kryštof Černý

Re: [PATCH v3 3/3] dt-bindings: w1: ds2482: Add vcc-supply property

[Krzysztof Kozlowski]

On 25/11/2024 23:39, Kryštof Černý wrote:
> Hello Stefan,
> 
>> Hi Kryštof,
>>
>> [fix messageid]
>>
>>> From: Kryštof Černý <cleverline1mc@gmail.com>
>>>
>>> ds2482 has a VCC pin, accepting 2.9-5.5 V.
>>>
>>> Signed-off-by: Kryštof Černý <cleverline1mc@gmail.com>
>>
>> Sorry, I'm not able to reply from my chargebyte address.
>>
>> I'm fine with the content of this patch, but in case you need to send a
>> v4 please make this the first patch of the series.
> 
> I will do it, could you point me to the documentation, where this is 
> specified, so I can avoid similar mistakes in the future?
First, this is common sense: all ABI documentation must come before the
user actually starts using. Otherwise the series are not bisectable -
testing commit implementing ABI will point to errors in missing ABI
documentation.

Second, doc is submitting patches in bindings directory. Please also
read writing bindings doc, in the same place.

Best regards,
Krzysztof