From: Marek Vasut <marek.vasut@mailbox.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: Marek Vasut <marek.vasut+renesas@mailbox.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
Thanh Quan <thanh.quan.xn@renesas.com>,
Conor Dooley <conor+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v1 2/2] usb: dwc3: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue
Date: Thu, 6 Aug 2026 05:28:26 +0200 [thread overview]
Message-ID: <a0b64099-11e5-46aa-aa92-32b356a6c76d@mailbox.org> (raw)
In-Reply-To: <CAMuHMdVQRJv8zoQYmgiObivaOoOBnE53mVdF3hPsJBK4bu4-Ew@mail.gmail.com>
On 8/5/26 9:53 AM, Geert Uytterhoeven wrote:
Hello Geert,
> On Wed, 5 Aug 2026 at 02:48, Thinh Nguyen <Thinh.Nguyen@synopsys.com> wrote:
>> On Tue, Jul 28, 2026, Marek Vasut wrote:
>>> --- /dev/null
>>> +++ b/drivers/usb/dwc3/dwc3-rcar-gen5.c
>
>>> +static int __maybe_unused dwc3_rcar_gen5_suspend(struct device *dev)
>>
>> Avoid using __maybe_unused. If it's not used, remove it.
>
> Whether the function is used or not depends on CONFIG_PM_SLEEP ;-)
>
>>> +static DEFINE_RUNTIME_DEV_PM_OPS(dwc3_rcar_gen5_pm_ops,
>>> + dwc3_rcar_gen5_suspend,
>>> + dwc3_rcar_gen5_resume, NULL);
>
> As DEFINE_RUNTIME_DEV_PM_OPS() uses pm_sleep_ptr()
> internally, the __maybe_unused annotations above can be removed.
The __maybe_unused is dropped and pm_ptr() added in V2, thanks !
next prev parent reply other threads:[~2026-08-06 3:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 1:14 [PATCH v1 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller Marek Vasut
2026-07-28 1:14 ` [PATCH v1 2/2] usb: dwc3: Add Renesas R-Car Gen5 DWC3 xHCI USB controller glue Marek Vasut
2026-07-28 1:34 ` sashiko-bot
2026-08-05 0:48 ` Thinh Nguyen
2026-08-05 7:53 ` Geert Uytterhoeven
2026-08-05 22:20 ` Thinh Nguyen
2026-08-06 3:28 ` Marek Vasut [this message]
2026-08-06 3:41 ` Marek Vasut
2026-07-28 1:31 ` [PATCH v1 1/2] dt-bindings: usb: dwc3: Document Renesas R-Car Gen5 DWC3 xHCI USB controller sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0b64099-11e5-46aa-aa92-32b356a6c76d@mailbox.org \
--to=marek.vasut@mailbox.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=marek.vasut+renesas@mailbox.org \
--cc=robh@kernel.org \
--cc=thanh.quan.xn@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox