Devicetree
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Kuldeep Singh <kuldeep.singh@oss.qualcomm.com>,
	Abhinaba Rakshit <abhinaba.rakshit@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Manivannan Sadhasivam <mani@kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Ulf Hansson <ulfh@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Neeraj Soni <neeraj.soni@oss.qualcomm.com>,
	Harshal Dev <harshal.dev@oss.qualcomm.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-scsi@vger.kernel.org, linux-mmc@vger.kernel.org,
	devicetree@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Subject: Re: [PATCH v11 5/6] arm64: dts: qcom: monaco: Add OPP-table for ICE UFS and ICE eMMC nodes
Date: Mon, 29 Jun 2026 13:51:45 +0200	[thread overview]
Message-ID: <a8d05fb0-69c3-4905-9b05-e21bb6f3be2b@oss.qualcomm.com> (raw)
In-Reply-To: <86321e30-2bee-41bb-9d63-d0e6ab4154db@oss.qualcomm.com>

On 6/29/26 12:24 PM, Kuldeep Singh wrote:
>>>> Since 75 MHz and 201.6 Mhz require the same power level, is the former
>>>> OPP any useful?
>>>
>>> Yes, both use the same power requirements. However recommended by the ICE team,
>>> the DT should include all opp/freq supported by the hardware.
>>
>> Is there any reason at all where the OS would prefer the lower OPP?
>>
>> I think you at one point mentioned some dependency vs the storage
>> controller's clock frequency
> 
> I think Abhinaba captured all possible frequencies(even lowest ones) as
> what the hardware currently describes. It's upto storage controller
> running frequency and let it scale ice clocks to higher/lower to it's
> max capabilities.
> 
> Describing hardware based information also avoid revisiting DTs at later
> moment.

I agree conceptually and it would be easier to agree fully if you
gave me an answer like "this is useful when XYZ and ABC because DEF"
instead of deflecting the question to the obvious fact of the
hardware supporting that OPP

Konrad

  reply	other threads:[~2026-06-29 11:51 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-08 21:47 [PATCH v11 0/6] Enable ICE clock scaling Abhinaba Rakshit
2026-06-08 21:47 ` [PATCH v11 1/6] soc: qcom: ice: Add OPP-based clock scaling support for ICE Abhinaba Rakshit
2026-06-10 10:40   ` Manivannan Sadhasivam
2026-06-11 10:13     ` Abhinaba Rakshit
2026-06-18 13:01   ` Konrad Dybcio
2026-06-22  7:34     ` Abhinaba Rakshit
2026-06-29 11:08       ` Konrad Dybcio
2026-06-08 21:47 ` [PATCH v11 2/6] ufs: host: Add ICE clock scaling during UFS clock changes Abhinaba Rakshit
2026-06-08 21:57   ` Martin K. Petersen
2026-06-08 21:47 ` [PATCH v11 3/6] mmc: sdhci-msm: Set ICE clk to TURBO at sdhci ICE init Abhinaba Rakshit
2026-06-18 12:59   ` Konrad Dybcio
2026-06-22  7:54     ` Abhinaba Rakshit
2026-06-08 21:47 ` [PATCH v11 4/6] arm64: dts: qcom: kodiak: Add OPP-table for ICE UFS and ICE eMMC nodes Abhinaba Rakshit
2026-06-11 12:12   ` Kuldeep Singh
2026-06-15  8:03     ` Abhinaba Rakshit
2026-06-15 10:42       ` Kuldeep Singh
2026-06-18 13:03   ` Konrad Dybcio
2026-06-08 21:47 ` [PATCH v11 5/6] arm64: dts: qcom: monaco: " Abhinaba Rakshit
2026-06-11 12:20   ` Kuldeep Singh
2026-06-18 13:04   ` Konrad Dybcio
2026-06-22  7:38     ` Abhinaba Rakshit
2026-06-26 14:28       ` Konrad Dybcio
2026-06-29 10:24         ` Kuldeep Singh
2026-06-29 11:51           ` Konrad Dybcio [this message]
2026-06-08 21:47 ` [PATCH v11 6/6] arm64: dts: qcom: lemans: Add OPP-table for ICE UFS device node Abhinaba Rakshit
2026-06-11 12:23   ` Kuldeep Singh
2026-06-18 13:05   ` Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a8d05fb0-69c3-4905-9b05-e21bb6f3be2b@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=abhinaba.rakshit@oss.qualcomm.com \
    --cc=adrian.hunter@intel.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=harshal.dev@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=kuldeep.singh@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=neeraj.soni@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=ulfh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox