From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Sean Paul <sean@poorly.run>,
Marijn Suijten <marijn.suijten@somainline.org>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
devicetree@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters
Date: Tue, 9 Apr 2024 17:04:14 +0200 [thread overview]
Message-ID: <a8ea0f53-40c0-4fc5-94fc-a88f8e0319ac@linaro.org> (raw)
In-Reply-To: <zc5u7ixaser6ekl3sltzxccstu63tpydxybquxz5hcasj4cmfo@csjwfifugeod>
On 4/6/24 04:21, Dmitry Baryshkov wrote:
> On Fri, Apr 05, 2024 at 10:41:30AM +0200, Konrad Dybcio wrote:
>> Introduce getters for SoC product and feature codes and export them.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
[...]
>> + /* Ensure the value makes sense */
>> + if (raw_code >= SOCINFO_FC_INT_RESERVE)
>> + raw_code = SOCINFO_FC_UNKNOWN;
>
> This looks like a c&p from the previous function. Should we be comparing
> the raw_code with a SOCINFO_PC_ constant?
Looks like!
Konrad
next prev parent reply other threads:[~2024-04-09 15:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 8:41 [PATCH 0/6] Add SMEM-based speedbin matching Konrad Dybcio
2024-04-05 8:41 ` [PATCH 1/6] soc: qcom: Move some socinfo defines to the header, expand them Konrad Dybcio
2024-04-06 2:22 ` Dmitry Baryshkov
2024-04-11 18:55 ` Elliot Berman
2024-04-11 20:05 ` Konrad Dybcio
2024-04-11 20:09 ` Elliot Berman
2024-04-11 20:24 ` Konrad Dybcio
2024-04-11 23:49 ` Elliot Berman
2024-04-12 0:10 ` Konrad Dybcio
2024-04-12 0:49 ` Elliot Berman
2024-04-05 8:41 ` [PATCH 2/6] soc: qcom: smem: Add pcode/fcode getters Konrad Dybcio
2024-04-05 22:31 ` kernel test robot
2024-04-06 2:21 ` Dmitry Baryshkov
2024-04-09 15:04 ` Konrad Dybcio [this message]
2024-04-09 15:20 ` Bjorn Andersson
2024-04-11 19:09 ` Elliot Berman
2024-04-05 8:41 ` [PATCH 3/6] drm/msm/adreno: Allow specifying default speedbin value Konrad Dybcio
2024-04-06 2:56 ` Dmitry Baryshkov
2024-04-09 15:12 ` Konrad Dybcio
2024-04-09 15:23 ` Dmitry Baryshkov
2024-04-09 17:12 ` Rob Clark
2024-04-09 18:04 ` Dmitry Baryshkov
2024-04-09 18:07 ` Konrad Dybcio
2024-04-09 18:15 ` Dmitry Baryshkov
2024-04-09 18:27 ` Konrad Dybcio
2024-04-09 18:31 ` Dmitry Baryshkov
2024-04-10 11:47 ` Konrad Dybcio
2024-04-05 8:41 ` [PATCH 4/6] drm/msm/adreno: Implement SMEM-based speed bin Konrad Dybcio
2024-04-06 3:23 ` Dmitry Baryshkov
2024-04-10 11:42 ` Konrad Dybcio
2024-04-10 19:26 ` Dmitry Baryshkov
2024-04-11 21:35 ` Konrad Dybcio
2024-04-11 21:46 ` Dmitry Baryshkov
2024-04-11 22:14 ` Konrad Dybcio
2024-04-06 10:32 ` kernel test robot
2024-04-06 10:42 ` kernel test robot
2024-04-05 8:41 ` [PATCH 5/6] drm/msm/adreno: Add speedbin data for SM8550 / A740 Konrad Dybcio
2024-04-06 3:25 ` Dmitry Baryshkov
2024-04-09 15:13 ` Konrad Dybcio
2024-04-09 15:24 ` Dmitry Baryshkov
2024-04-09 18:13 ` Konrad Dybcio
2024-04-05 8:41 ` [PATCH 6/6] arm64: dts: qcom: sm8550: Wire up GPU speed bin & more OPPs Konrad Dybcio
2024-04-06 3:28 ` [PATCH 0/6] Add SMEM-based speedbin matching Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8ea0f53-40c0-4fc5-94fc-a88f8e0319ac@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_abhinavk@quicinc.com \
--cc=robdclark@gmail.com \
--cc=robh@kernel.org \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox