Re: [PATCH 06/72] ARM: dts: nxp: imx6qdl-wandboard: Replace clock-frequency in camera sensor node

[Frank Li <Frank.li@nxp.com>]

On Thu, Jul 10, 2025 at 11:34:21PM +0300, Laurent Pinchart wrote:
> Hi Frank,
>
> On Thu, Jul 10, 2025 at 04:18:39PM -0400, Frank Li wrote:
> > On Thu, Jul 10, 2025 at 08:47:02PM +0300, Laurent Pinchart wrote:
> > > The clock-frequency for camera sensors has been deprecated in favour of
> > > the assigned-clocks and assigned-clock-rates properties. Replace it in
> > > the device tree.
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > >  arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > index 26489eccd5fb..e5ac78ffb31c 100644
> > > --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-wandboard.dtsi
> > > @@ -136,8 +136,11 @@ camera@3c {
> > >  		pinctrl-names = "default";
> > >  		pinctrl-0 = <&pinctrl_ov5645>;
> > >  		reg = <0x3c>;
> > > +
> >
> > unnecessary empty line here
>
> There's often a blank line after the reg property. I don't mind dropping
> it here if that's preferred. Same for the other patch you reviewed.

This patch just drop clock-frequency. empty line is not related this at
all. So I perfer drop it.

Frank

>
> > >  		clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > -		clock-frequency = <24000000>;
> > > +		assigned-clocks = <&clks IMX6QDL_CLK_CKO2>;
> > > +		assigned-clock-rates = <24000000>;
> > > +
> > >  		vdddo-supply = <&reg_1p8v>;
> > >  		vdda-supply = <&reg_2p8v>;
> > >  		vddd-supply = <&reg_1p5v>;
>
> --
> Regards,
>
> Laurent Pinchart